-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new query profile collector fields with concurrent search execution #7898
Add new query profile collector fields with concurrent search execution #7898
Conversation
…ecution Signed-off-by: Ticheng Lin <ticheng@amazon.com>
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
server/src/main/java/org/opensearch/search/profile/query/CollectorResult.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/search/profile/query/CollectorResult.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/search/profile/query/InternalProfileCollector.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/search/profile/query/InternalProfileCollector.java
Outdated
Show resolved
Hide resolved
00d2519
to
c45a836
Compare
Gradle Check (Jenkins) Run Completed with:
|
e5f293c
to
1cd9337
Compare
Gradle Check (Jenkins) Run Completed with:
|
@reta Just wanted to confirm that this doc change will be needed as part of concurrent search GA not before that. This is because the output of profile will not show these fields before that. |
@ticheng-aws That is fine, you could mention the version this feature will be available |
server/src/main/java/org/opensearch/search/profile/query/ProfileCollector.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/search/profile/query/ProfileCollector.java
Outdated
Show resolved
Hide resolved
1cd9337
to
d308c36
Compare
Gradle Check (Jenkins) Run Completed with:
|
d308c36
to
77fb125
Compare
Gradle Check (Jenkins) Run Completed with:
|
… more tests Signed-off-by: Ticheng Lin <ticheng@amazon.com>
77fb125
to
5eedf6e
Compare
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: Ticheng Lin <51488860+ticheng-aws@users.noreply.github.com>
Gradle Check (Jenkins) Run Completed with:
|
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-7898-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 c58dc1ade9096ab70e22024e91eecd79fe2416e8
# Push it to GitHub
git push --set-upstream origin backport/backport-7898-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.x Then, create a pull request where the |
@ticheng-aws mind please to submit a manual backport to |
…on (opensearch-project#7898) * Bringing new query profile collector fields with concurrent search execution Signed-off-by: Ticheng Lin <ticheng@amazon.com> * Update CHANGELOG.md and fix gradle check format violations Signed-off-by: Ticheng Lin <ticheng@amazon.com> * Change query profile collector field data types to primitives and add more tests Signed-off-by: Ticheng Lin <ticheng@amazon.com> --------- Signed-off-by: Ticheng Lin <ticheng@amazon.com> Signed-off-by: Ticheng Lin <51488860+ticheng-aws@users.noreply.github.com> (cherry picked from commit c58dc1a) Signed-off-by: Ticheng Lin <ticheng@amazon.com>
#7975 backport for this PR has been created. |
…on (opensearch-project#7898) * Bringing new query profile collector fields with concurrent search execution Signed-off-by: Ticheng Lin <ticheng@amazon.com> * Update CHANGELOG.md and fix gradle check format violations Signed-off-by: Ticheng Lin <ticheng@amazon.com> * Change query profile collector field data types to primitives and add more tests Signed-off-by: Ticheng Lin <ticheng@amazon.com> --------- Signed-off-by: Ticheng Lin <ticheng@amazon.com> Signed-off-by: Ticheng Lin <51488860+ticheng-aws@users.noreply.github.com>
…on (opensearch-project#7898) * Bringing new query profile collector fields with concurrent search execution Signed-off-by: Ticheng Lin <ticheng@amazon.com> * Update CHANGELOG.md and fix gradle check format violations Signed-off-by: Ticheng Lin <ticheng@amazon.com> * Change query profile collector field data types to primitives and add more tests Signed-off-by: Ticheng Lin <ticheng@amazon.com> --------- Signed-off-by: Ticheng Lin <ticheng@amazon.com> Signed-off-by: Ticheng Lin <51488860+ticheng-aws@users.noreply.github.com>
…ollector fields with concurrent search execution (#7898) (#7975) * Add new query profile collector fields with concurrent search execution (#7898) * Bringing new query profile collector fields with concurrent search execution Signed-off-by: Ticheng Lin <ticheng@amazon.com> * Update CHANGELOG.md and fix gradle check format violations Signed-off-by: Ticheng Lin <ticheng@amazon.com> * Change query profile collector field data types to primitives and add more tests Signed-off-by: Ticheng Lin <ticheng@amazon.com> --------- Signed-off-by: Ticheng Lin <ticheng@amazon.com> Signed-off-by: Ticheng Lin <51488860+ticheng-aws@users.noreply.github.com> (cherry picked from commit c58dc1a) Signed-off-by: Ticheng Lin <ticheng@amazon.com> * Update server/src/main/java/org/opensearch/search/profile/query/CollectorResult.java Co-authored-by: Andriy Redko <drreta@gmail.com> Signed-off-by: Ticheng Lin <51488860+ticheng-aws@users.noreply.github.com> * Update server/src/main/java/org/opensearch/search/profile/query/CollectorResult.java Co-authored-by: Andriy Redko <drreta@gmail.com> Signed-off-by: Ticheng Lin <51488860+ticheng-aws@users.noreply.github.com> --------- Signed-off-by: Ticheng Lin <ticheng@amazon.com> Signed-off-by: Ticheng Lin <51488860+ticheng-aws@users.noreply.github.com> Co-authored-by: Andriy Redko <drreta@gmail.com>
…ollector fields with concurrent search execution (opensearch-project#7898) (opensearch-project#7975) * Add new query profile collector fields with concurrent search execution (opensearch-project#7898) * Bringing new query profile collector fields with concurrent search execution Signed-off-by: Ticheng Lin <ticheng@amazon.com> * Update CHANGELOG.md and fix gradle check format violations Signed-off-by: Ticheng Lin <ticheng@amazon.com> * Change query profile collector field data types to primitives and add more tests Signed-off-by: Ticheng Lin <ticheng@amazon.com> --------- Signed-off-by: Ticheng Lin <ticheng@amazon.com> Signed-off-by: Ticheng Lin <51488860+ticheng-aws@users.noreply.github.com> (cherry picked from commit c58dc1a) Signed-off-by: Ticheng Lin <ticheng@amazon.com> * Update server/src/main/java/org/opensearch/search/profile/query/CollectorResult.java Co-authored-by: Andriy Redko <drreta@gmail.com> Signed-off-by: Ticheng Lin <51488860+ticheng-aws@users.noreply.github.com> * Update server/src/main/java/org/opensearch/search/profile/query/CollectorResult.java Co-authored-by: Andriy Redko <drreta@gmail.com> Signed-off-by: Ticheng Lin <51488860+ticheng-aws@users.noreply.github.com> --------- Signed-off-by: Ticheng Lin <ticheng@amazon.com> Signed-off-by: Ticheng Lin <51488860+ticheng-aws@users.noreply.github.com> Co-authored-by: Andriy Redko <drreta@gmail.com>
…on (opensearch-project#7898) * Bringing new query profile collector fields with concurrent search execution Signed-off-by: Ticheng Lin <ticheng@amazon.com> * Update CHANGELOG.md and fix gradle check format violations Signed-off-by: Ticheng Lin <ticheng@amazon.com> * Change query profile collector field data types to primitives and add more tests Signed-off-by: Ticheng Lin <ticheng@amazon.com> --------- Signed-off-by: Ticheng Lin <ticheng@amazon.com> Signed-off-by: Ticheng Lin <51488860+ticheng-aws@users.noreply.github.com> Signed-off-by: Rishab Nahata <rnnahata@amazon.com>
…on (opensearch-project#7898) * Bringing new query profile collector fields with concurrent search execution Signed-off-by: Ticheng Lin <ticheng@amazon.com> * Update CHANGELOG.md and fix gradle check format violations Signed-off-by: Ticheng Lin <ticheng@amazon.com> * Change query profile collector field data types to primitives and add more tests Signed-off-by: Ticheng Lin <ticheng@amazon.com> --------- Signed-off-by: Ticheng Lin <ticheng@amazon.com> Signed-off-by: Ticheng Lin <51488860+ticheng-aws@users.noreply.github.com> Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Description
To show high-level concurrent execution details, we bring
min_slice_time_in_nanos
,max_slice_time_in_nanos
, andslice_count
etc. fields into the query response. With these new fields, users can quickly determine query performance and skew issues.Definition of existing collector fields
name
: A more friendly representation of the collector's class name.reason
: A "hint" to help provide some context about this collector.time_in_nanos
: The total elapsed time for this collector. In the concurrent search case, this is the total time across all slices (i.e.max(slice_end_time) - min(slice_start_time)
)children
: A list of children collectors "embedded" inside this collector.Definition of new collector fields with concurrent execution
reduce_time_in_nanos
: The elapsed time in the reduce phase.min_slice_time_in_nanos
: The minimum slice time for this collector manager.max_slice_time_in_nanos
: The maximum slice time for this collector manager.avg_slice_time_in_nanos
: The average slice time for this collector manager.slice_count
: The segment slice count for this collector manager.Related Issues
Resolves #7355
Doc update issue: opensearch-project/documentation-website#4281
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.