[Backport 2.x] [Bug] Fix Build Metadata

[opensearch-trigger-bot]

Backport 287ac90 from #7817.

depends on #8382

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/16502/
• CommitID: bf7a0dd
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure a flaky test unrelated to your change?

[reta]

Looks like a legit failure:

java.lang.AssertionError: Values should be different. Actual: unknown
	at __randomizedtesting.SeedInfo.seed([F2711EFE75B60760:DEB1795DDAEF982B]:0)
	at org.junit.Assert.fail(Assert.java:89)
	at org.junit.Assert.failEquals(Assert.java:187)
	at org.junit.Assert.assertNotEquals(Assert.java:163)
	at org.junit.Assert.assertNotEquals(Assert.java:177)
	at org.opensearch.BuildTests.testJarMetadata(BuildTests.java:65)

[dblock]

@Xtansia

[Xtansia]

@reta @dblock Test is failing because the refactoring in #7328 hasn't been backported to 2.x/2.8, so code source is evaluating to classes dir of server, whereas with refactoring it evaluates to the jar of opensearch-core.

If the refactor is not being backported then these backported fixes can probably be dropped.

Is the refactor supposed to be backported @nknize?

[nknize]

Yes, I actually forgot I hadn't backported that refactor yet. Let's hold off. We can either close these backport PRs or mark them as WIP until I backport all the remaining refactor PRs. I don't plan to do that until #8157 lands. Which is one of the big decoupling milestones we're working towards.

[opensearch-trigger-bot]

This PR is stalled because it has been open for 30 days with no activity. Remove stalled label or comment or this will be closed in 7 days.

[nknize]

I opened the #7328 backport PR. I'll approve and merge this after that PR is merged.

[dblock]

@nknize that was merged

[nknize]

Requisite backport PRs have landed. Will merge once checks pass here.

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/19473/
• CommitID: 3e769ea
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure a flaky test unrelated to your change?

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: UNSTABLE ❕
• TEST FAILURES:

      3 org.opensearch.search.SearchWeightedRoutingIT.testStrictWeightedRoutingWithCustomString

• URL: https://build.ci.opensearch.org/job/gradle-check/19474/
• CommitID: 3e769ea
  Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

[codecov]

Codecov Report

Merging #7818 (3e769ea) into 2.x (e3762b4) will increase coverage by 0.07%.
The diff coverage is 87.50%.

@@             Coverage Diff              @@
##                2.x    #7818      +/-   ##
============================================
+ Coverage     70.61%   70.68%   +0.07%     
+ Complexity    57114    57113       -1     
============================================
  Files          4748     4747       -1     
  Lines        270610   270565      -45     
  Branches      39941    39936       -5     
============================================
+ Hits         191079   191254     +175     
+ Misses        63132    62892     -240     
- Partials      16399    16419      +20     

Impacted Files	Coverage Δ
.../org/opensearch/common/util/LongHashBenchmark.java	0.00% <ø> (ø)
...n/src/main/java/org/opensearch/common/Classes.java	33.33% <ø> (ø)
.../src/main/java/org/opensearch/common/Explicit.java	63.63% <ø> (ø)
...rch/common/ExponentiallyWeightedMovingAverage.java	100.00% <ø> (ø)
...in/java/org/opensearch/common/LocalTimeOffset.java	87.75% <ø> (ø)
...java/org/opensearch/common/MacAddressProvider.java	40.62% <ø> (ø)
...main/java/org/opensearch/common/NamedRegistry.java	100.00% <ø> (ø)
...n/src/main/java/org/opensearch/common/Numbers.java	88.54% <ø> (+8.16%)	⬆️
...rg/opensearch/common/RandomBasedUUIDGenerator.java	100.00% <ø> (ø)
...java/org/opensearch/common/SecureRandomHolder.java	50.00% <ø> (ø)
... and 145 more

... and 413 files with indirect coverage changes