Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Extensions] Removing support for onIndexModule extension point #7674

Merged
merged 4 commits into from
May 23, 2023
Merged

[Extensions] Removing support for onIndexModule extension point #7674

merged 4 commits into from
May 23, 2023

Conversation

saratvemulapalli
Copy link
Member

Description

onIndexModule extension point was the first one to POC OpenSearch <-> extension communication.
The change was half baked with most of the feature of IndexModule not implemented.

Removing this code for now as its un-used and opened up opensearch-project/opensearch-sdk-java#776 to implement the feature cleanly.

Related Issues

Part of #7402

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@saratvemulapalli
Removing support for half baked IndexModule extension point
c5c6c60 
Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>
@saratvemulapalli saratvemulapalli changed the title [Extensions] Removing support for half baked IndexModule extension point [Extensions] Removing support for IndexModule extension point May 22, 2023
@saratvemulapalli saratvemulapalli changed the title [Extensions] Removing support for IndexModule extension point [Extensions] Removing support for onIndexModule extension point May 22, 2023
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@saratvemulapalli
Adding spotless changes
3f696ba 
Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@saratvemulapalli
Copy link
Member Author

Gradle Check (Jenkins) Run Completed with:

org.opensearch.backwards.IndexingIT.testUpdateSnapshotStatus
org.opensearch.backwards.IndexingIT.testSyncedFlushTransition
org.opensearch.backwards.IndexingIT.testSeqNoCheckpoints
org.opensearch.backwards.IndexingIT.testUpdateSnapshotStatus
org.opensearch.backwards.IndexingIT.testUpdateSnapshotStatus
org.opensearch.backwards.IndexingIT.testUpdateSnapshotStatus
org.opensearch.upgrades.RecoveryIT.testAutoExpandIndicesDuringRollingUpgrade
org.opensearch.upgrades.RecoveryIT.testRecoveryWithConcurrentIndexing
org.opensearch.upgrades.RecoveryIT.testRelocationWithConcurrentIndexing
org.opensearch.upgrades.RecoveryIT.testAutoExpandIndicesDuringRollingUpgrade
org.opensearch.upgrades.RecoveryIT.testRecoveryWithConcurrentIndexing
org.opensearch.upgrades.RecoveryIT.testRelocationWithConcurrentIndexing
org.opensearch.upgrades.RecoveryIT.testAutoExpandIndicesDuringRollingUpgrade
org.opensearch.upgrades.RecoveryIT.testRecoveryWithConcurrentIndexing
org.opensearch.upgrades.RecoveryIT.testRelocationWithConcurrentIndexing
org.opensearch.upgrades.RecoveryIT.testAutoExpandIndicesDuringRollingUpgrade
org.opensearch.upgrades.RecoveryIT.testRecoveryWithConcurrentIndexing
org.opensearch.upgrades.RecoveryIT.testRelocationWithConcurrentIndexing
org.opensearch.cluster.allocation.AwarenessAllocationIT.testThreeZoneOneReplicaWithForceZoneValueAndLoadAwareness

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@saratvemulapalli saratvemulapalli mentioned this pull request May 23, 2023
Closed
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@saratvemulapalli
Removing support for half baked IndexModule extension point
cba67ef 
Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>
@saratvemulapalli
Merge branch 'main' into remove-on-index-module
51d6d18 
Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@codecov
Copy link

codecov bot commented May 23, 2023

Codecov Report

Merging #7674 (51d6d18) into main (b4b3724) will increase coverage by 70.87%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             main    #7674       +/-   ##
===========================================
+ Coverage        0   70.87%   +70.87%     
- Complexity      0    56142    +56142     
===========================================
  Files           0     4680     +4680     
  Lines           0   266018   +266018     
  Branches        0    39060    +39060     
===========================================
+ Hits            0   188537   +188537     
- Misses          0    61435    +61435     
- Partials        0    16046    +16046
Impacted Files Coverage Δ
...a/org/opensearch/extensions/ExtensionsManager.java 55.00% <ø> (ø)
...g/opensearch/extensions/NoopExtensionsManager.java 62.50% <ø> (ø)
...in/java/org/opensearch/indices/IndicesService.java 69.24% <ø> (ø)
server/src/main/java/org/opensearch/node/Node.java 86.15% <ø> (ø)

... and 4676 files with indirect coverage changes

@saratvemulapalli saratvemulapalli added the backport 2.x Backport to 2.x branch label May 23, 2023
vibrantvarun
vibrantvarun approved these changes May 23, 2023
View reviewed changes
Copy link
Member

@vibrantvarun vibrantvarun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just here to understand the PR changes. I understood the changes and the reason of removal of onIndex module for now.

Thanks @saratvemulapalli LGTM

@saratvemulapalli saratvemulapalli merged commit fb0ff06 into opensearch-project:main May 23, 2023
@saratvemulapalli saratvemulapalli deleted the remove-on-index-module branch May 23, 2023 20:32
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request May 23, 2023
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request May 23, 2023
@github-actions
[Extensions] Removing support for onIndexModule extension point (#7674)
e6cbf32 
* Removing support for half baked IndexModule extension point

Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>

* Adding spotless changes

Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>

* Removing support for half baked IndexModule extension point

Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>

---------

Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>
(cherry picked from commit fb0ff06)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
saratvemulapalli pushed a commit that referenced this pull request May 23, 2023
@opensearch-trigger-bot @github-actions
[Extensions] Removing support for onIndexModule extension point (#7674)…
4b9019e 
… (#7706)

* Removing support for half baked IndexModule extension point



* Adding spotless changes



* Removing support for half baked IndexModule extension point



---------


(cherry picked from commit fb0ff06)

Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@owaiskazi19 owaiskazi19 mentioned this pull request May 23, 2023
Merged
dblock pushed a commit to dblock/OpenSearch that referenced this pull request May 25, 2023
@saratvemulapalli @dblock
[Extensions] Removing support for onIndexModule extension point (open…
00a312e 
…search-project#7674)

* Removing support for half baked IndexModule extension point

Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>

* Adding spotless changes

Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>

* Removing support for half baked IndexModule extension point

Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>

---------

Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>
suranjay pushed a commit to suranjay/OpenSearch that referenced this pull request May 29, 2023
@saratvemulapalli @suranjay
[Extensions] Removing support for onIndexModule extension point (open…
ed7a491 
…search-project#7674)

* Removing support for half baked IndexModule extension point

Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>

* Adding spotless changes

Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>

* Removing support for half baked IndexModule extension point

Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>

---------

Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>
stephen-crawford pushed a commit to stephen-crawford/OpenSearch that referenced this pull request May 31, 2023
@saratvemulapalli @stephen-crawford
[Extensions] Removing support for onIndexModule extension point (open…
8aee341 
…search-project#7674)

* Removing support for half baked IndexModule extension point

Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>

* Adding spotless changes

Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>

* Removing support for half baked IndexModule extension point

Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>

---------

Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
@saratvemulapalli @shiv0408
[Extensions] Removing support for onIndexModule extension point (open…
ad7251f 
…search-project#7674)

* Removing support for half baked IndexModule extension point

Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>

* Adding spotless changes

Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>

* Removing support for half baked IndexModule extension point

Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>

---------

Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vibrantvarun vibrantvarun vibrantvarun approved these changes

@owaiskazi19 owaiskazi19 owaiskazi19 approved these changes

@reta reta Awaiting requested review from reta reta is a code owner

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@setiah setiah Awaiting requested review from setiah

@kartg kartg Awaiting requested review from kartg

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@ryanbogan ryanbogan Awaiting requested review from ryanbogan

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@dreamer-89 dreamer-89 Awaiting requested review from dreamer-89

@tlfeng tlfeng Awaiting requested review from tlfeng

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

Assignees
No one assigned
Labels
backport 2.x Backport to 2.x branch extensions skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@saratvemulapalli @owaiskazi19 @vibrantvarun