-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport] [Segment Replication] Added mixed and rolling upgrade bwc test (#7537) #7626
[Backport] [Segment Replication] Added mixed and rolling upgrade bwc test (#7537) #7626
Conversation
Gradle Check (Jenkins) Run Completed with:
|
The test currently fails as segment replication is not available for 1.x branch. One possible hack would be to check node version for all nodes and return in case any node running on 1.x but it is not clean. @reta : Would you know a way around this ?
|
fe81780
to
58830ea
Compare
Gradle Check (Jenkins) Run Completed with:
|
Hit couple of issues while working on backport PR.
|
Gradle Check (Jenkins) Run Completed with:
|
qa/mixed-cluster/src/test/java/org/opensearch/backwards/IndexingIT.java
Outdated
Show resolved
Hide resolved
qa/mixed-cluster/src/test/java/org/opensearch/backwards/IndexingIT.java
Outdated
Show resolved
Hide resolved
qa/mixed-cluster/src/test/java/org/opensearch/backwards/IndexingIT.java
Outdated
Show resolved
Hide resolved
qa/rolling-upgrade/src/test/java/org/opensearch/upgrades/IndexingIT.java
Show resolved
Hide resolved
Gradle Check (Jenkins) Run Completed with:
|
…points and skip tests for 1.x bwc versions (opensearch-project#8203) * [Segment Replication] Verify segment replication stats in bwc test Signed-off-by: Suraj Singh <surajrider@gmail.com> * Log cleanup Signed-off-by: Suraj Singh <surajrider@gmail.com> * Spotless check Signed-off-by: Suraj Singh <surajrider@gmail.com> * Add version check to skip test for 1.x bwc branches Signed-off-by: Suraj Singh <surajrider@gmail.com> * Add version check to skip test for 1.x bwc branches for mixed clusters Signed-off-by: Suraj Singh <surajrider@gmail.com> * Add version string in build to identify bwc version Signed-off-by: Suraj Singh <surajrider@gmail.com> * Use correct bwc version string Signed-off-by: Suraj Singh <surajrider@gmail.com> * Address review comments from opensearch-project#7626 Signed-off-by: Suraj Singh <surajrider@gmail.com> --------- Signed-off-by: Suraj Singh <surajrider@gmail.com> Signed-off-by: Rishab Nahata <rnnahata@amazon.com>
PR is blocked due to #8322 where replica shard segment replication stats (_cat/segment_replication) are not updated on primary. |
…points and skip tests for 1.x bwc versions (opensearch-project#8203) * [Segment Replication] Verify segment replication stats in bwc test Signed-off-by: Suraj Singh <surajrider@gmail.com> * Log cleanup Signed-off-by: Suraj Singh <surajrider@gmail.com> * Spotless check Signed-off-by: Suraj Singh <surajrider@gmail.com> * Add version check to skip test for 1.x bwc branches Signed-off-by: Suraj Singh <surajrider@gmail.com> * Add version check to skip test for 1.x bwc branches for mixed clusters Signed-off-by: Suraj Singh <surajrider@gmail.com> * Add version string in build to identify bwc version Signed-off-by: Suraj Singh <surajrider@gmail.com> * Use correct bwc version string Signed-off-by: Suraj Singh <surajrider@gmail.com> * Address review comments from opensearch-project#7626 Signed-off-by: Suraj Singh <surajrider@gmail.com> --------- Signed-off-by: Suraj Singh <surajrider@gmail.com> [Segment Replication] Use _cat/segments vs index stats + _search to verify doc count Signed-off-by: Suraj Singh <surajrider@gmail.com> Self review Signed-off-by: Suraj Singh <surajrider@gmail.com> remove unused imports Signed-off-by: Suraj Singh <surajrider@gmail.com> Handle 0 doc count segments Signed-off-by: Suraj Singh <surajrider@gmail.com> Add missing import statement Signed-off-by: Suraj Singh <surajrider@gmail.com>
93ed0cf
to
51397d5
Compare
Gradle Check (Jenkins) Run Completed with:
|
…points and skip tests for 1.x bwc versions (opensearch-project#8203) * [Segment Replication] Verify segment replication stats in bwc test Signed-off-by: Suraj Singh <surajrider@gmail.com> * Log cleanup Signed-off-by: Suraj Singh <surajrider@gmail.com> * Spotless check Signed-off-by: Suraj Singh <surajrider@gmail.com> * Add version check to skip test for 1.x bwc branches Signed-off-by: Suraj Singh <surajrider@gmail.com> * Add version check to skip test for 1.x bwc branches for mixed clusters Signed-off-by: Suraj Singh <surajrider@gmail.com> * Add version string in build to identify bwc version Signed-off-by: Suraj Singh <surajrider@gmail.com> * Use correct bwc version string Signed-off-by: Suraj Singh <surajrider@gmail.com> * Address review comments from opensearch-project#7626 Signed-off-by: Suraj Singh <surajrider@gmail.com> --------- Signed-off-by: Suraj Singh <surajrider@gmail.com>
…points and skip tests for 1.x bwc versions (opensearch-project#8203) * [Segment Replication] Verify segment replication stats in bwc test Signed-off-by: Suraj Singh <surajrider@gmail.com> * Log cleanup Signed-off-by: Suraj Singh <surajrider@gmail.com> * Spotless check Signed-off-by: Suraj Singh <surajrider@gmail.com> * Add version check to skip test for 1.x bwc branches Signed-off-by: Suraj Singh <surajrider@gmail.com> * Add version check to skip test for 1.x bwc branches for mixed clusters Signed-off-by: Suraj Singh <surajrider@gmail.com> * Add version string in build to identify bwc version Signed-off-by: Suraj Singh <surajrider@gmail.com> * Use correct bwc version string Signed-off-by: Suraj Singh <surajrider@gmail.com> * Address review comments from opensearch-project#7626 Signed-off-by: Suraj Singh <surajrider@gmail.com> --------- Signed-off-by: Suraj Singh <surajrider@gmail.com> [Segment Replication] Use _cat/segments vs index stats + _search to verify doc count Signed-off-by: Suraj Singh <surajrider@gmail.com> Self review Signed-off-by: Suraj Singh <surajrider@gmail.com> remove unused imports Signed-off-by: Suraj Singh <surajrider@gmail.com> Handle 0 doc count segments Signed-off-by: Suraj Singh <surajrider@gmail.com> Add missing import statement Signed-off-by: Suraj Singh <surajrider@gmail.com>
51397d5
to
8fc0515
Compare
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
…earch-project#7537) * [Segment Replication] Added mixed cluster bwc test Signed-off-by: Suraj Singh <surajrider@gmail.com> * Remove unnecessary gradle task for segrep Signed-off-by: Suraj Singh <surajrider@gmail.com> * Spotless fix Signed-off-by: Suraj Singh <surajrider@gmail.com> * Spotless fix Signed-off-by: Suraj Singh <surajrider@gmail.com> * [Segment Replication] Rolling upgrade test Signed-off-by: Suraj Singh <surajrider@gmail.com> * PR feedback and cleanup Signed-off-by: Suraj Singh <surajrider@gmail.com> * Verify replica doc count only when it is assigned Signed-off-by: Suraj Singh <surajrider@gmail.com> * Remove wait for yellow cluster Signed-off-by: Suraj Singh <surajrider@gmail.com> --------- Signed-off-by: Suraj Singh <surajrider@gmail.com> (cherry picked from commit 0788feb) Add version check to skip test for 1.x bwc branches Signed-off-by: Suraj Singh <surajrider@gmail.com>
…to shard allocation map (opensearch-project#7876) * [Segment Replication] Wait for shard relocation before building node to shard allocation map Signed-off-by: Suraj Singh <surajrider@gmail.com> * Remove unused imports Signed-off-by: Suraj Singh <surajrider@gmail.com> --------- Signed-off-by: Suraj Singh <surajrider@gmail.com> Fix imports Signed-off-by: Suraj Singh <surajrider@gmail.com>
…points and skip tests for 1.x bwc versions (opensearch-project#8203) * [Segment Replication] Verify segment replication stats in bwc test Signed-off-by: Suraj Singh <surajrider@gmail.com> * Log cleanup Signed-off-by: Suraj Singh <surajrider@gmail.com> * Spotless check Signed-off-by: Suraj Singh <surajrider@gmail.com> * Add version check to skip test for 1.x bwc branches Signed-off-by: Suraj Singh <surajrider@gmail.com> * Add version check to skip test for 1.x bwc branches for mixed clusters Signed-off-by: Suraj Singh <surajrider@gmail.com> * Add version string in build to identify bwc version Signed-off-by: Suraj Singh <surajrider@gmail.com> * Use correct bwc version string Signed-off-by: Suraj Singh <surajrider@gmail.com> * Address review comments from opensearch-project#7626 Signed-off-by: Suraj Singh <surajrider@gmail.com> --------- Signed-off-by: Suraj Singh <surajrider@gmail.com> [Segment Replication] Use _cat/segments vs index stats + _search to verify doc count Signed-off-by: Suraj Singh <surajrider@gmail.com> Self review Signed-off-by: Suraj Singh <surajrider@gmail.com> remove unused imports Signed-off-by: Suraj Singh <surajrider@gmail.com> Handle 0 doc count segments Signed-off-by: Suraj Singh <surajrider@gmail.com> Add missing import statement Signed-off-by: Suraj Singh <surajrider@gmail.com>
…ation (opensearch-project#8267) * [Segment Replication] Use _cat/segments vs index stats + _search to verify doc count Signed-off-by: Suraj Singh <surajrider@gmail.com> Self review Signed-off-by: Suraj Singh <surajrider@gmail.com> remove unused imports Signed-off-by: Suraj Singh <surajrider@gmail.com> Handle 0 doc count segments Signed-off-by: Suraj Singh <surajrider@gmail.com> * Use 1 minute timeout for assertBusy validations and comments Signed-off-by: Suraj Singh <surajrider@gmail.com> --------- Signed-off-by: Suraj Singh <surajrider@gmail.com> Add missing import statement Signed-off-by: Suraj Singh <surajrider@gmail.com>
Signed-off-by: Suraj Singh <surajrider@gmail.com>
609e662
to
8005cb6
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Signed-off-by: Suraj Singh <surajrider@gmail.com>
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## 2.x #7626 +/- ##
============================================
- Coverage 70.69% 70.62% -0.08%
+ Complexity 57214 57205 -9
============================================
Files 4747 4747
Lines 270933 270933
Branches 39975 39975
============================================
- Hits 191544 191340 -204
- Misses 62909 63208 +299
+ Partials 16480 16385 -95 |
…points and skip tests for 1.x bwc versions (opensearch-project#8203) * [Segment Replication] Verify segment replication stats in bwc test Signed-off-by: Suraj Singh <surajrider@gmail.com> * Log cleanup Signed-off-by: Suraj Singh <surajrider@gmail.com> * Spotless check Signed-off-by: Suraj Singh <surajrider@gmail.com> * Add version check to skip test for 1.x bwc branches Signed-off-by: Suraj Singh <surajrider@gmail.com> * Add version check to skip test for 1.x bwc branches for mixed clusters Signed-off-by: Suraj Singh <surajrider@gmail.com> * Add version string in build to identify bwc version Signed-off-by: Suraj Singh <surajrider@gmail.com> * Use correct bwc version string Signed-off-by: Suraj Singh <surajrider@gmail.com> * Address review comments from opensearch-project#7626 Signed-off-by: Suraj Singh <surajrider@gmail.com> --------- Signed-off-by: Suraj Singh <surajrider@gmail.com> Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Manual backport to 2.x for below PRs
Resolves #8202