[Backport 2.x][Search Pipelines] Support ad hoc pipelines #7253 #7473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* [Search Pipelines] Support ad hoc pipelines This change allows a search pipeline to be defined within a search request body. This will take precedence over any other search pipeline, and allows ad hoc testing of pipeline configurations before persisting the pipeline definition in cluster state. Signed-off-by: Michael Froh <froh@amazon.com> * Added changelog entry Signed-off-by: Michael Froh <froh@amazon.com> * Incorporate feedback from @reta Resolve + transform request into PipelinedRequest, then use that to transform the search response. Signed-off-by: Michael Froh <froh@amazon.com> * Incorporate more feedback from @reta 1. Create all streams in try-with-resources. 2. Keep methods in Pipeline package-private. 3. Remove spurious character in CHANGELOG. Also, I remembered that in a future change, I'm going to call the no-op pipeline "_none" (like when bypassing an ingest pipeline) so I should name it "_none" from the start. Signed-off-by: Michael Froh <froh@amazon.com> * Incorporate feedback from @andrross - Added opensearch.internal annotation to PipelinedRequest. - Made PipelinedRequest final. - Removed TODO from PipelinedRequest. - Moved changelog entry to 2.x. Signed-off-by: Michael Froh <froh@amazon.com> --------- Signed-off-by: Michael Froh <froh@amazon.com> (cherry picked from commit c43d713)
Signed-off-by: Michael Froh <froh@amazon.com>
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## 2.x #7473 +/- ##
============================================
- Coverage 70.34% 70.27% -0.07%
+ Complexity 59895 59868 -27
============================================
Files 4873 4876 +3
Lines 288170 288271 +101
Branches 41897 41911 +14
============================================
- Hits 202699 202576 -123
- Misses 68470 68665 +195
- Partials 17001 17030 +29
|
reta
approved these changes
May 9, 2023
reta
reviewed
May 9, 2023
server/src/main/java/org/opensearch/search/builder/SearchSourceBuilder.java
Show resolved
Hide resolved
6 tasks
@kotwanikunal -- done! |
4 tasks
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backport #7253 to 2.x (since auto-backport failed).
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.