-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Data Streams in OpenSearch #690
Conversation
…Refactored tests. Signed-off-by: Ketan Verma <ketan9495@gmail.com>
Signed-off-by: Ketan Verma <ketan9495@gmail.com>
✅ Gradle Wrapper Validation success d9b2521 |
✅ DCO Check Passed d9b2521 |
✅ Gradle Precommit success d9b2521 |
start gradle check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good; one backwards compatibility addition needed
server/src/main/java/org/opensearch/cluster/metadata/ComposableIndexTemplate.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/cluster/metadata/ComposableIndexTemplate.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Ketan Verma <ketan9495@gmail.com>
✅ Gradle Wrapper Validation success 32cedcd |
✅ DCO Check Passed 32cedcd |
✅ Gradle Precommit success 32cedcd |
start gradle check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Nice to get this out there!
Thank you for working this enhancement. Can you open a backport PR to the 1.x branch? The pending label will stay applied until we merge to 1.x. |
This commit adds support for data streams by adding a DataStreamFieldMapper, and making timestamp field name configurable. Backwards compatibility is supported. Signed-off-by: Ketan Verma <ketan9495@gmail.com>
* Adding an example for bulk update operation Signed-off-by: Karthik Subramanian <karthiks3000@yahoo.com> * updated the changelog.md Signed-off-by: Karthik Subramanian <karthiks3000@yahoo.com> * changes made by spotlessApply Signed-off-by: Karthik Subramanian <karthiks3000@yahoo.com> * removing CommonUtil based on review comments Signed-off-by: Karthik Subramanian <karthiks3000@yahoo.com> * reverting files to original state Signed-off-by: Karthik Subramanian <karthiks3000@yahoo.com> * changes by spotlessApply Signed-off-by: Karthik Subramanian <karthiks3000@yahoo.com> * removing static fields and unnecessary waits Signed-off-by: Karthik Subramanian <karthiks3000@yahoo.com> * changes as per review comments Signed-off-by: Karthik Subramanian <karthiks3000@yahoo.com> * removing unnecessary changes Signed-off-by: Karthik Subramanian <karthiks3000@yahoo.com> --------- Signed-off-by: Karthik Subramanian <karthiks3000@yahoo.com>
Description
This PR aims to add the missing
MetadataFieldMapper
required to parse the_data_stream_timestamp
metadata field mapping used to create data streams and to perform timestamp field validation on the ingested documents. This PR also allows users to change the default timestamp field name (from "@timestamp") as required using an index template.Issues Resolved
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.
Signed-off-by: Ketan Verma ketan9495@gmail.com