[Backport] [2.x] Removed NOT_FOUND for empty results. (#6544) #6614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Removed NOT_FOUND for empty results. Signed-off-by: Harsh Jain <harshjai@amazon.com> * Fixed failing tests. Signed-off-by: Harsh Jain <harshjai@amazon.com> * Removed unnecessary semi-colon. Signed-off-by: Harsh Jain <harshjai@amazon.com> Signed-off-by: Harsh Jain <harshjai@amazon.com> * Added change log. Signed-off-by: Harsh Jain <harshjai@amazon.com> * Fixed formatting issues Signed-off-by: Harsh Jain <harshjai@amazon.com> * Backported to 2.x branch Signed-off-by: Harsh Jain <harshjai@amazon.com> * Removed duplicate entry as this entry is present under [Unrelease 2.x]. Signed-off-by: Harsh Jain <harshjai@amazon.com> * Updated changelog to make it more meaningful. Signed-off-by: Harsh Jain <harshjai@amazon.com> --------- Signed-off-by: Harsh Jain <harshjai@amazon.com> Co-authored-by: Harsh Jain <harshjai@amazon.com> (cherry picked from commit 67a9b43)
6 tasks
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## 2.x #6614 +/- ##
============================================
- Coverage 70.49% 70.43% -0.07%
+ Complexity 59343 59285 -58
============================================
Files 4800 4800
Lines 284649 284648 -1
Branches 41355 41355
============================================
- Hits 200654 200482 -172
- Misses 67262 67407 +145
- Partials 16733 16759 +26
... and 509 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
reta
approved these changes
Mar 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix for the issue due to which 404 was returned when no PITs were present.
Backport to 2.x branch failed #6544
Issues Resolved
#5938
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.