Fix snapshot deletion task getting stuck in the event of exceptions #628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
This commit fixes VersionTests and VersionUtilsTests to where all but the gradle test is passing. Next the gradle version logic needs to be fixed to mirror VersionUtils. Note that this implementation is a hack of the horrible versioning hack implementation of the predecessor. The public issue will be updated to solicit "help wanted" to rearchitect the versioning logic. Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
Signed-off-by: Rabi Panda <adnapibar@gmail.com>
Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
This commit fixes the references to current version in several places. This resolves some of the failing tests. * Fix reindex test failures. * Fix license header for LegacyESVersion. * Fix failing tests in ExceptionSerializationTests. * Fix failing tests in NodeJoinControllerTests. * Fix failing tests in ListPluginsCommandTests. * Fix parent-join yaml rest test, change the version used in the yaml and remove redundant setup sections. * Fix failing tests in EdgeNGramTokenizerTests. Signed-off-by: Rabi Panda <adnapibar@gmail.com>
### Description syncing my fork By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check [here](https://github.com/opensearch-project/OpenSearch/blob/main/CONTRIBUTING.md#developer-certificate-of-origin).
# Conflicts: # buildSrc/src/main/java/org/opensearch/gradle/BwcVersions.java # buildSrc/version.properties # server/src/main/java/org/opensearch/LegacyESVersion.java # server/src/main/java/org/opensearch/Version.java # server/src/test/java/org/opensearch/BuildTests.java # server/src/test/java/org/opensearch/VersionTests.java # server/src/test/java/org/opensearch/common/lucene/uid/VersionsTests.java # server/src/test/java/org/opensearch/discovery/zen/NodeJoinControllerTests.java
|
❌ DCO Check Failed 85b5d05 |
|
something went wrong with this branch, starting over... |
ritty27
pushed a commit
to ritty27/OpenSearch
that referenced
this pull request
May 12, 2024
opensearch-project#628) * move "software.amazon.awssdk" dependencies to the compileOnly scope. Signed-off-by: Dmitry Kaukov <dkaukov@opentable.com> * PR feedback Signed-off-by: Dmitry Kaukov <dkaukov@opentable.com> * PR feedback Signed-off-by: Dmitry Kaukov <dkaukov@opentable.com> --------- Signed-off-by: Dmitry Kaukov <dkaukov@opentable.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The snapshot deletion task would get stuck in the event of a bulk delete that resulted in some exceptions. Due to a bug in the recursive function handling the deletion calls.
Issues Resolved
fixes #627
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.