[Backport 2.x] build: harden worfklows permissions (#4587) #6097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
andrross
reviewed
Jan 30, 2023
CHANGELOG.md
Outdated
| @@ -12,6 +12,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), | |||
| - Replace latches with CompletableFutures for extensions ([#5646](https://github.com/opensearch-project/OpenSearch/pull/5646)) | |||
| - Add support to disallow search request with preference parameter with strict weighted shard routing([#5874](https://github.com/opensearch-project/OpenSearch/pull/5874)) | |||
| - Added support to apply index create block ([#4603](https://github.com/opensearch-project/OpenSearch/issues/4603)) | |||
| - Hardened token permissions in GitHub workflows ([#4587](https://github.com/opensearch-project/OpenSearch/pull/4587)) | |||
There was a problem hiding this comment.
Build-related stuff can stay out of the CHANGELOG so let's nix this. We can also remove the line from the 3.0 section of the CHANGELOG on the main branch.
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: sashashura <aleksandrosansan@gmail.com> Signed-off-by: sashashura <aleksandrosansan@gmail.com> (cherry picked from commit d266a73) Signed-off-by: Marc Handalian <handalm@amazon.com>
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## 2.x #6097 +/- ##
============================================
+ Coverage 70.49% 70.59% +0.10%
- Complexity 59011 59048 +37
============================================
Files 4770 4771 +1
Lines 282712 282733 +21
Branches 41175 41179 +4
============================================
+ Hits 199302 199605 +303
+ Misses 66761 66461 -300
- Partials 16649 16667 +18
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
6 tasks
Gradle Check (Jenkins) Run Completed with:
|
andrross
approved these changes
Jan 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: sashashura aleksandrosansan@gmail.com
Signed-off-by: sashashura aleksandrosansan@gmail.com
(cherry picked from commit d266a73)
Description
This is a backport of #4587 to 2.x
Issues Resolved
N/A
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.