Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partially resolved issue #4687 by changing the improper status code for concurrent snapshot executions #5855

Closed
Closed
Changes from 2 commits
Commits
Show all changes
203 commits
Select commit Hold shift + click to select a range
05874f3
Changed status of ConcurrentSnapshotException from 5xx -> 429(Too_Man…
baba-devv Jan 12, 2023
1395a14
Merge branch 'main' of github.com:baba-devv/OpenSearch into Mani-Exce…
baba-devv Jan 13, 2023
114e6bc
Merge branch 'main' of github.com:baba-devv/OpenSearch into Mani-Exce…
baba-devv Jan 16, 2023
dda7f85
Merge branch 'main' of github.com:baba-devv/OpenSearch into Mani-Exce…
baba-devv Jan 17, 2023
ed74bf2
Merge branch 'main' of github.com:baba-devv/OpenSearch into Mani-Exce…
baba-devv Jan 19, 2023
439bf24
Merge branch 'main' of github.com:baba-devv/OpenSearch into Mani-Exce…
baba-devv Jan 19, 2023
50da23f
Added test case for ConcurrentSnapshotException -> 429(Too_Many_Reque…
baba-devv Jan 19, 2023
d3cff6b
Merge branch 'main' of github.com:opensearch-project/OpenSearch into …
baba-devv Apr 21, 2023
08ffb33
Added test case for ConcurrentSnapshotException -> 429(Too_Many_Reque…
baba-devv Apr 29, 2023
023be3d
Added test case for ConcurrentSnapshotException -> 429(Too_Many_Reque…
baba-devv Apr 29, 2023
edf182f
Return 409 Conflict HTTP status instead of 500 on failure to concurre…
baba-devv Jun 25, 2023
b2ff95f
Return 409 Conflict HTTP status instead of 500 on failure to concurre…
baba-devv Jun 25, 2023
4649e21
Return 409 Conflict HTTP status instead of 500 on failure to concurre…
baba-devv Jun 25, 2023
b285b62
Bump org.apache.hadoop:hadoop-minicluster from 3.3.5 to 3.3.6 in /tes…
dependabot[bot] Jun 26, 2023
65f13e8
Bump com.networknt:json-schema-validator from 1.0.84 to 1.0.85 in /bu…
dependabot[bot] Jun 26, 2023
ec38404
Bump io.projectreactor.netty:reactor-netty-http from 1.1.7 to 1.1.8 i…
dependabot[bot] Jun 26, 2023
5c82e2d
Bump org.jruby.joni:joni from 2.1.48 to 2.2.1 (#8254)
dependabot[bot] Jun 26, 2023
f3fe1a2
Add integ tests for remote store stats api (#8135)
linuxpi Jun 26, 2023
0d6117f
[Upgrade] Lucene 9.7.0 release (#8272)
nknize Jun 27, 2023
20c634e
Fix SegmentReplication flaky integ tests (#8134)
sachinpkale Jun 27, 2023
5b34d80
[Remote Store] Add remote segment upload backpressure integ tests (#8…
ashking94 Jun 27, 2023
2e3c02c
Bump `resteasy-jackson2-provider` from 3.0.26.Final to 6.2.4.Final in…
Xtansia Jun 27, 2023
c20668e
Fix Apache Lucene verson for 2.9.0 release (#8290)
reta Jun 27, 2023
9d58b8d
[Snapshot Interop] Add Changes in Restore Snapshot Flow for remote st…
harishbhakuni Jun 27, 2023
f002709
Remove minimum file cache size restriction (#8294)
kotwanikunal Jun 27, 2023
edb5821
Removed redundant ubuntu precommit check (#8207)
owaiskazi19 Jun 27, 2023
1482d07
Add request tracing framework (#7648)
suranjay Jun 28, 2023
79d1779
Added release notes for 1.3.11 (#8302)
owaiskazi19 Jun 28, 2023
a8108f6
[Snapshot Interop] Change Version Checks from 3.0 to 2.9 in Restore S…
harishbhakuni Jun 28, 2023
9b08947
[Segment Replication] Update bwc test to rely on segments for verific…
dreamer-89 Jun 28, 2023
31d9ea7
[Mute] SegRepUsingRemoteStoreIT.testPressureServiceStats (#8324)
nknize Jun 28, 2023
aa54b4e
Bump BouncyCastle from jdk15on to jdk15to18 (#8247)
willyborankin Jun 28, 2023
a06ab7c
[Search Pipelines] Add stats for search pipelines (#8053)
msfroh Jun 28, 2023
a019032
Self-organizing hash table to improve the performance of bucket aggre…
ketanv3 Jun 28, 2023
d322fd7
Bump com.google.api-client:google-api-client from 1.34.0 to 2.2.0 in …
Xtansia Jun 28, 2023
0e8e8dc
Moving zstd out of sandbox (#7908)
sarthakaggarwal97 Jun 29, 2023
8d5752e
Implement buildEmptyAggregations for MultiTermsAggregator (#7089) (#7…
austintlee Jun 29, 2023
cf732b7
Adding the SearchPhaseResultsProcessor interface in Search Pipeline (…
navneet1v Jun 29, 2023
36946f5
Handle case where IndexShard is null due to failed creation of index …
gbbafna Jun 29, 2023
0dedea7
Check UTF16 string size before converting to String to avoid OOME (#7…
imRishN Jun 29, 2023
1fc775e
Enable Point based optimization for custom comparators (#8168)
gashutos Jun 29, 2023
cf0213d
[Fix] Replace cached time with system clock in MasterService debug lo…
sandeshkr419 Jun 29, 2023
6cd8122
Fix HDFS fixture by excluding BouncyCastle (#8359)
willyborankin Jun 29, 2023
8dbbe34
Enable Fast Double Parser in Jackson (#7909)
mgodwan Jun 29, 2023
e29dcd0
Update search.aggregation/370_multi_terms.yml after backport (#8358)
reta Jun 29, 2023
8204813
Fix primary balance flaky test (#8366)
kotwanikunal Jun 29, 2023
49490f4
Fix search.aggregation/60_empty.yml test case (fails on BWC runs) (#8…
reta Jun 30, 2023
368f729
Add lower and upper bound support for appropriate variance thresholds…
kotwanikunal Jun 30, 2023
bae8afd
Fix version scipt for higher patch numbers (#8385)
kotwanikunal Jun 30, 2023
cd84c20
Avoid search_after short cutting in case of missing is specified (#8391)
gashutos Jul 2, 2023
4631c58
[Remote Store] Moving stale commit deletion to async flow (#8201)
psychbot Jul 3, 2023
f14ed89
[Remote Store] Add method in BlobContainer to fetch the keys in sorte…
sachinpkale Jul 3, 2023
92d1df2
[Remote Store] Add remote store utils useful to name metadata files (…
sachinpkale Jul 4, 2023
2adb72a
Fix flaky tests in restore flow using snapshot interop (#8422)
sachinpkale Jul 4, 2023
856fd2a
Adds log4j configuration for telemetry-otel plugin (#8393)
Gaganjuneja Jul 4, 2023
6048031
Support extension additional settings with extension REST initializat…
cwperks Jul 4, 2023
99cec3f
Update Apache HttpCore/ HttpClient and Apache HttpCore5 / HttpClient5…
reta Jul 4, 2023
09e3bc9
[Remote translog] Add integration tests for primary term validation (…
ashking94 Jul 5, 2023
f8e9377
Adds mock implementation for TelemetryPlugin (#8357)
Gaganjuneja Jul 5, 2023
612a09d
Bump org.apache.maven:maven-model from 3.9.2 to 3.9.3 (#8403)
dependabot[bot] Jul 5, 2023
e60af04
Bump org.apache.avro:avro from 1.11.1 to 1.11.2 in /plugins/repositor…
dependabot[bot] Jul 5, 2023
673f161
Move span operation to Scope from Tracer (#8411)
suranjay Jul 5, 2023
2723bbe
Bump io.projectreactor.netty:reactor-netty from 1.1.7 to 1.1.8 in /pl…
dependabot[bot] Jul 5, 2023
49bfd2b
Fix flaky test. (#8441)
Rishikesh1159 Jul 5, 2023
22a1e4e
Support transport action names when registering NamedRoutes (#7957)
DarshitChanpura Jul 5, 2023
b326c06
Changing version check to 2.9 (#8416)
mingshl Jul 5, 2023
b55e4df
Unmute remote store test testPressureServiceStats (#8458)
kotwanikunal Jul 6, 2023
6d2310e
default compression level change (#8471)
sarthakaggarwal97 Jul 6, 2023
e5dca8b
Add logs to debug NoSuchFileException during segments upload (#8475)
ashking94 Jul 6, 2023
90b40ee
[Remote Segment Store] Make metadata file immutable (#8363)
sachinpkale Jul 6, 2023
dfcc342
Flaky test: Add condition to ensure data correctness on primary promo…
ankitkala Jul 6, 2023
01e20e8
[Segment Replication] Remove Restriction of strictly using only docre…
Rishikesh1159 Jul 6, 2023
238e651
[Search pipelines] Pass "adhocness" flag to processor factories (#8164)
msfroh Jul 6, 2023
a372de7
Update to Gradle 8.2 (#8018)
reta Jul 6, 2023
3d44108
Create concept of persistent ThreadContext headers that are unstashab…
cwperks Jul 6, 2023
7d3f787
Enable Partial Flat Object (#7997)
mingshl Jul 7, 2023
a84b673
Add Changes in Snapshot Clone Flow for remote store interoperability.…
kasundra07 Jul 7, 2023
bed1627
Mute testStaleCommitDeletion test cases (#8516)
sachinpkale Jul 7, 2023
43f5092
Compression Levels Settings for zstd and zstd_no_dict (#8312)
sarthakaggarwal97 Jul 7, 2023
d88e903
[Remote Store] Update Translog Metadata file name (#8350)
gbbafna Jul 7, 2023
ba00c42
Bump com.google.guava:guava from 32.0.1-jre to 32.1.1-jre in /distrib…
owaiskazi19 Jul 7, 2023
69e1657
Bump com.google.guava:guava from 32.0.1-jre to 32.1.1-jre in /distrib…
dependabot[bot] Jul 7, 2023
b45c732
Bump com.google.guava:guava from 32.0.1-jre to 32.1.1-jre in /distrib…
dependabot[bot] Jul 7, 2023
ceffdeb
Add early termination support for concurrent segment search (#8306)
jed326 Jul 7, 2023
a69c485
Change extension integration testing to reflect new initialization se…
ryanbogan Jul 7, 2023
0f6ab74
[Remote Store] Mute testRemoteRefreshRetryOnFailure test case (#8542)
ashking94 Jul 8, 2023
6af29ff
[Segment Replication] Prevent store clean up post reader close and re…
dreamer-89 Jul 8, 2023
5ea6547
Fix flakyness in RemoteStoreRefreshListenerIT (#8547)
ashking94 Jul 9, 2023
b4d3542
Fix flakyness in RemoteStoreRefreshListenerTests (#8550)
ashking94 Jul 10, 2023
c1f7349
[Optimization] Cluster State Update Optimization (#7853)
sandeshkr419 Jul 10, 2023
54ea5dd
[Remote Segment Store] Fix flaky RemoteStoreIT.testStaleCommitDeletio…
sachinpkale Jul 10, 2023
7260c78
Extend existing IndexRecoveryIT for remote indexes (#8505)
ashking94 Jul 10, 2023
5daa21f
Bump com.google.guava:guava from 30.1.1-jre to 32.1.1-jre (#8583)
reta Jul 10, 2023
f26e098
Add safeguard limits for file cache during node level allocation (#8208)
kotwanikunal Jul 10, 2023
9ca2fee
Bump com.netflix.nebula:gradle-info-plugin from 12.1.4 to 12.1.5 (#8568)
dependabot[bot] Jul 10, 2023
f7d536e
Manually update google cloud core from 2.17.0 to 2.21.0 (#8586)
stephen-crawford Jul 10, 2023
32d02f9
Bump com.azure:azure-storage-blob from 12.22.2 to 12.22.3 in /plugins…
dependabot[bot] Jul 10, 2023
14e866c
replace with getField (#7855)
marevol Jul 10, 2023
a0b42e2
Update Gradle to 8.2.1 (#8580)
reta Jul 10, 2023
7184bc7
Bump com.google.jimfs:jimfs from 1.2 to 1.3.0 in /distribution/tools/…
dependabot[bot] Jul 10, 2023
4b142b4
Bump schema validator from from 1.0.85 to 1.0.86 (#8573)
stephen-crawford Jul 10, 2023
0d9a026
Move changelog entry (#8599)
stephen-crawford Jul 10, 2023
f458a65
add jdk.incubator.vector module support for JDK 20+ (#8601)
nknize Jul 10, 2023
95ea499
Bump com.google.jimfs:jimfs in /distribution/tools/upgrade-cli (#8571)
dependabot[bot] Jul 10, 2023
547a338
Fix painless casting bug causing opensearch to crash (#8315)
shiv0408 Jul 10, 2023
ffdf8b4
Disabled translog fsync in remote store path (#8288)
vikasvb90 Jul 11, 2023
112c8a2
[Snapshot Interop] Add Changes in Snapshot Status Flow for remote sto…
kasundra07 Jul 11, 2023
687e05d
Manually bump net.minidev:json-smart from 2.4.11 to 2.5.0 (#8576)
stephen-crawford Jul 11, 2023
5561832
[Snapshot Interop] Keep API parameters behind remote store experiment…
harishbhakuni Jul 11, 2023
411f4e9
Add Changes in Snapshot Delete Flow for remote store interoperability…
kasundra07 Jul 11, 2023
5829c3e
Add shard id to remote store logs (#8574)
linuxpi Jul 11, 2023
ced2371
Add wrapped tracer implementation (#8565)
suranjay Jul 11, 2023
6c7c932
[Remote Store] Add multipart upload integration for translog and segm…
raghuvanshraj Jul 11, 2023
dc3eebd
[Mute] flaky RemoteStoreRefreshListenerTests (#8626)
Rishikesh1159 Jul 11, 2023
aaff823
Add logs for remote store metadata intermittent read failures (#8618)
linuxpi Jul 11, 2023
94a68f8
Fix bug where ReplicationListeners would not complete on cancellation…
mch2 Jul 11, 2023
8729f3d
Bump org.apache.logging.log4j:log4j-core from 2.17.1 to 2.20.0 (#8307)
Xtansia Jul 11, 2023
f036f9d
[Segment Replication] Add logic back to update tracking replication c…
dreamer-89 Jul 11, 2023
d8bf752
[Search pipelines] Add Global Ignore_failure options for Processors (…
mingshl Jul 11, 2023
a2d6671
Flip SEARCH_PIPELINE feature flag for search pipeline GA (#8613)
noCharger Jul 11, 2023
2b668d7
[Refactor] HPPC IntArrayList and ObjectArrayList to j.u.List (#8602)
nknize Jul 11, 2023
fae1780
Bump net.minidev:json-smart from 2.4.11 to 2.5.0 in /plugins/reposito…
dependabot[bot] Jul 11, 2023
e6a2ceb
Manually update com.google.jimfs:jimfs from 1.2 to 1.3.0 (#8585)
stephen-crawford Jul 11, 2023
18fe8f4
Start replication checkpointTimers on primary before segments upload …
ankitkala Jul 11, 2023
b5dbd2d
Fix remote segments sync retry regression introduced in PR #7119 (#8632)
ashking94 Jul 12, 2023
2362844
Telemetry exporter config (#8624)
Gaganjuneja Jul 12, 2023
3728768
[Remote Store] Add S3 async upload utilities and models (#7217)
raghuvanshraj Jul 12, 2023
bf87d32
[Refactor] StreamIO from common to core.common namespace in core lib …
nknize Jul 12, 2023
01367d6
Add 2.10.0 to bwc versions. (#8670)
andrross Jul 12, 2023
0433a67
[Remote Store] Integrate S3 async upload with S3BlobContainer (#7218)
raghuvanshraj Jul 13, 2023
b8beb4a
Added the addition of the server version and distribution as a respon…
Sam-ScottLogic Jul 13, 2023
6cf52cc
CardinalityIT/NestedIT test failures with concurrent search enabled a…
sohami Jul 13, 2023
9076333
Create 2.9 release notes and clear out changelog (#8682)
andrross Jul 13, 2023
e70da4b
Remove unused extension directory (#8674)
owaiskazi19 Jul 13, 2023
865f339
Remove CHANGELOG entries that have been backported (#8686)
andrross Jul 13, 2023
917fac3
Changing search shard failure logging to trace from debug (#8470)
sgup432 Jul 14, 2023
4d46b08
Handle replication cases where the remote store metadata file is not …
ankitkala Jul 14, 2023
077e6b6
Fix RemoteStoreReplicationSourceTests.testGetCheckpointMetadataEmpty.…
mch2 Jul 14, 2023
18b0ec7
Segment Replication - Allow search idle with no replicas (#8173)
mch2 Jul 14, 2023
58b322d
update grpc (#8726)
stephen-crawford Jul 17, 2023
32f400a
ClusterShardLimitIT.testCreateIndexWithMaxClusterShardSetting (#8708)
RS146BIJAY Jul 17, 2023
8969e2d
Fix flaky test testDropPrimaryDuringReplication. (#8715)
mch2 Jul 17, 2023
5140c42
Manually update commons-codec from 1.15 to 1.16.0 (#8725)
stephen-crawford Jul 17, 2023
32fb067
Manually update Netflix Gradle info from 12.1.5 to 12.1.6 (#8724)
stephen-crawford Jul 17, 2023
405a44d
[Refactor] Remaining HPPC to java.util collections (#8730)
nknize Jul 18, 2023
e0d8151
Do not trigger storeDirectory.sync in segment download flow from remo…
sachinpkale Jul 18, 2023
46f72c8
Use CloseableRetryableRefreshListener to drain ongoing after refresh …
ashking94 Jul 18, 2023
93dc412
[Remote Segment Store] Use files from segmentInfosSnapshot in upload …
sachinpkale Jul 18, 2023
421d198
[Segment Replication][Remote Store] Remove commits when remote store …
Poojita-Raj Jul 18, 2023
eabe73c
Remove SEARCH_PIPELINE feature flag (#8513)
noCharger Jul 18, 2023
1232dc8
[Remote Store] Change remote store integ tests to use remote store fo…
sachinpkale Jul 19, 2023
d03f24a
Make Tracer injectable (#8696)
suranjay Jul 19, 2023
cdbd14d
Add integration tests for remote store restore flow (#8484)
Jul 20, 2023
b23dcca
Change InternalSignificantTerms to only sum shard level counts in fin…
jed326 Jul 20, 2023
99cdff1
Remove remote translog settings to make all remote indices translog e…
linuxpi Jul 21, 2023
df50665
Mute test - SegmentReplicationIndexShardTests#testNRTReplicaWithRemot…
linuxpi Jul 21, 2023
a966931
[Remote Segment Store] Add Lucene major version to UploadedSegmentMet…
Jul 21, 2023
d331b1b
fixtures: fix read-only krb5kdc composeBuild failure (#8799)
r1walz Jul 21, 2023
96663cf
Exclude 'benchmarks' from codecov report (#8805)
ketanv3 Jul 21, 2023
3888d9f
Remove searchSegmentOrderReversed from IndexSettings (#8808)
andrross Jul 21, 2023
cc11f4c
Adding @sohami to OpenSearch maintainers (#8828)
Bukhtawar Jul 23, 2023
d50757a
Fix flaky test - org.opensearch.repositories.blobstore.BlobStoreRepos…
linuxpi Jul 24, 2023
6cd229f
Bump com.netflix.nebula.ospackage-base from 11.3.0 to 11.4.0 in /dist…
dependabot[bot] Jul 24, 2023
0bb6638
Manually Bump org.gradle.test-retry from 1.5.3 to 1.5.4 (#8842)
stephen-crawford Jul 24, 2023
558a81d
Bump com.google.http-client:google-http-client-gson from 1.43.2 to 1.…
dependabot[bot] Jul 24, 2023
fdf6479
Manually bump org.apache.zookeeper:zookeeper from 3.8.1 to 3.8.2 (#8844)
stephen-crawford Jul 24, 2023
1b1d440
[Refactor] MediaTypeParser to MediaTypeParserRegistry (#8636)
nknize Jul 24, 2023
7e45204
Retry only specified tests (#8825)
andrross Jul 24, 2023
cb757ad
Fix versions for 2.x on main (#8846)
kotwanikunal Jul 24, 2023
919aa7c
Fix flaky test SegmentReplicationRemoteStoreIT.testPressureServiceSta…
mch2 Jul 24, 2023
320eefa
OpenJDK Update (July 2023 Patch releases) (#8868)
reta Jul 25, 2023
2960c66
Update Apache Lucene to 9.8.0-snapshot-4373c3b (#8668)
reta Jul 25, 2023
3e91183
Create separate SourceLookup instance per segment slice in Significan…
jed326 Jul 25, 2023
e9a6bbe
Bump version of Hadoop dependencies to 3.3.5 (#6995)
Jul 25, 2023
defdec2
Extend publishXToMavenLocal explicit dependencies to all repo tasks (…
ccook-ibm Jul 25, 2023
efebd02
Skip testPitCreatedOnReplica IT with remote store (#8877)
dreamer-89 Jul 26, 2023
ac8f553
Fix testReplicaHasDiffFilesThanPrimary. (#8863)
mch2 Jul 26, 2023
5d2321e
Replace the deprecated IndexReader APIs with new storedFields() & ter…
luyuncheng Jul 26, 2023
72e385e
Remove unnecessary refresh listeners from NRTReplicationReaderManager…
mch2 Jul 26, 2023
0019a14
Updated Version.java path from server to libs in version.yml (#8883)
vibrantvarun Jul 26, 2023
683b895
[Remote Store] Add support to restore only unassigned shards of an in…
sachinpkale Jul 27, 2023
64b3b39
Add 2.9.1 to BWC and known versions (#8923) (#8929)
reta Jul 27, 2023
a0e7f21
Fix flakiness in MasterServiceTests.testThrottlingForMultipleTaskType…
andrross Jul 27, 2023
8b317d9
Fix SegmentReplicationIT.testReplicaHasDiffFilesThanPrimary for node-…
mch2 Jul 27, 2023
3fb0b3f
Configure test-retry plugin filter properly (#8933)
andrross Jul 27, 2023
ba6ccdb
[Refactor] MediaTypeParserRegistry to MediaTypeRegistry (#8940)
nknize Jul 27, 2023
671c7cc
[Segment Replication] Use deterministic mechanism to have concurrent …
dreamer-89 Jul 28, 2023
2576fec
Register MediaTypes through SPI (#8938)
nknize Jul 28, 2023
594627f
Remove testUpdateSegmentsWhileRefreshing flaky test failure (#8943)
dreamer-89 Jul 28, 2023
bfe5462
amending tests to include all codecs (#8907)
sarthakaggarwal97 Jul 28, 2023
91b0be2
Add metadata prefix to Remote Translog Metadata file (#8914)
gbbafna Jul 28, 2023
f7ece2d
[BUG] CompletionSuggestSearchIT.testSkipDuplicates is flaky (#8963)
reta Jul 28, 2023
dd78796
Added empty build.gradle files for arm64 and s390x because the gradle…
evankielley Jul 28, 2023
d492e57
Revert "amending tests to include all codecs (#8907)" (#8968)
reta Jul 28, 2023
d19ba04
[distribution/archives] [Linux] [x64] Provide the variant of the dist…
reta Jul 28, 2023
249693b
Replace deprecated Query#rewrite(IndexReader with rewrite(IndexSearch…
nknize Jul 28, 2023
ac210bf
[Refactor] XContentFactory contentType introspection to MediaTypePars…
nknize Jul 28, 2023
4c4d2e8
amending tests to include all codecs (#8907)
sarthakaggarwal97 Jul 28, 2023
77c4bcf
Revert "amending tests to include all codecs (#8907)" (#8968)
reta Jul 28, 2023
08ccde4
Unmute test SegmentReplicationIndexShardTests#testNRTReplicaWithRemot…
Poojita-Raj Jul 28, 2023
15d08fa
amending tests to include all codecs (#8907)
sarthakaggarwal97 Jul 28, 2023
7a73a7d
Revert "amending tests to include all codecs (#8907)" (#8968)
reta Jul 28, 2023
fd1572d
Merge branch 'main' of github.com:baba-devv/OpenSearch into Mani-Exce…
baba-devv Jul 29, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,6 @@ public ConcurrentSnapshotExecutionException(StreamInput in) throws IOException {

@Override
public RestStatus status() {
return RestStatus.SERVICE_UNAVAILABLE;
return RestStatus.TOO_MANY_REQUESTS;
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks can you please also add a test?

Copy link
Member

@shwetathareja shwetathareja May 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am wondering shouldn't this be 409 (Conflict) instead of 429?

Copy link
Member

@dblock dblock May 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the underlying error? Is it concurrent snapshots being taken whereas this isn't supported? In that case it should definitely not be a 429, that implies the server is unable to handle traffic, not a predictable conflicting behavior - 409 seems more correct in that case.

"Thrown when a user tries to multiple conflicting snapshot/restore operations at the same time." -> 409

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only question I had was that since it is concurrent & not specifically conflicting, should I change that to 409 ?
@dblock @shwetathareja

Copy link
Member

@shwetathareja shwetathareja May 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@baba-devv : Since it is concurrent, it is resulting in conflict and hence rejected by server.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@baba-devv yes in my opinion it should be 409

}