Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup unused code in org.opensearch.common #5288

Merged
merged 1 commit into from
Nov 17, 2022
Merged

Cleanup unused code in org.opensearch.common #5288

merged 1 commit into from
Nov 17, 2022

Conversation

adnapibar
Copy link
Contributor

Description

These are unused internal code in the org.opensearch.common package.

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Rabi Panda adnapibar@gmail.com

@adnapibar adnapibar requested review from a team and reta as code owners November 17, 2022 01:31
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: null ❌
  • FAILURES:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: null ❌
  • FAILURES:

@dblock
Copy link
Member

dblock commented Nov 17, 2022

Rebase, these gradle failures should clean themselves up.

Signed-off-by: Rabi Panda <adnapibar@gmail.com>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: FAILURE ❌
  • FAILURES:

@dblock
Copy link
Member

dblock commented Nov 17, 2022

Execution failed for task ':distribution:bwc:staged:buildBwcLinuxTar'.
> Building 2.4.0 didn't generate expected file /var/jenkins/workspace/gradle-check/search/distribution/bwc/staged/build/bwc/checkout-2.4/distribution/archives/linux-tar/build/distributions/opensearch-min-2.4.0-SNAPSHOT-linux-x64.tar.gz

I think this is transient while we increment versions, but I could be wrong.

@reta
Copy link
Collaborator

reta commented Nov 17, 2022

Execution failed for task ':distribution:bwc:staged:buildBwcLinuxTar'.
> Building 2.4.0 didn't generate expected file /var/jenkins/workspace/gradle-check/search/distribution/bwc/staged/build/bwc/checkout-2.4/distribution/archives/linux-tar/build/distributions/opensearch-min-2.4.0-SNAPSHOT-linux-x64.tar.gz

I think this is transient while we increment versions, but I could be wrong.

I believe we need these two guys: #5269 and #5270

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@codecov-commenter
Copy link

Codecov Report

Merging #5288 (d6ccba7) into main (059b614) will decrease coverage by 0.10%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #5288      +/-   ##
============================================
- Coverage     71.02%   70.92%   -0.11%     
+ Complexity    58237    58108     -129     
============================================
  Files          4705     4704       -1     
  Lines        277480   277459      -21     
  Branches      40181    40178       -3     
============================================
- Hits         197082   196789     -293     
- Misses        64288    64583     +295     
+ Partials      16110    16087      -23     
Impacted Files Coverage Δ
.../main/java/org/opensearch/OpenSearchException.java 93.58% <ø> (+1.24%) ⬆️
...r/src/main/java/org/opensearch/common/Classes.java 33.33% <ø> (ø)
...r/src/main/java/org/opensearch/common/Numbers.java 75.00% <ø> (ø)
...rg/opensearch/common/RandomBasedUUIDGenerator.java 52.63% <ø> (ø)
...r/src/main/java/org/opensearch/common/Strings.java 60.62% <ø> (+2.75%) ⬆️
...ver/src/main/java/org/opensearch/common/UUIDs.java 66.66% <ø> (ø)
...opensearch/index/mapper/MockFieldFilterPlugin.java 0.00% <0.00%> (-100.00%) ⬇️
...nsearch/rest/action/cat/RestCatRecoveryAction.java 43.61% <0.00%> (-42.56%) ⬇️
.../admin/cluster/reroute/ClusterRerouteResponse.java 60.00% <0.00%> (-40.00%) ⬇️
...luster/routing/allocation/RoutingExplanations.java 62.06% <0.00%> (-37.94%) ⬇️
... and 457 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants