-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for failing checkExtraction, checkLicense and checkNotice tasks for windows gradle check #4941
Fix for failing checkExtraction, checkLicense and checkNotice tasks for windows gradle check #4941
Conversation
Gradle Check (Jenkins) Run Completed with:
|
5035ff2
to
207a2df
Compare
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Think you need a rebase after - #4922 was merged. |
207a2df
to
733caec
Compare
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: Poojita Raj <poojiraj@amazon.com>
Signed-off-by: Poojita Raj <poojiraj@amazon.com>
733caec
to
0d80067
Compare
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## main #4941 +/- ##
============================================
+ Coverage 70.81% 70.84% +0.03%
- Complexity 57907 57954 +47
============================================
Files 4688 4688
Lines 276893 276895 +2
Branches 40298 40298
============================================
+ Hits 196083 196178 +95
+ Misses 64548 64493 -55
+ Partials 16262 16224 -38
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-4941-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 6e90080a330278bec3c109825240dd8c327e961c
# Push it to GitHub
git push --set-upstream origin backport/backport-4941-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x Then, create a pull request where the |
@joshpalis Manual backport to 2.x? |
…or windows gradle check (opensearch-project#4941) * Fix for failing checkExtraction and checkLicense tasks Signed-off-by: Poojita Raj <poojiraj@amazon.com> * changelog added Signed-off-by: Poojita Raj <poojiraj@amazon.com> Signed-off-by: Poojita Raj <poojiraj@amazon.com>
…or windows gradle check (#4941) (#4961) * Fix for failing checkExtraction and checkLicense tasks Signed-off-by: Poojita Raj <poojiraj@amazon.com> * changelog added Signed-off-by: Poojita Raj <poojiraj@amazon.com> Signed-off-by: Poojita Raj <poojiraj@amazon.com> Signed-off-by: Poojita Raj <poojiraj@amazon.com>
…or windows gradle check (opensearch-project#4941) * Fix for failing checkExtraction and checkLicense tasks Signed-off-by: Poojita Raj <poojiraj@amazon.com> * changelog added Signed-off-by: Poojita Raj <poojiraj@amazon.com> Signed-off-by: Poojita Raj <poojiraj@amazon.com>
…or windows gradle check (opensearch-project#4941) * Fix for failing checkExtraction and checkLicense tasks Signed-off-by: Poojita Raj <poojiraj@amazon.com> * changelog added Signed-off-by: Poojita Raj <poojiraj@amazon.com> Signed-off-by: Poojita Raj <poojiraj@amazon.com>
…or windows gradle check (#4941) (#5119) * Fix for failing checkExtraction and checkLicense tasks Signed-off-by: Poojita Raj <poojiraj@amazon.com> * changelog added Signed-off-by: Poojita Raj <poojiraj@amazon.com> Signed-off-by: Poojita Raj <poojiraj@amazon.com> Signed-off-by: Poojita Raj <poojiraj@amazon.com>
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-1.x 1.x
# Navigate to the new working tree
pushd ../.worktrees/backport-1.x
# Create a new branch
git switch --create backport/backport-4941-to-1.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 6e90080a330278bec3c109825240dd8c327e961c
# Push it to GitHub
git push --set-upstream origin backport/backport-4941-to-1.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-1.x Then, create a pull request where the |
…kNotice tasks for windows gradle check (opensearch-project#4941) Signed-off-by: Poojita Raj <poojiraj@amazon.com>
Signed-off-by: Poojita Raj poojiraj@amazon.com
Description
This is a fix for failing windows gradle check tasks as part of providing windows CI support. This focuses on 3 groups of failing tasks - checkExtraction, checkLicense and checkNotice tasks.
Issues Resolved
Resolves #4925, #4939, #4940
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.