Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for failing checkExtraction, checkLicense and checkNotice tasks for windows gradle check #4941

Merged

Conversation

Poojita-Raj
Copy link
Contributor

Signed-off-by: Poojita Raj poojiraj@amazon.com

Description

This is a fix for failing windows gradle check tasks as part of providing windows CI support. This focuses on 3 groups of failing tasks - checkExtraction, checkLicense and checkNotice tasks.

Issues Resolved

Resolves #4925, #4939, #4940

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@Poojita-Raj Poojita-Raj requested review from a team and reta as code owners October 26, 2022 16:52
@Poojita-Raj Poojita-Raj changed the title Fix for failing checkExtraction, checkLicense and checkNotice tasks Fix for failing checkExtraction, checkLicense and checkNotice tasks for windows gradle check Oct 26, 2022
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@Poojita-Raj Poojita-Raj force-pushed the windowsExtractionLicenseChecks branch from 5035ff2 to 207a2df Compare October 26, 2022 17:27
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@mch2
Copy link
Member

mch2 commented Oct 26, 2022

Think you need a rebase after - #4922 was merged.

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

Signed-off-by: Poojita Raj <poojiraj@amazon.com>
Signed-off-by: Poojita Raj <poojiraj@amazon.com>
@Poojita-Raj Poojita-Raj force-pushed the windowsExtractionLicenseChecks branch from 733caec to 0d80067 Compare October 27, 2022 18:10
@vibrantvarun vibrantvarun self-requested a review October 27, 2022 18:18
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@codecov-commenter
Copy link

Codecov Report

Merging #4941 (0d80067) into main (fe0b917) will increase coverage by 0.03%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##               main    #4941      +/-   ##
============================================
+ Coverage     70.81%   70.84%   +0.03%     
- Complexity    57907    57954      +47     
============================================
  Files          4688     4688              
  Lines        276893   276895       +2     
  Branches      40298    40298              
============================================
+ Hits         196083   196178      +95     
+ Misses        64548    64493      -55     
+ Partials      16262    16224      -38     
Impacted Files Coverage Δ
...ternal/InternalDistributionArchiveCheckPlugin.java 0.00% <0.00%> (ø)
...ternal/InternalDistributionArchiveSetupPlugin.java 0.00% <ø> (ø)
...java/org/opensearch/client/indices/DataStream.java 0.00% <0.00%> (-76.09%) ⬇️
.../opensearch/client/indices/CloseIndexResponse.java 17.50% <0.00%> (-65.00%) ⬇️
...a/org/opensearch/client/cluster/SniffModeInfo.java 0.00% <0.00%> (-58.83%) ⬇️
...opensearch/persistent/PersistentTasksExecutor.java 22.22% <0.00%> (-44.45%) ⬇️
...cluster/coordination/PublishClusterStateStats.java 33.33% <0.00%> (-37.51%) ⬇️
...ion/admin/cluster/node/info/PluginsAndModules.java 53.12% <0.00%> (-34.38%) ⬇️
...opensearch/index/reindex/BulkByScrollResponse.java 48.38% <0.00%> (-29.04%) ⬇️
...opensearch/snapshots/SnapshotMissingException.java 28.57% <0.00%> (-28.58%) ⬇️
... and 500 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@joshpalis joshpalis self-requested a review October 27, 2022 18:47
@dblock dblock merged commit 6e90080 into opensearch-project:main Oct 27, 2022
@dblock dblock added the backport 2.x Backport to 2.x branch label Oct 27, 2022
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-4941-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 6e90080a330278bec3c109825240dd8c327e961c
# Push it to GitHub
git push --set-upstream origin backport/backport-4941-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-4941-to-2.x.

@dblock
Copy link
Member

dblock commented Oct 27, 2022

@joshpalis Manual backport to 2.x?

Poojita-Raj added a commit to Poojita-Raj/OpenSearch that referenced this pull request Oct 27, 2022
…or windows gradle check (opensearch-project#4941)

* Fix for failing checkExtraction and checkLicense tasks

Signed-off-by: Poojita Raj <poojiraj@amazon.com>

* changelog added

Signed-off-by: Poojita Raj <poojiraj@amazon.com>

Signed-off-by: Poojita Raj <poojiraj@amazon.com>
saratvemulapalli pushed a commit that referenced this pull request Oct 28, 2022
…or windows gradle check (#4941) (#4961)

* Fix for failing checkExtraction and checkLicense tasks

Signed-off-by: Poojita Raj <poojiraj@amazon.com>

* changelog added

Signed-off-by: Poojita Raj <poojiraj@amazon.com>

Signed-off-by: Poojita Raj <poojiraj@amazon.com>

Signed-off-by: Poojita Raj <poojiraj@amazon.com>
@Poojita-Raj Poojita-Raj self-assigned this Oct 28, 2022
Poojita-Raj added a commit to Poojita-Raj/OpenSearch that referenced this pull request Nov 8, 2022
…or windows gradle check (opensearch-project#4941)

* Fix for failing checkExtraction and checkLicense tasks

Signed-off-by: Poojita Raj <poojiraj@amazon.com>

* changelog added

Signed-off-by: Poojita Raj <poojiraj@amazon.com>

Signed-off-by: Poojita Raj <poojiraj@amazon.com>
Poojita-Raj added a commit to Poojita-Raj/OpenSearch that referenced this pull request Nov 8, 2022
…or windows gradle check (opensearch-project#4941)

* Fix for failing checkExtraction and checkLicense tasks

Signed-off-by: Poojita Raj <poojiraj@amazon.com>

* changelog added

Signed-off-by: Poojita Raj <poojiraj@amazon.com>

Signed-off-by: Poojita Raj <poojiraj@amazon.com>
dblock pushed a commit that referenced this pull request Nov 8, 2022
…or windows gradle check (#4941) (#5119)

* Fix for failing checkExtraction and checkLicense tasks

Signed-off-by: Poojita Raj <poojiraj@amazon.com>

* changelog added

Signed-off-by: Poojita Raj <poojiraj@amazon.com>

Signed-off-by: Poojita Raj <poojiraj@amazon.com>

Signed-off-by: Poojita Raj <poojiraj@amazon.com>
@opensearch-trigger-bot
Copy link
Contributor

The backport to 1.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-1.x 1.x
# Navigate to the new working tree
pushd ../.worktrees/backport-1.x
# Create a new branch
git switch --create backport/backport-4941-to-1.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 6e90080a330278bec3c109825240dd8c327e961c
# Push it to GitHub
git push --set-upstream origin backport/backport-4941-to-1.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-1.x

Then, create a pull request where the base branch is 1.x and the compare/head branch is backport/backport-4941-to-1.x.

Poojita-Raj added a commit to Poojita-Raj/OpenSearch that referenced this pull request Nov 17, 2022
…kNotice tasks for windows gradle check (opensearch-project#4941)

Signed-off-by: Poojita Raj <poojiraj@amazon.com>
dblock pushed a commit that referenced this pull request Nov 17, 2022
…kNotice tasks for windows gradle check (#4941) (#5295)

Signed-off-by: Poojita Raj <poojiraj@amazon.com>

Signed-off-by: Poojita Raj <poojiraj@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 1.x backport 2.x Backport to 2.x branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Windows gradle check failure - checkExtraction tasks failing
6 participants