Renamed to "flaky" test.

[dblock]

Signed-off-by: Daniel (dB.) Doubrovkine dblock@amazon.com

Description

After a bit of googling, I believe the correct definition is "flaky". Will rename labels as well.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/5527/
• CommitID: 31a0ff5
  Please examine the workflow log, locate, and copy-paste the failure below.
  Flakey test?
  Iterate to green.

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/5528/
• CommitID: d593b12
  Please examine the workflow log, locate, and copy-paste the failure below.
  Flakey test?
  Iterate to green.

[andrross]

Ha! I did the same googling and came to the conclusion that "flakey" was an accepted, albeit less common spelling. I wanted to comment on your last PR but decided I wouldn't be an annoying pedant. The numbers don't lie though...

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: UNSTABLE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/5530/
• CommitID: 1927e63
  Please examine the workflow log, locate, and copy-paste the failure below.
  Flakey test?
  Iterate to green.

[dblock]

REPRODUCE WITH: ./gradlew ':server:internalClusterTest' --tests "org.opensearch.cluster.coordination.AwarenessAttributeDecommissionIT.testDecommissionStatusUpdatePublishedToAllNodes" -Dtests.seed=89E5053F9731D0F1 -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=pt -Dtests.timezone=America/Recife -Druntime.java=17

org.opensearch.cluster.coordination.AwarenessAttributeDecommissionIT > testDecommissionStatusUpdatePublishedToAllNodes FAILED
    java.lang.AssertionError: expected:<SUCCESSFUL> but was:<DRAINING>
        at __randomizedtesting.SeedInfo.seed([89E5053F9731D0F1:5708DEFD71320B65]:0)
        at org.junit.Assert.fail(Assert.java:89)
        at org.junit.Assert.failNotEquals(Assert.java:835)
        at org.junit.Assert.assertEquals(Assert.java:120)
        at org.junit.Assert.assertEquals(Assert.java:146)
        at org.opensearch.cluster.coordination.AwarenessAttributeDecommissionIT.testDecommissionStatusUpdatePublishedToAllNodes(AwarenessAttributeDecommissionIT.java:144)

#4824

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: UNSTABLE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/5556/
• CommitID: 1927e63
  Please examine the workflow log, locate, and copy-paste the failure below.
  Flakey test?
  Iterate to green.

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/5615/
• CommitID: 929b012
  Please examine the workflow log, locate, and copy-paste the failure below.
  Flakey test?
  Iterate to green.

[dreamer-89]

Thanks @dblock for the change.

How are you planning to change existing flakey label. I did not find option of renaming existing labels.
https://docs.github.com/en/issues/using-labels-and-milestones-to-track-work/managing-labels

[dblock]

@dreamer-89 you can edit labels

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: SUCCESS ✅
• URL: https://build.ci.opensearch.org/job/gradle-check/5669/
• CommitID: ac2268c

[opensearch-trigger-bot]

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-4912-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 d96da5026468eb3dabbd12d4763d40a52b980440
# Push it to GitHub
git push --set-upstream origin backport/backport-4912-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-4912-to-2.x.