Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature/extensions] Adding extensibility support for extension point getNamedXContents #4207

Closed
wants to merge 6 commits into from

Conversation

joshpalis
Copy link
Member

Description

Adds support for registering named xcontent entries from extensions and transporting parse requests to extensions to generate XContent Parsers

Issues Resolved

#3379

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Joshua Palis <jpalis@amazon.com>
…ontentregistry request/response

Signed-off-by: Joshua Palis <jpalis@amazon.com>
Signed-off-by: Joshua Palis <jpalis@amazon.com>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@codecov-commenter
Copy link

Codecov Report

Merging #4207 (05b1ec9) into feature/extensions (ff2846a) will decrease coverage by 0.06%.
The diff coverage is 51.23%.

@@                   Coverage Diff                    @@
##             feature/extensions    #4207      +/-   ##
========================================================
- Coverage                 70.68%   70.61%   -0.07%     
+ Complexity                57173    57095      -78     
========================================================
  Files                      4612     4617       +5     
  Lines                    274812   274973     +161     
  Branches                  40227    40246      +19     
========================================================
- Hits                     194245   194183      -62     
- Misses                    64299    64451     +152     
- Partials                  16268    16339      +71     
Impacted Files Coverage Δ
...common/xcontent/NamedXContentRegistryResponse.java 15.15% <15.15%> (ø)
...on/xcontent/NamedXContentRegistryParseRequest.java 17.39% <17.39%> (ø)
...ons/NamedXContentRegistryParseResponseHandler.java 50.00% <50.00%> (ø)
...rch/extensions/ExtensionNamedXContentRegistry.java 61.36% <61.36%> (ø)
...tensions/NamedXContentRegistryResponseHandler.java 77.08% <77.08%> (ø)
.../opensearch/extensions/ExtensionsOrchestrator.java 74.84% <100.00%> (+0.63%) ⬆️
server/src/main/java/org/opensearch/node/Node.java 86.33% <100.00%> (+0.02%) ⬆️
...a/org/opensearch/client/cluster/SniffModeInfo.java 0.00% <0.00%> (-52.95%) ⬇️
.../opensearch/client/indices/CloseIndexResponse.java 42.50% <0.00%> (-48.75%) ⬇️
...cluster/coordination/PendingClusterStateStats.java 20.00% <0.00%> (-48.00%) ⬇️
... and 458 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: Joshua Palis <jpalis@amazon.com>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

Signed-off-by: Joshua Palis <jpalis@amazon.com>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@joshpalis joshpalis closed this by deleting the head repository Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants