[Remote Store] Add support to add nested settings for remote store

[sachinpkale]

Signed-off-by: Sachin Kale kalsac@amazon.com

Description

Current setting index.remote_store removes the flexibility of adding few sub-settings related to remote store for the same index. In the future, we can have requirements like supporting only remote trans-log, separate remote store for given index. With this change, we introduce index.remote_store.enabled, which will allow inclusion of all the remote_store settings under index.remote_store.

Issues Resolved

• [Remote Store] Support nested index level settings for remote store #4059

Check List

• New functionality includes testing.
  • All tests pass
• New functionality has been documented.
  • New functionality has javadoc added
• Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/1155/
• CommitID: 540e4bbb544ebbfefffc38dcf8b323fff973b4c1

[sachinpkale]

Build failed with: > java.lang.OutOfMemoryError: Java heap space, force pushing the changes again.

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/1160/
• CommitID: b95a7ef2153c09d48a8e7fea96b4706a9541562f

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/1234/
• CommitID: ec5da2ef679d57d56cf2de760d2a2458d0176834

[dreamer-89]

@sachinpkale : Looks like a legit failure in last gradle check failure.

REPRODUCE WITH: ./gradlew ':server:test' --tests "org.opensearch.index.IndexSettingsTests.testUpdateRemoteStoreFails" -Dtests.seed=4CDBB95C3D84618E -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=he -Dtests.timezone=America/Antigua -Druntime.java=17

org.opensearch.index.IndexSettingsTests > testUpdateRemoteStoreFails FAILED
    org.junit.ComparisonFailure: expected:<[index setting [index.remote_store], not recognized]> but was:<[final index setting [index.remote_store], not updateable]>
        at __randomizedtesting.SeedInfo.seed([4CDBB95C3D84618E:16581A01075C7ACB]:0)
        at org.junit.Assert.assertEquals(Assert.java:117)
        at org.junit.Assert.assertEquals(Assert.java:146)
        at org.opensearch.index.IndexSettingsTests.testUpdateRemoteStoreFails(IndexSettingsTests.java:793)

[sachinpkale]

@sachinpkale : Looks like a legit failure in last gradle check failure.

REPRODUCE WITH: ./gradlew ':server:test' --tests "org.opensearch.index.IndexSettingsTests.testUpdateRemoteStoreFails" -Dtests.seed=4CDBB95C3D84618E -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=he -Dtests.timezone=America/Antigua -Druntime.java=17

org.opensearch.index.IndexSettingsTests > testUpdateRemoteStoreFails FAILED
    org.junit.ComparisonFailure: expected:<[index setting [index.remote_store], not recognized]> but was:<[final index setting [index.remote_store], not updateable]>
        at __randomizedtesting.SeedInfo.seed([4CDBB95C3D84618E:16581A01075C7ACB]:0)
        at org.junit.Assert.assertEquals(Assert.java:117)
        at org.junit.Assert.assertEquals(Assert.java:146)
        at org.opensearch.index.IndexSettingsTests.testUpdateRemoteStoreFails(IndexSettingsTests.java:793)

Ohh! Let me fix it. Thanks @dreamer-89 !

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/1334/
• CommitID: b9f413cfc5992b6f45591d85677e6bc705a4f02c

[dreamer-89]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/1334/
• CommitID: b9f413c

Jenkins pipeline failure

[Pipeline] End of Pipeline
ERROR: script returned exit code 128
[Checks API] No suitable checks publisher found.
Finished: FAILURE

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: SUCCESS ✅
• URL: https://build.ci.opensearch.org/job/gradle-check/1335/
• CommitID: f95de5c

[codecov-commenter]

Codecov Report

Merging #4060 (f95de5c) into main (66c24ff) will increase coverage by 0.13%.
The diff coverage is 66.66%.

@@             Coverage Diff              @@
##               main    #4060      +/-   ##
============================================
+ Coverage     70.56%   70.70%   +0.13%     
- Complexity    56938    57036      +98     
============================================
  Files          4588     4588              
  Lines        274132   274132              
  Branches      40178    40178              
============================================
+ Hits         193454   193813     +359     
+ Misses        64452    64011     -441     
- Partials      16226    16308      +82     

Impacted Files	Coverage Δ
...pensearch/common/settings/IndexScopedSettings.java	100.00% <ø> (ø)
.../java/org/opensearch/snapshots/RestoreService.java	55.37% <0.00%> (ø)
...org/opensearch/cluster/metadata/IndexMetadata.java	84.36% <100.00%> (+0.50%)	⬆️
.../main/java/org/opensearch/index/IndexSettings.java	86.35% <100.00%> (ø)
.../java/org/opensearch/node/NodeClosedException.java	50.00% <0.00%> (-50.00%)	⬇️
.../index/shard/IndexShardNotRecoveringException.java	0.00% <0.00%> (-50.00%)	⬇️
...search/search/aggregations/pipeline/EwmaModel.java	24.44% <0.00%> (-28.89%)	⬇️
...rc/main/java/org/opensearch/ingest/IngestInfo.java	51.72% <0.00%> (-27.59%)	⬇️
...a/org/opensearch/index/mapper/MapperException.java	75.00% <0.00%> (-25.00%)	⬇️
...ion/admin/cluster/node/info/PluginsAndModules.java	53.12% <0.00%> (-25.00%)	⬇️
... and 488 more

Help us with your feedback. Take ten seconds to tell us how you rate us.