Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Upgrade] Lucene-9.2-snapshot #2924

Merged
merged 5 commits into from
Apr 21, 2022

Conversation

nknize
Copy link
Collaborator

@nknize nknize commented Apr 15, 2022

Upgrades to latest snapshot of pre-released lucene 9.2

@nknize nknize added enhancement Enhancement or improvement to existing feature or request non-issue bugs / unexpected behaviors that end up non issues; audit trail simple changes that aren't issues >upgrade Label used when upgrading library dependencies (e.g., Lucene) v3.0.0 Issues and PRs related to version 3.0.0 labels Apr 15, 2022
@nknize nknize requested a review from a team as a code owner April 15, 2022 20:37
@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure 13f77c6c954aba198ba9839d6c5c44d4f45075b1
Log 4525

Reports 4525

@nknize
Copy link
Collaborator Author

nknize commented Apr 15, 2022

Fixing failures caused by 9.2 scoring optimization change

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure d33deb6bcb56022f45faf8bbbe8cd9ba03249709
Log 4535

Reports 4535

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure 348c8b9ec464e25a89ea2d0d14ba2febb2323b84
Log 4540

Reports 4540

nknize added 5 commits April 15, 2022 19:30
Upgrades to latest snapshot of pre-released lucene 9.2

Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
@nknize nknize force-pushed the upgrade/lucene9.2 branch from b897d00 to bf22fa7 Compare April 16, 2022 00:31
@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success b897d00a7d3a8620f771137f4a58dee62574978f
Log 4545

Reports 4545

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure bf22fa7
Log 4546

Reports 4546

@nknize
Copy link
Collaborator Author

nknize commented Apr 16, 2022

start gradle check

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success bf22fa7
Log 4550

Reports 4550

@saratvemulapalli
Copy link
Member

@nknize trying to understand how this works. How do we choose versions of lucene to run with OpenSearch?

  • For bleeding edge main (3.0) it is always going to be the latest snapshot?
  • For current release (2.x line), do we consume a stable release version?

@nknize
Copy link
Collaborator Author

nknize commented Apr 18, 2022

We use snapshots until the next release is available. This enables us to stay on top of deprecations and removals without having to wait until the release and make a lot of changes.

@nknize
Copy link
Collaborator Author

nknize commented Apr 21, 2022

I'd like to get this merged in main and 2.x so I can start working towards bumping main to Lucene 10 snapshot

@dblock
Copy link
Member

dblock commented Apr 21, 2022

@saratvemulapalli LMK if you have any concerns with merging this to main

@saratvemulapalli saratvemulapalli merged commit 3d49cce into opensearch-project:main Apr 21, 2022
@nknize nknize added the backport 2.x Backport to 2.x branch label Apr 21, 2022
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-2924-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 3d49ccead2fed77a747534c5e50096b5578981b3
# Push it to GitHub
git push --set-upstream origin backport/backport-2924-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-2924-to-2.x.

@dblock
Copy link
Member

dblock commented Apr 22, 2022

Seems like this may have caused #3039 (comment).

nknize added a commit to nknize/OpenSearch that referenced this pull request May 20, 2022
Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
nknize added a commit that referenced this pull request May 20, 2022
Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch enhancement Enhancement or improvement to existing feature or request non-issue bugs / unexpected behaviors that end up non issues; audit trail simple changes that aren't issues >upgrade Label used when upgrading library dependencies (e.g., Lucene) v3.0.0 Issues and PRs related to version 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants