Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] [1.x] [BUG] Serialization bugs can cause node drops (#1885) #1911

Merged
merged 1 commit into from
Jan 14, 2022

Conversation

reta
Copy link
Collaborator

@reta reta commented Jan 14, 2022

Signed-off-by: Andriy Redko andriy.redko@aiven.io

Description

Backport of #1885 to 1.x

Issues Resolved

Closes #624

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

This commit restructures InboundHandler to ensure all data 
is consumed over the wire.

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
@opensearch-ci-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success ae39482
Log 1928

Reports 1928

@nknize nknize added backport PRs or issues specific to backporting features or enhancments backport 1.x v1.3.0 bug Something isn't working labels Jan 14, 2022
@nknize nknize self-requested a review January 14, 2022 20:23
Copy link
Collaborator

@nknize nknize left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. thx!

@nknize nknize merged commit 67cfbb3 into opensearch-project:1.x Jan 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport PRs or issues specific to backporting features or enhancments backport 1.x bug Something isn't working v1.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants