Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update junit to 4.13.2 #1837

Merged
merged 3 commits into from
Jan 4, 2022
Merged

Update junit to 4.13.2 #1837

merged 3 commits into from
Jan 4, 2022

Conversation

lezzago
Copy link
Member

@lezzago lezzago commented Jan 3, 2022 •
edited
Loading

Signed-off-by: Ashish Agrawal ashisagr@amazon.com

Description

Update junit from 4.12 to 4.13.2

Issues Resolved

N/A

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@lezzago
Update junit to 4.13.1
ffdc1b2 
Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>
@lezzago lezzago requested a review from a team as a code owner January 3, 2022 19:00
@opensearch-ci-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure ffdc1b2
Log 1756

Reports 1756

reta
reta reviewed Jan 3, 2022
View reviewed changes
buildSrc/version.properties Outdated
@@ -28,7 +28,7 @@ joda = 2.10.12
bouncycastle=1.70
# test dependencies
randomizedrunner = 2.7.1
junit = 4.12
junit = 4.13.1
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably 4.13.2 would be better :-)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ahh good catch

@lezzago
update junit to 4.13.2
96b0772 
Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>
@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure 96b0772
Log 1757

Reports 1757

@tlfeng
Copy link
Collaborator

tlfeng commented Jan 3, 2022 •
edited
Loading

In test report 1757, it shows the below test failure

> Task :build-tools:integTest

org.opensearch.gradle.BuildPluginIT > testCheckTask FAILED
    org.gradle.testkit.runner.UnexpectedBuildFailure at BuildPluginIT.java:68

27 tests completed, 1 failed

* What went wrong:
Execution failed for task ':dependencyLicenses'.
> Missing SHA for junit-4.13.2.jar. Run "gradle updateSHAs" to create them

Hi @lezzago , please run ./gradlew updateSHAs to update the checksum for the jar file. 😁

@lezzago
Copy link
Member Author

lezzago commented Jan 3, 2022

In test report 1757:

* What went wrong:
Execution failed for task ':dependencyLicenses'.
> Missing SHA for junit-4.13.2.jar. Run "gradle updateSHAs" to create them

Hi @lezzago , please run ./gradlew updateSHAs to update the checksum for the jar file. 😁

Oh thanks, I will do that. Also is this in the developing guide? If not, might be worthwhile to add this in there for others in the future.

@tlfeng
Copy link
Collaborator

tlfeng commented Jan 3, 2022

Oh thanks, I will do that. Also is this in the developing guide? If not, might be worthwhile to add this in there for others in the future.

It's not explicitly told in the developing guide, but it's shown in the test report. 😄 Thanks for your opinion, maybe we'd better find a place to mention it.

@lezzago
update SHA1 file
97abe32 
Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>
@lezzago lezzago mentioned this pull request Jan 4, 2022
Closed
@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure 97abe32
Log 1760

Reports 1760

@tlfeng
Copy link
Collaborator

tlfeng commented Jan 4, 2022 •
edited
Loading

The above test failure is a known issue #1806.
I will re-trigger the check: start gradle check.

@tlfeng tlfeng mentioned this pull request Jan 4, 2022
Closed
@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success 97abe32
Log 1761

Reports 1761

@dblock dblock merged commit 0b2eba5 into opensearch-project:main Jan 4, 2022
@dblock dblock added the pending backport Identifies an issue or PR that still needs to be backported label Jan 4, 2022
@dblock
Copy link
Member

dblock commented Jan 4, 2022

Please backport to 1.x

lezzago added a commit to lezzago/OpenSearch that referenced this pull request Jan 4, 2022
@lezzago
Update junit to 4.13.1 (opensearch-project#1837)
95bf4d6 
* Update junit to 4.13.1

Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>

* update junit to 4.13.2

Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>

* update SHA1 file

Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>
@lezzago lezzago mentioned this pull request Jan 4, 2022
Merged
5 tasks
@lezzago lezzago changed the title Update junit to 4.13.1 Update junit to 4.13.2 Jan 4, 2022
dblock pushed a commit that referenced this pull request Jan 5, 2022
@lezzago
Update junit to 4.13.1 (#1837) (#1842)
7e15a83 
* Update junit to 4.13.1

Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>

* update junit to 4.13.2

Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>

* update SHA1 file

Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reta reta reta left review comments

@dblock dblock dblock approved these changes

Assignees
No one assigned
Labels
backport 1.x pending backport Identifies an issue or PR that still needs to be backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@lezzago @opensearch-ci-bot @tlfeng @dblock @reta @VachaShah