Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] [1.2] RestIntegTestTask fails because of missed log4j-core dependency (#1815) #1819

Merged
merged 1 commit into from
Dec 28, 2021

Conversation

reta
Copy link
Collaborator

@reta reta commented Dec 28, 2021

Signed-off-by: Andriy Redko andriy.redko@aiven.io

Description

Backport of #1815 to 1.2

Using opensearch.yaml-rest-test Gradle plugin outside of the OpenSearch core (fe, in plugins), for example yamlRestTest, fails with the following exception:

> Task :yamlRestTest

org.opensearch.path.to.plugin.RenameClientYamlTestSuiteIT > initializationError FAILED
    java.lang.NoClassDefFoundError: org/apache/logging/log4j/core/Layout

Since the log4j-core is declared as optional, it is not being picked up. Adding it as an explicit dependency does not solve the problem either (see please opensearch-project/opensearch-plugin-template-java#16 for more details) because the task uses dedicated configuration yamlRestTestImplementation and only its dependencies.

Issues Resolved

Closes #1814

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@opensearch-ci-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure 1b061a2e852c0d238f867e9e4577dda20316f3d2
Log 1704

Reports 1704

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure 6c7eab832a875cf2844dd8269ca91ecfd415eed9
Log 1708

Reports 1708

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure 2b3881f9ae26f5810cba63a5e2ee1eda6372aee9
Log 1710

Reports 1710

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success 5f5d839
Log 1711

Reports 1711

@dblock dblock merged commit 97f7842 into opensearch-project:1.2 Dec 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants