Ignore file order in test assertion #1755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
❌ Gradle Check failure bd745b7de1691c3f2eb1225516bfdfbae3ddff39 |
This unit test asserts that a SHA file for a groovy dependency gets created. However, a SHA file for javaparser-core also gets created in the same directory. For some reason, builds were failing on my machine because `Files::list` was returning the javaparser-core file first. I don't believe there are any ordering guarantees with that API, so I relaxed the assertion to not depend on ordering. Signed-off-by: Andrew Ross <andrross@amazon.com>
bd745b7 to
7e0fa7d
Compare
dreamer-89
approved these changes
Dec 20, 2021
adnapibar
approved these changes
Dec 20, 2021
andrross
added a commit
to andrross/OpenSearch
that referenced
this pull request
Dec 21, 2021
This unit test asserts that a SHA file for a groovy dependency gets created. However, a SHA file for javaparser-core also gets created in the same directory. For some reason, builds were failing on my machine because `Files::list` was returning the javaparser-core file first. I don't believe there are any ordering guarantees with that API, so I relaxed the assertion to not depend on ordering. Signed-off-by: Andrew Ross <andrross@amazon.com>
andrross
added a commit
that referenced
this pull request
Dec 21, 2021
This unit test asserts that a SHA file for a groovy dependency gets created. However, a SHA file for javaparser-core also gets created in the same directory. For some reason, builds were failing on my machine because `Files::list` was returning the javaparser-core file first. I don't believe there are any ordering guarantees with that API, so I relaxed the assertion to not depend on ordering. Signed-off-by: Andrew Ross <andrross@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This unit test asserts that a SHA file for a groovy dependency gets
created. However, a SHA file for javaparser-core also gets created in
the same directory. For some reason, builds were failing on my machine
because
Files::listwas returning the javaparser-core file first. Idon't believe there are any ordering guarantees with that API, so I
relaxed the assertion to not depend on ordering.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.