Add filter function for AbstractQueryBuilder, BoolQueryBuilder, ConstantScoreQueryBuilder #17409
Conversation
|
❌ Gradle check result for 6704b99: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for 7577d38: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
bb06326 to
4b29713
Compare
|
❌ Gradle check result for 4b29713: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for a2983d4: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Still an open conversation on whether an enum is required.
|
❌ Gradle check result for a2983d4: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
…antScoreQueryBuilder. (opensearch-project#17409) * The filter function will combine a filter with the query builder. If the query builder itself has a filter we will combine the filter and return the query builder itself. If no we will use a bool query builder to combine the query builder and the filter and then return the bool query builder. Signed-off-by: Chloe Gao <chloewq@amazon.com>
|
❕ Gradle check result for 7625494: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17409 +/- ##
============================================
- Coverage 72.42% 72.41% -0.01%
- Complexity 65611 65653 +42
============================================
Files 5304 5306 +2
Lines 304743 304608 -135
Branches 44189 44164 -25
============================================
- Hits 220701 220592 -109
- Misses 65888 65923 +35
+ Partials 18154 18093 -61 ☔ View full report in Codecov by Sentry. |
|
LGTM. Will wait until tomorrow to merge in case any other maintainer has any comments. |
|
Thanks, @chloewqg! Looks good to me! |
server/src/main/java/org/opensearch/index/query/BoolQueryBuilder.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/index/query/ConstantScoreQueryBuilder.java
Outdated
Show resolved
Hide resolved
…antScoreQueryBuilder. (opensearch-project#17409) * The filter function will combine a filter with the query builder. If the query builder itself has a filter we will combine the filter and return the query builder itself. If no we will use a bool query builder to combine the query builder and the filter and then return the bool query builder. Signed-off-by: Chloe Gao <chloewq@amazon.com>
|
❌ Gradle check result for 0c28541: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
…antScoreQueryBuilder. (opensearch-project#17409) * The filter function will combine a filter with the query builder. If the query builder itself has a filter we will combine the filter and return the query builder itself. If no we will use a bool query builder to combine the query builder and the filter and then return the bool query builder. Signed-off-by: Chloe Gao <chloewq@amazon.com>
|
❕ Gradle check result for 4de6f56: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
…antScoreQueryBuilder. (opensearch-project#17409) (opensearch-project#17409) * The filter function will combine a filter with the query builder. If the query builder itself has a filter we will combine the filter and return the query builder itself. If no we will use a bool query builder to combine the query builder and the filter and then return the bool query builder. Signed-off-by: Chloe Gao <chloewq@amazon.com>
Description
The filter function will combine a filter with the query builder. If the query builder itself has a filter we will combine the filter and return the query builder itself. If no we will use a bool query builder to combine the query builder and the filter and then return the bool query builder.
Related Issues
Resolves #17409
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.