Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.19] Add highlighting for match_only_text type (#17101) #17214

Merged
merged 1 commit into from
Jan 31, 2025

Conversation

msfroh
Copy link
Collaborator

@msfroh msfroh commented Jan 30, 2025

Description

Manual backport of #17101

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

---------

Signed-off-by: Eugene Tolbakov <ev.tolbakov@gmail.com>
Copy link
Contributor

✅ Gradle check result for dc0ebf6: SUCCESS

Copy link

codecov bot commented Jan 31, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 72.40%. Comparing base (93c072b) to head (dc0ebf6).
Report is 1 commits behind head on 2.19.

Files with missing lines Patch % Lines
...earch/fetch/subphase/highlight/HighlightPhase.java 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               2.19   #17214      +/-   ##
============================================
+ Coverage     72.00%   72.40%   +0.40%     
- Complexity    66007    66325     +318     
============================================
  Files          5341     5341              
  Lines        307137   307138       +1     
  Branches      44826    44827       +1     
============================================
+ Hits         221143   222392    +1249     
+ Misses        67528    66509    -1019     
+ Partials      18466    18237     -229     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mch2 mch2 merged commit 8c9554d into opensearch-project:2.19 Jan 31, 2025
97 of 98 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants