Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the compiler task status reporting for annotation processor #17063

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

reta
Copy link
Collaborator

@reta reta commented Jan 20, 2025

Description

Fix the compiler task status reporting for annotation processor. The Java compiler was reporting failures previously only because the SecurityManager was preventing the writing of class files into build folder. This was not very important because the annotation processing was always happening before (and this is what tests were checking). The change fixes the issue by outputting class files into temporary folder.

Related Issues

Follow up on #16962

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
@reta
Copy link
Collaborator Author

reta commented Jan 20, 2025

@rishabhmaurya FYI, thanks!

Copy link
Contributor

✅ Gradle check result for 0aa3f8e: SUCCESS

Copy link

codecov bot commented Jan 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.29%. Comparing base (1b4a817) to head (0aa3f8e).
Report is 2 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #17063      +/-   ##
============================================
+ Coverage     72.23%   72.29%   +0.06%     
- Complexity    65292    65371      +79     
============================================
  Files          5301     5301              
  Lines        303823   303823              
  Branches      44033    44033              
============================================
+ Hits         219454   219654     +200     
+ Misses        66344    66166     -178     
+ Partials      18025    18003      -22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@reta reta merged commit 6e3d710 into opensearch-project:main Jan 21, 2025
71 of 72 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jan 21, 2025
Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
(cherry picked from commit 6e3d710)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch skip-changelog :test Adding or fixing a test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants