[Backport 2.x] Fix getTime field name to time in GetStats (#16894) #17047
+46
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix getTime field name to time in GetStats (#16894) Signed-off-by: hye-on <ain0103@naver.com> * Update PR number in changelog Signed-off-by: hye-on <ain0103@naver.com> * Deprecate getTime field and add time field in GetStats for backward compatibility Signed-off-by: hye-on <ain0103@naver.com> * Add forRemoval flag to getTime field for future removal Signed-off-by: hye-on <ain0103@naver.com> * Changed to use field instead of humanReadableField for GET_TIME in JSON response Replaced the use of builder.humanReadableField for the GET_TIME field with builder.field(Fields.GET_TIME, Objects.toString(getTime())). This prevents the duplication of the time_in_millis field. Signed-off-by: hye-on <ain0103@naver.com> * Add test to validate getTime and time fields in _stats API response getTime and time fields are verified to be included in the _stats API response and correctly aligned. Signed-off-by: hye-on <ain0103@naver.com> * Fix formatting in GetStats.java Signed-off-by: hye-on <ain0103@naver.com> * Rename test file to better reflect test purpose Signed-off-by: hye-on <ain0103@naver.com> * Test Add skip version for stats API human filter test under 2.19.99 Signed-off-by: hye-on <ain0103@naver.com> * Remove unnecessary changelog entries Signed-off-by: hye-on <ain0103@naver.com> * Add a line for styling purposes Signed-off-by: hye-on <ain0103@naver.com> --------- Signed-off-by: hye-on <ain0103@naver.com> (cherry picked from commit fe1f0d8) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
reta
approved these changes
Jan 17, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.x #17047 +/- ##
============================================
- Coverage 72.01% 71.91% -0.10%
+ Complexity 65652 65638 -14
============================================
Files 5318 5318
Lines 305831 305833 +2
Branches 44601 44601
============================================
- Hits 220233 219931 -302
- Misses 67235 67531 +296
- Partials 18363 18371 +8 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport fe1f0d8 from #17009.