Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Fix remote shards balance #16972

Merged

Conversation

bugmakerrrrrr
Copy link
Contributor

Description

backport #15335

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

* Fix remote shards balance

Signed-off-by: panguixin <panguixin@bytedance.com>

* add changelog

Signed-off-by: panguixin <panguixin@bytedance.com>

---------

Signed-off-by: panguixin <panguixin@bytedance.com>
Signed-off-by: Andrew Ross <andrross@amazon.com>
Co-authored-by: Andrew Ross <andrross@amazon.com>
(cherry picked from commit b359dd8)
Copy link
Contributor

github-actions bot commented Jan 7, 2025

❌ Gradle check result for fc51b60: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Member

@kotwanikunal kotwanikunal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @bugmakerrrrrr!

Copy link
Contributor

github-actions bot commented Jan 8, 2025

✅ Gradle check result for fc51b60: SUCCESS

Copy link

codecov bot commented Jan 8, 2025

Codecov Report

Attention: Patch coverage is 55.55556% with 4 lines in your changes missing coverage. Please review.

Project coverage is 71.81%. Comparing base (8a17b8a) to head (db04416).
Report is 12 commits behind head on 2.x.

Files with missing lines Patch % Lines
...ing/allocation/allocator/RemoteShardsBalancer.java 55.55% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                2.x   #16972      +/-   ##
============================================
- Coverage     71.85%   71.81%   -0.05%     
- Complexity    65507    65512       +5     
============================================
  Files          5316     5316              
  Lines        305588   305595       +7     
  Branches      44516    44518       +2     
============================================
- Hits         219572   219450     -122     
- Misses        67674    67857     +183     
+ Partials      18342    18288      -54     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Andrew Ross <andrross@amazon.com>
Copy link
Contributor

github-actions bot commented Jan 8, 2025

❌ Gradle check result for db04416: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

✅ Gradle check result for db04416: SUCCESS

@andrross andrross merged commit a83f9e0 into opensearch-project:2.x Jan 13, 2025
36 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants