-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Pull-based Ingestion] Introduce the new pull-based ingestion engine, APIs, and Kafka plugin #16958
Conversation
❌ Gradle check result for 16dd9d0: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
server/src/main/java/org/opensearch/index/engine/IngestionEngine.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/index/engine/IngestionEngine.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Curious how would the FGAC security model work, espl with security plugin which intercepts transport actions to validate if authorised users can perform bulk actions on certain indices. Is the intent to handle permissions at a Kafka "partition level"
Another aspect is maintaining Kafka checkpoints durably, I'm yet to read that part but would be good to understand how are we handling fail overs and recoveries
server/src/main/java/org/opensearch/plugins/IngestionConsumerPlugin.java
Show resolved
Hide resolved
server/src/main/java/org/opensearch/indices/ingest/package-info.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/indices/ingest/StreamPoller.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/index/engine/IngestionEngine.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Yupeng Fu <yupeng@uber.com>
Signed-off-by: Yupeng Fu <yupeng@uber.com>
Signed-off-by: Yupeng Fu <yupeng@uber.com>
…cessing Signed-off-by: Yupeng Fu <yupeng@uber.com>
Signed-off-by: Yupeng Fu <yupeng@uber.com>
Signed-off-by: Yupeng Fu <yupeng@uber.com>
Signed-off-by: Yupeng Fu <yupeng@uber.com>
Signed-off-by: Yupeng Fu <yupeng@uber.com>
Signed-off-by: Yupeng Fu <yupeng@uber.com>
Signed-off-by: Yupeng Fu <yupeng@uber.com>
Signed-off-by: Yupeng Fu <yupeng@uber.com>
Signed-off-by: Yupeng Fu <yupeng@uber.com>
Signed-off-by: Yupeng Fu <yupeng@uber.com>
Signed-off-by: Yupeng Fu <yupeng@uber.com>
Signed-off-by: Yupeng Fu <yupeng@uber.com>
Signed-off-by: Yupeng Fu <yupeng@uber.com>
Signed-off-by: Yupeng Fu <yupeng@uber.com>
Signed-off-by: Yupeng Fu <yupeng@uber.com>
aec6e15
to
acb627e
Compare
❕ Gradle check result for acb627e: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Description
This PR implements the basics of the pull-based ingestion described in this RFC, including:
Currently WIP, and there are a few improvements to make and test coverage to increase
Related Issues
Resolves #16927 #16929 #16928
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.