Refactor LegacyESVersion tests from Version tests #1662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In preparation for removing all LegacyESVersion support by 3.0; this commit largely refactors the LegacyESVersion test logic from the OpenSearch version test logic into an independent test class. Note that bwc w/ legacy versions are still supported so some cross compatibility testing is retained in the Version test class. Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
|
Can one of the admins verify this patch? |
|
✅ Gradle Wrapper Validation success 83d52f6 |
|
✅ Gradle Precommit success 83d52f6 |
dblock
approved these changes
Dec 7, 2021
|
I think we can also backport this to 1.x to reduce drift, right? Label the issue before you merge if you agree. |
nknize
added a commit
to nknize/OpenSearch
that referenced
this pull request
Jan 14, 2022
…#1662) In preparation for removing all LegacyESVersion support by 3.0; this commit largely refactors the LegacyESVersion test logic from the OpenSearch Version test logic into an independent test class. This PR also updates Version.fromString to ensure a proper legacy version is returned when major is > 3 (to support legacy yaml test and build scripts). Note that bwc w/ legacy versions are still supported so some cross compatibility testing is retained in the Version test class. Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
dblock
pushed a commit
that referenced
this pull request
Jan 17, 2022
In preparation for removing all LegacyESVersion support by 3.0; this commit largely refactors the LegacyESVersion test logic from the OpenSearch Version test logic into an independent test class. This PR also updates Version.fromString to ensure a proper legacy version is returned when major is > 3 (to support legacy yaml test and build scripts). Note that bwc w/ legacy versions are still supported so some cross compatibility testing is retained in the Version test class. Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for removing all LegacyESVersion support by 3.0; this PR
largely refactors the
LegacyESVersiontest logic from the OpenSearchVersiontest logic into an independent test class. This PR also updates
Version.fromStringto ensure a proper legacy version is returned when major is > 3 (to support
legacy yaml test and build scripts).
Note that bwc w/ legacy versions are still supported so some cross compatibility
testing is retained in the Version test class.