Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Forwardport] [main] Fix japicmp configuration by treating abstract-to-default method changes as non-breaking #16181

Merged

Conversation

reta
Copy link
Collaborator

@reta reta commented Oct 3, 2024

Forwardport of #16141 to main

…ges as non-breaking

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
@reta
Copy link
Collaborator Author

reta commented Oct 3, 2024

@sachinpkale please when you have time, thank you

Copy link
Contributor

github-actions bot commented Oct 3, 2024

❌ Gradle check result for ac8e52d: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Oct 3, 2024

❕ Gradle check result for ac8e52d: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link

codecov bot commented Oct 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.87%. Comparing base (6020c58) to head (ac8e52d).
Report is 3 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #16181      +/-   ##
============================================
- Coverage     71.88%   71.87%   -0.02%     
+ Complexity    64496    64468      -28     
============================================
  Files          5291     5291              
  Lines        301668   301668              
  Branches      43576    43576              
============================================
- Hits         216863   216817      -46     
+ Misses        67031    67019      -12     
- Partials      17774    17832      +58     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sachinpkale
Copy link
Member

Thanks for making this change!

@sachinpkale sachinpkale merged commit f9e0c85 into opensearch-project:main Oct 4, 2024
58 of 59 checks passed
dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 16, 2024
…ges as non-breaking (opensearch-project#16181)

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 17, 2024
…ges as non-breaking (opensearch-project#16181)

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 21, 2024
…ges as non-breaking (opensearch-project#16181)

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
akolarkunnu pushed a commit to akolarkunnu/OpenSearch that referenced this pull request Jan 21, 2025
…ges as non-breaking (opensearch-project#16181)

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants