Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bwc test failures by updating wire compatibility on NodeIndicesStats #15709

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

mch2
Copy link
Member

@mch2 mch2 commented Sep 5, 2024

2.x has updated to V_2_17_0, forward port to main to fix bwc.

Description

https://github.com/opensearch-project/OpenSearch/pull/15678/files and d2ae53e were updated on current 2.17 branches, this updates 3.0 to the correct version.

Related Issues

my sanity

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

2.x has updated to V_2_17_0, forward port to main to fix bwc.

Signed-off-by: Marc Handalian <marc.handalian@gmail.com>
@harshavamsi
Copy link
Contributor

Related Issues

my sanity

😆

Copy link
Contributor

github-actions bot commented Sep 5, 2024

✅ Gradle check result for bfb2f8e: SUCCESS

@mch2 mch2 merged commit 729e40d into opensearch-project:main Sep 5, 2024
60 of 61 checks passed
Copy link

codecov bot commented Sep 5, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 71.85%. Comparing base (71a771e) to head (bfb2f8e).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
...h/action/admin/indices/stats/CommonStatsFlags.java 0.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##               main   #15709    +/-   ##
==========================================
  Coverage     71.85%   71.85%            
- Complexity    64077    64114    +37     
==========================================
  Files          5269     5270     +1     
  Lines        299880   300052   +172     
  Branches      43343    43368    +25     
==========================================
+ Hits         215477   215611   +134     
- Misses        66679    66746    +67     
+ Partials      17724    17695    -29     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

akolarkunnu pushed a commit to akolarkunnu/OpenSearch that referenced this pull request Sep 10, 2024
dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 16, 2024
dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 17, 2024
dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants