-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Snapshot V2] Support pinned timestamp in clone flow #15524
Conversation
Signed-off-by: Anshu Agarwal <anshukag@amazon.com>
❌ Gradle check result for 5b21150: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 83f699c: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #15524 +/- ##
============================================
- Coverage 71.95% 71.73% -0.23%
+ Complexity 64192 64094 -98
============================================
Files 5270 5271 +1
Lines 300052 300287 +235
Branches 43368 43387 +19
============================================
- Hits 215917 215421 -496
- Misses 66442 67176 +734
+ Partials 17693 17690 -3 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like we need more tests?
Sorry , i missed this before merging . @anshu1106 , can you please take this as a follow up ?
Signed-off-by: Anshu Agarwal <anshukag@amazon.com> (cherry picked from commit debd040) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ITs are covering all the cases. Let me know if you have anything specific. |
(cherry picked from commit debd040) Signed-off-by: Anshu Agarwal <anshukag@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: Anshu Agarwal <anshukag@amazon.com> (cherry picked from commit debd040) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: Anshu Agarwal <anshukag@amazon.com> (cherry picked from commit debd040) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
(cherry picked from commit debd040) Signed-off-by: Anshu Agarwal <anshukag@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…ect#15524) Signed-off-by: Anshu Agarwal <anshukag@amazon.com>
…ect#15524) Signed-off-by: Anshu Agarwal <anshukag@amazon.com>
…ect#15524) Signed-off-by: Anshu Agarwal <anshukag@amazon.com>
…ect#15524) Signed-off-by: Anshu Agarwal <anshukag@amazon.com>
Description
This PR introduce changes to support pinned timestamp in clone flow.
upload any shard metadata to the snapshot repository.
operation.
Related Issues
Resolves #15316
Check List
API changes companion pull request created, if applicable.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.