[Backport 2.16] Fix read/write stream method for Diff Manifest when shard diff file is null. #14952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shailendra Singh <singhlhs@amazon.com>
|
There's an auto-backport in #14950, it's the same right? |
|
Did this fix a bug user are seeing? It needed a CHANGELOG. I'll merge as is to keep the backports consistent, but please do add it if that's the case. |
dblock
approved these changes
Jul 24, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.16 #14952 +/- ##
============================================
- Coverage 71.49% 71.48% -0.02%
+ Complexity 62676 62625 -51
============================================
Files 5120 5120
Lines 294258 294257 -1
Branches 42880 42880
============================================
- Hits 210392 210360 -32
+ Misses 66248 66237 -11
- Partials 17618 17660 +42 ☔ View full report in Codecov by Sentry. |
No, bug was added as a part of recent commit in #14684 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backport 5744eae from #14938
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.