Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 1.x] Remove deprecated settings and logic for translog pruning by retentio… #1471

Merged
merged 1 commit into from
Nov 1, 2021
Merged

Conversation

adnapibar
Copy link
Contributor

…n lease. (#1416)

Backport #1416

Description

The settings and the corresponding logic for translog pruning by retention lease which were added as part of #1100 have been deprecated. This commit removes those deprecated code in favor of an extension point for providing a custom TranslogDeletionPolicy.

Issues Resolved

Related #1260

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Rabi Panda adnapibar@gmail.com

@adnapibar adnapibar added the backport PRs or issues specific to backporting features or enhancments label Oct 29, 2021
@opensearch-ci-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Wrapper Validation success 1d7e2451e9d38f9408624c4d39d8f4b1da958a38

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Precommit failure 1d7e2451e9d38f9408624c4d39d8f4b1da958a38
Log 1470

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure 1d7e2451e9d38f9408624c4d39d8f4b1da958a38
Log 898

Reports 898

…n lease. (#1416)

The settings and the corresponding logic for translog pruning by retention lease which were added as part of #1100 have been deprecated. This commit removes those deprecated code in favor of an extension point for providing a custom TranslogDeletionPolicy.

Signed-off-by: Rabi Panda <adnapibar@gmail.com>
@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Wrapper Validation success af91cca

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Precommit success af91cca

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success af91cca
Log 902

Reports 902

@adnapibar adnapibar requested a review from nknize October 29, 2021 22:30
Copy link
Collaborator

@nknize nknize left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thx!

@nknize nknize merged commit 300c1f8 into opensearch-project:1.x Nov 1, 2021
@nknize nknize added the v1.2.0 Issues related to version 1.2.0 label Nov 1, 2021
@adnapibar adnapibar deleted the backport1.x_1416 branch December 26, 2021 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport PRs or issues specific to backporting features or enhancments v1.2.0 Issues related to version 1.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants