Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run spotless and exclude checkstyle on modules module #1442

Merged
merged 1 commit into from
Oct 27, 2021

Conversation

owaiskazi19
Copy link
Member

@owaiskazi19 owaiskazi19 commented Oct 26, 2021

Description

Applied Spotless to modules module and excluded it from CheckStyle.

Issues Resolved

Part of #1362 and #974

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@opensearch-ci-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Wrapper Validation success a76f000f607059ae2d818a794c78b1b5c3646db7

@opensearch-ci-bot
Copy link
Collaborator

❌   DCO Check Failed a76f000f607059ae2d818a794c78b1b5c3646db7
Run ./dev-tools/signoff-check.sh remotes/origin/main a76f000f607059ae2d818a794c78b1b5c3646db7 to check locally
Use git commit with -s to add 'Signed-of-by: {EMAIL}' on impacted commits

Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>
@owaiskazi19 owaiskazi19 force-pushed the run-spotless-on-modules branch from a76f000 to 4a3e9d2 Compare October 26, 2021 17:54
@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Wrapper Validation success 4a3e9d2

@opensearch-ci-bot
Copy link
Collaborator

✅   DCO Check Passed 4a3e9d2

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Precommit success a76f000f607059ae2d818a794c78b1b5c3646db7

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Precommit success 4a3e9d2

@saratvemulapalli
Copy link
Member

start gradle check

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure 4a3e9d2
Log 824

Reports 824

@tlfeng
Copy link
Collaborator

tlfeng commented Oct 26, 2021

Start gradle check

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure 4a3e9d2
Log 825

Reports 825

@tlfeng
Copy link
Collaborator

tlfeng commented Oct 26, 2021

start gradle check

@tlfeng
Copy link
Collaborator

tlfeng commented Oct 26, 2021

In log 824:

REPRODUCE WITH: ./gradlew ':server:internalClusterTest' --tests "org.opensearch.cluster.ClusterHealthIT.testHealthOnMasterFailover" -Dtests.seed=95FB4DD53D88B228 -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=ja-JP-u-ca-japanese-x-lvariant-JP -Dtests.timezone=America/Kralendijk -Druntime.java=17

org.opensearch.cluster.ClusterHealthIT > testHealthOnMasterFailover FAILED
    java.util.concurrent.ExecutionException: MasterNotDiscoveredException[NodeClosedException[node closed {node_s1}{fYrditULRHW5Wvog5YW1bw}{g4Sr_Z9JR9K_lU9mBE8Smw}{127.0.0.1}{127.0.0.1:41761}{imr}

In log 825:

REPRODUCE WITH: ./gradlew ':server:test' --tests "org.opensearch.index.engine.InternalEngineTests.testEngineCreationWithCustomTranslogDeletePolicy" -Dtests.seed=B4EAB923A91DC9E9 -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=ro -Dtests.timezone=America/Santiago -Druntime.java=17

org.opensearch.index.engine.InternalEngineTests > testEngineCreationWithCustomTranslogDeletePolicy FAILED
    java.io.IOException: could not remove the following files (in the order of attempts):
       /var/CITOOL/workflow/OpenSearch_CI/PR_Checks/Gradle_Check/search/server/build/testrun/test/temp/org.opensearch.index.engine.InternalEngineTests_B4EAB923A91DC9E9-001/translog-primary-032/translog-2.tlog: java.io.IOException: access denied: /var/CITOOL/workflow/OpenSearch_CI/PR_Checks/Gradle_Check/search/server/build/testrun/test/temp/org.opensearch.index.engine.InternalEngineTests_B4EAB923A91DC9E9-001/translog-primary-032/translog-2.tlog

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success 4a3e9d2
Log 826

Reports 826

@owaiskazi19 owaiskazi19 requested a review from VachaShah October 27, 2021 20:10
@tlfeng tlfeng merged commit 37ac378 into opensearch-project:main Oct 27, 2021
owaiskazi19 added a commit to owaiskazi19/OpenSearch that referenced this pull request Oct 27, 2021
tlfeng pushed a commit that referenced this pull request Oct 28, 2021
Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>
@owaiskazi19 owaiskazi19 added the v1.2.0 Issues related to version 1.2.0 label Nov 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v1.2.0 Issues related to version 1.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants