Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.x] Read write ephemeral objects for remote publication of cluster state #14207

Merged
merged 1 commit into from
Jun 12, 2024
Merged

[Backport 2.x] Read write ephemeral objects for remote publication of cluster state #14207

merged 1 commit into from
Jun 12, 2024

Conversation

soosinha
Copy link
Member

  • Read and write ephemeral objects for remote publication

Backport of #14089

@github-actions GitHub Actions
Copy link
Contributor

✅ Gradle check result for baff192: SUCCESS

@codecov Codecov
Copy link

codecov bot commented Jun 12, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 56.81818% with 209 lines in your changes missing coverage. Please review.

Project coverage is 71.81%. Comparing base (0dd892c) to head (8e15c99).
Report is 355 commits behind head on 2.x.

Files Patch % Lines
...arch/gateway/remote/RemoteClusterStateService.java 50.73% 138 Missing and 29 partials ⚠️
...teway/remote/RemoteClusterStateCleanupManager.java 28.12% 13 Missing and 10 partials ⚠️
...pensearch/cluster/RepositoryCleanupInProgress.java 28.57% 9 Missing and 1 partial ⚠️
...ay/remote/RemoteClusterStateAttributesManager.java 70.00% 2 Missing and 1 partial ⚠️
...arch/index/recovery/RemoteStoreRestoreService.java 0.00% 2 Missing ⚠️
...ting/remote/InternalRemoteRoutingTableService.java 96.42% 0 Missing and 1 partial ⚠️
.../routing/remote/NoopRemoteRoutingTableService.java 50.00% 1 Missing ⚠️
...ateway/remote/model/RemoteClusterStateCustoms.java 85.71% 1 Missing ⚠️
server/src/main/java/org/opensearch/node/Node.java 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##                2.x   #14207      +/-   ##
============================================
+ Coverage     71.28%   71.81%   +0.53%     
- Complexity    60145    62515    +2370     
============================================
  Files          4957     5094     +137     
  Lines        282799   292333    +9534     
  Branches      41409    42617    +1208     
============================================
+ Hits         201591   209942    +8351     
- Misses        64189    65017     +828     
- Partials      17019    17374     +355

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions @soosinha
Read write ephemeral objects for remote publication of cluster state (o…
8e15c99 
…pensearch-project#14089)

* Read and write ephemeral objects for remote publication

Co-authored-by: Sooraj Sinha <soosinha@amazon.com>
Co-authored-by: Arpit Bandejiya <abandeji@amazon.com>

Signed-off-by: Shivansh Arora <hishiv@amazon.com>

* Add serde logic for hashes of consistent settings

Signed-off-by: Sooraj Sinha <soosinha@amazon.com>

* Add formattedName to readAsync for IndexMetadata

Signed-off-by: Shivansh Arora <hishiv@amazon.com>

(cherry picked from commit 990ddc3)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@soosinha soosinha force-pushed the backport/backport-14089-to-2.x branch from baff192 to 8e15c99 Compare June 12, 2024 02:59
@github-actions GitHub Actions
Copy link
Contributor

✅ Gradle check result for 8e15c99: SUCCESS

@shwetathareja shwetathareja mentioned this pull request Jun 12, 2024
Closed
@shwetathareja shwetathareja merged commit e318bb7 into opensearch-project:2.x Jun 12, 2024
60 of 62 checks passed
kkewwei pushed a commit to kkewwei/OpenSearch that referenced this pull request Jul 24, 2024
@soosinha @kkewwei
Read write ephemeral objects for remote publication of cluster state (o…
d9d4657 
…pensearch-project#14089) (opensearch-project#14207)

* Read and write ephemeral objects for remote publication

Co-authored-by: Sooraj Sinha <soosinha@amazon.com>
Co-authored-by: Arpit Bandejiya <abandeji@amazon.com>
Signed-off-by: Shivansh Arora <hishiv@amazon.com>

* Add serde logic for hashes of consistent settings

Signed-off-by: Sooraj Sinha <soosinha@amazon.com>

* Add formattedName to readAsync for IndexMetadata

Signed-off-by: Shivansh Arora <hishiv@amazon.com>

(cherry picked from commit 990ddc3)

Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Signed-off-by: kkewwei <kkewwei@163.com>
@soosinha soosinha deleted the backport/backport-14089-to-2.x branch December 20, 2024 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shwetathareja shwetathareja shwetathareja approved these changes

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@dreamer-89 dreamer-89 Awaiting requested review from dreamer-89

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@reta reta Awaiting requested review from reta reta is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@tlfeng tlfeng Awaiting requested review from tlfeng

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

Assignees
No one assigned
Labels
skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@soosinha @shwetathareja