Add extension point for custom TranslogDeletionPolicy in EnginePlugin. #1404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds a method that can be used to provide a custom TranslogDeletionPolicy. It also removes the deprecated settings for translog pruning based on retention leases. Signed-off-by: Rabi Panda <adnapibar@gmail.com>
|
Can one of the admins verify this patch? |
|
✅ Gradle Wrapper Validation success d521adf |
|
✅ DCO Check Passed d521adf |
|
✅ Gradle Precommit success d521adf |
nknize
requested changes
Oct 21, 2021
There was a problem hiding this comment.
This is looking good. Just a few important things:
- We need to retain "read only" bwc support for the CCR setting until OpenSearch 3.0
- Let's keep this PR simple to just adding the TranslogDeletionPolicy extension point and address retention lease setting removal in a separate PR
server/src/main/java/org/opensearch/common/settings/IndexScopedSettings.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Rabi Panda <adnapibar@gmail.com>
Signed-off-by: Rabi Panda <adnapibar@gmail.com>
|
✅ Gradle Wrapper Validation success 912504d |
|
✅ DCO Check Passed 912504d |
|
✅ Gradle Precommit success 912504d |
nknize
approved these changes
Oct 21, 2021
server/src/test/java/org/opensearch/index/engine/EngineConfigFactoryTests.java
Show resolved
Hide resolved
server/src/test/java/org/opensearch/index/engine/EngineConfigFactoryTests.java
Show resolved
Hide resolved
|
start gradle check |
andrross
reviewed
Oct 21, 2021
server/src/main/java/org/opensearch/index/engine/EngineConfig.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Rabi Panda <adnapibar@gmail.com>
5 tasks
|
✅ DCO Check Passed 1c39d8c |
|
✅ Gradle Wrapper Validation success 1c39d8c |
|
✅ Gradle Precommit success 1c39d8c |
|
start gradle check |
5 tasks
krishna-ggk
reviewed
Oct 22, 2021
|
Merged as is to let this bake in random testing. Let's iterate any changes, additions, bugs in separate PRs. |
nknize
pushed a commit
that referenced
this pull request
Oct 26, 2021
#1404) This commit adds a method that can be used to provide a custom TranslogDeletionPolicy from within plugins that implement the EnginePlugin interface. This enables plugins to provide a custom deletion policy with the current limitation that only one plugin can override the policy. An exception will be thrown if more than one plugin overrides the policy. Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
Merged
5 tasks
adnapibar
added a commit
that referenced
this pull request
Oct 29, 2021
…in EnginePlugin (#1404) (#1424) * Add extension point for custom TranslogDeletionPolicy in EnginePlugin. (#1404) This commit adds a method that can be used to provide a custom TranslogDeletionPolicy from within plugins that implement the EnginePlugin interface. This enables plugins to provide a custom deletion policy with the current limitation that only one plugin can override the policy. An exception will be thrown if more than one plugin overrides the policy. Signed-off-by: Rabi Panda <adnapibar@gmail.com> * Close first engine instance before creating second (#1457) When creating the second instance of an InternalEngine using the same translog config of the default InternalEngine instance, the second instance will attempt to delete all the existing translog files. I found a deterministic test failure when running with the seed `E3E6AAD95ABD299B`. As opposed to creating a second engine instance with a different translog location, just close the first one before creating the second. Signed-off-by: Andrew Ross <andrross@amazon.com> Co-authored-by: Andrew Ross <andrross@amazon.com>
saikaranam-amazon
pushed a commit
to opensearch-project/cross-cluster-replication
that referenced
this pull request
Nov 3, 2021
… retention leases (#209) * Provide a custom TranslogDeletionPolicy for translog pruning based on retention leases. This commit overrides the new getCustomTranslogDeletionPolicyFactory method of the EnginePlugin to provide a custom TranslogDeletionPolicy. The extension is added as part of OpenSearch 1.2 (opensearch-project/OpenSearch#1404). Signed-off-by: Rabi Panda <pandarab@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change adds a method that can be used to provide a custom TranslogDeletionPolicy.
It also removes the deprecated settings for translog pruning based on retention leases.The removal of deprecated settings and CCR specific logic will be done as part of a separate PR.Issues Resolved
Resolves #1260
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.
Signed-off-by: Rabi Panda adnapibar@gmail.com