Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.x] Fix flaky test CacheStatsAPIIndicesRequestCacheIT.testNullLevels() #13475

Merged
merged 1 commit into from
May 1, 2024
Merged

[Backport 2.x] Fix flaky test CacheStatsAPIIndicesRequestCacheIT.testNullLevels() #13475

merged 1 commit into from
May 1, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 5d61ac2 from #13457.

@github-actions
Fix flaky test CacheStatsAPIIndicesRequestCacheIT.testNullLevels() (#…
d818ddc 
…13457)

* Fix flaky test

Signed-off-by: Peter Alfonsi <petealft@amazon.com>

* Initialize CommonStatsFlags with empty array for levels

Signed-off-by: Peter Alfonsi <petealft@amazon.com>

* Fixes tests using incorrect null levels

Signed-off-by: Peter Alfonsi <petealft@amazon.com>

* rerun

Signed-off-by: Peter Alfonsi <petealft@amazon.com>

---------

Signed-off-by: Peter Alfonsi <petealft@amazon.com>
Co-authored-by: Peter Alfonsi <petealft@amazon.com>
(cherry picked from commit 5d61ac2)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for d818ddc: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@peteralfonsi
Copy link
Contributor

^ New flaky test issue: #13476

@peteralfonsi
Copy link
Contributor

I don't think I can rerun the gradle check as I don't yet have triage access to the repo, and the branch isn't in my fork. @dblock would you mind rerunning it?

@VachaShah
Copy link
Collaborator

Reran the gradle check.

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for d818ddc: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@peteralfonsi
Copy link
Contributor

#13473 (flaky test)

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 1, 2024

❕ Gradle check result for d818ddc: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.backwards.MixedClusterClientYamlTestSuiteIT.test {p0=indices.get_field_mapping/20_missing_field/Return empty object if field doesn't exist, but index does}

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@peteralfonsi
Copy link
Contributor

@dblock @VachaShah I think this is ready to merge.

@VachaShah VachaShah merged commit 291f686 into 2.x May 1, 2024
50 of 51 checks passed
@github-actions github-actions bot deleted the backport/backport-13457-to-2.x branch May 1, 2024 16:26
peteralfonsi pushed a commit to peteralfonsi/OpenSearch that referenced this pull request May 1, 2024
@opensearch-trigger-bot
Fix flaky test CacheStatsAPIIndicesRequestCacheIT.testNullLevels() (o…
35ccc5c 
…pensearch-project#13457) (opensearch-project#13475)

* Fix flaky test

* Initialize CommonStatsFlags with empty array for levels

* Fixes tests using incorrect null levels

* rerun

---------

(cherry picked from commit 5d61ac2)

Signed-off-by: Peter Alfonsi <petealft@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Peter Alfonsi <petealft@amazon.com>
(cherry picked from commit 291f686)
peteralfonsi pushed a commit to peteralfonsi/OpenSearch that referenced this pull request May 1, 2024
@opensearch-trigger-bot
Fix flaky test CacheStatsAPIIndicesRequestCacheIT.testNullLevels() (o…
af16613 
…pensearch-project#13457) (opensearch-project#13475)

* Fix flaky test

* Initialize CommonStatsFlags with empty array for levels

* Fixes tests using incorrect null levels

* rerun

---------

(cherry picked from commit 5d61ac2)

Signed-off-by: Peter Alfonsi <petealft@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Peter Alfonsi <petealft@amazon.com>
(cherry picked from commit 291f686)
@peteralfonsi peteralfonsi mentioned this pull request May 1, 2024
Merged
8 tasks
dblock pushed a commit that referenced this pull request May 1, 2024
@peteralfonsi @opensearch-trigger-bot
Fix flaky test CacheStatsAPIIndicesRequestCacheIT.testNullLevels() (#…
8e786c2 
…13457) (#13475) (#13485)

* Fix flaky test

* Initialize CommonStatsFlags with empty array for levels

* Fixes tests using incorrect null levels

* rerun

---------

(cherry picked from commit 5d61ac2)

Signed-off-by: Peter Alfonsi <petealft@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Peter Alfonsi <petealft@amazon.com>
(cherry picked from commit 291f686)

Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VachaShah VachaShah VachaShah approved these changes

@dblock dblock dblock approved these changes

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@dreamer-89 dreamer-89 Awaiting requested review from dreamer-89

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@reta reta Awaiting requested review from reta reta is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@tlfeng tlfeng Awaiting requested review from tlfeng

Assignees
No one assigned
Labels
skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@peteralfonsi @VachaShah @dblock