flaky test fix - assert cluster stats on ClusterManager Node

[rajiv-kv]

Description

The fix is for flaky test ClusterManagerDisruptionIT#testIsolateClusterManagerAndVerifyClusterStateConsensus where the verification of ClusterStateStats was failing. The test was asserting on the ClusterStats which was retrieved from a random node in cluster. However ClusterStateStats is local to a node and has to be verified on node which was ClusterManager before the disruption was started.

  2> REPRODUCE WITH: ./gradlew ':server:internalClusterTest' --tests "org.opensearch.discovery.ClusterManagerDisruptionIT.testIsolateClusterManagerAndVerifyClusterStateConsensus" -Dtests.seed=3DFAFA04789EDE1A -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=es-CU -Dtests.timezone=Asia/Katmandu -Druntime.java=21
  2> java.lang.AssertionError
        at __randomizedtesting.SeedInfo.seed([3DFAFA04789EDE1A:828A4C0EDAB2860B]:0)
        at org.junit.Assert.fail(Assert.java:87)
        at org.junit.Assert.assertTrue(Assert.java:42)
        at org.junit.Assert.assertTrue(Assert.java:53)
        at org.opensearch.discovery.ClusterManagerDisruptionIT.testIsolateClusterManagerAndVerifyClusterStateConsensus(ClusterManagerDisruptionIT.java:214)

Related Issues

Resolves #[11063]

Check List

• New functionality includes testing.
  • All tests pass
• New functionality has been documented.
  • New functionality has javadoc added
• Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
• Commits are signed per the DCO using --signoff
• Commit changes are listed out in CHANGELOG.md file (See: Changelog)
• Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[github-actions]

❌ Gradle check result for dbfb860: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

❌ Gradle check result for 9300535: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[rajiv-kv]

❌ Gradle check result for 9300535: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

org.opensearch.cluster.allocation.ClusterRerouteIT.testDelayWithALargeAmountOfShards
org.opensearch.cluster.coordination.AwarenessAttributeDecommissionIT.testConcurrentDecommissionAction
org.opensearch.cluster.coordination.AwarenessAttributeDecommissionIT.testConcurrentDecommissionAction
org.opensearch.cluster.coordination.AwarenessAttributeDecommissionIT.testConcurrentDecommissionAction
org.opensearch.cluster.coordination.AwarenessAttributeDecommissionIT.testConcurrentDecommissionAction

Flaky Tests :-
#1561
#12197

[github-actions]

❌ Gradle check result for 9300535: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[dblock]

❌ Gradle check result for 9300535: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

org.opensearch.indices.store.IndicesStoreIntegrationIT.testShardActiveElsewhereDoesNotDeleteAnother {p0={"cluster.remote_store.state.enabled":"true"}}

#12835

[github-actions]

✅ Gradle check result for 9300535: SUCCESS

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.42%. Comparing base (b15cb0c) to head (9300535).
Report is 221 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff             @@
##               main   #13383     +/-   ##
===========================================
  Coverage     71.42%   71.42%             
- Complexity    59978    60654    +676     
===========================================
  Files          4985     5039     +54     
  Lines        282275   285445   +3170     
  Branches      40946    41341    +395     
===========================================
+ Hits         201603   203871   +2268     
- Misses        63999    64757    +758     
- Partials      16673    16817    +144     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[rwali-aws]

Fixes #11063