[Backport 2.x] enabled mockTelemetryPlugin for IT and fixed OOM (#13054) #13269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…13054) * Disable stackTrace in MockSpanData by default Signed-off-by: Atharva Sharma <atharvasharma61@gmail.com> * enabled MockTelemetryPlugin for ITs Signed-off-by: Atharva Sharma <atharvasharma61@gmail.com> * Added the flag as system property Signed-off-by: Atharva Sharma <atharvasharma61@gmail.com> * Applied java spotless check Signed-off-by: Atharva Sharma <atharvasharma61@gmail.com> * Added details in changelog Signed-off-by: Atharva Sharma <atharvasharma61@gmail.com> * Added details in TESTING.md Signed-off-by: Atharva Sharma <atharvasharma61@gmail.com> * Update TESTING.md Signed-off-by: Atharva Sharma <60044988+atharvasharma61@users.noreply.github.com> --------- Signed-off-by: Atharva Sharma <atharvasharma61@gmail.com> Signed-off-by: Atharva Sharma <60044988+atharvasharma61@users.noreply.github.com> (cherry picked from commit 51009b7)
reta
approved these changes
Apr 17, 2024
|
❌ Gradle check result for 748c2a4: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.x #13269 +/- ##
============================================
- Coverage 71.28% 71.12% -0.17%
- Complexity 60145 60549 +404
============================================
Files 4957 5004 +47
Lines 282799 285411 +2612
Branches 41409 41729 +320
============================================
+ Hits 201591 202990 +1399
- Misses 64189 65225 +1036
- Partials 17019 17196 +177 ☔ View full report in Codecov by Sentry. |
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-13269-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 a14ec07beab625c28a377a97e40431ebf9d83472
# Push it to GitHub
git push --set-upstream origin backport/backport-13269-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.xThen, create a pull request where the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backport PR for #13054
Related Issues
Resolves #13054
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.