Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query insights exporters implementation #12982

Merged
merged 6 commits into from
Jun 6, 2024

Conversation

ansjcy
Copy link
Member

@ansjcy ansjcy commented Mar 29, 2024

Description

This PR implements generic query insights exporters to export insights data into local index and debug log. Also added the export functionality for top n queries service with related configuration endpoints.

Related Issues

Resolves #11296

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

github-actions bot commented Mar 29, 2024

Compatibility status:

Checks if related components are compatible with change b676849

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/flow-framework.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/sql.git]

Copy link
Contributor

❌ Gradle check result for 8265420: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@deshsidd
Copy link
Contributor

Changelog needs update

@ansjcy ansjcy force-pushed the query-insights-exporter branch from db57708 to d546d0d Compare June 6, 2024 16:36
Copy link
Contributor

github-actions bot commented Jun 6, 2024

❌ Gradle check result for d546d0d: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Jun 6, 2024

✅ Gradle check result for d546d0d: SUCCESS

@msfroh msfroh merged commit 0ddf4bd into opensearch-project:main Jun 6, 2024
29 of 30 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-12982-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 0ddf4bdd9ef14b2d8e928695bef08429579a6a5b
# Push it to GitHub
git push --set-upstream origin backport/backport-12982-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-12982-to-2.x.

ansjcy added a commit to ansjcy/OpenSearch that referenced this pull request Jun 7, 2024
---------

Signed-off-by: Chenyang Ji <cyji@amazon.com>
(cherry picked from commit 0ddf4bd)
ansjcy added a commit to ansjcy/OpenSearch that referenced this pull request Jun 7, 2024
---------

Signed-off-by: Chenyang Ji <cyji@amazon.com>
(cherry picked from commit 0ddf4bd)
jed326 pushed a commit that referenced this pull request Jun 7, 2024
---------

Signed-off-by: Chenyang Ji <cyji@amazon.com>
(cherry picked from commit 0ddf4bd)
parv0201 pushed a commit to parv0201/OpenSearch that referenced this pull request Jun 10, 2024
---------

Signed-off-by: Chenyang Ji <cyji@amazon.com>
kkewwei pushed a commit to kkewwei/OpenSearch that referenced this pull request Jul 24, 2024
…pensearch-project#14061)

---------

Signed-off-by: Chenyang Ji <cyji@amazon.com>
(cherry picked from commit 0ddf4bd)
Signed-off-by: kkewwei <kkewwei@163.com>
wdongyu pushed a commit to wdongyu/OpenSearch that referenced this pull request Aug 22, 2024
---------

Signed-off-by: Chenyang Ji <cyji@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch backport-failed enhancement Enhancement or improvement to existing feature or request Search:Query Insights v2.15.0 Issues and PRs related to version 2.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Asynchronous processor and exporter for query insights data
6 participants