-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix LinearRing serialization issue while emitting task description in… #12844
Conversation
… a trace log Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com>
❌ Gradle check result for 1924c28: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Compatibility status:Checks if related components are compatible with change 1924c28 Incompatible componentsSkipped componentsCompatible componentsCompatible components: [https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/flow-framework.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/performance-analyzer.git] |
@rishabhmaurya is it fixed by #12834 |
I love that there is so much interest in fixing failing tests! Too bad everyone is focused on fixing the same test :) |
I do not like the fact that the search task executes fine, its just when the trace logs are enabled and getDescription() on task is invoked which results in such failures. #12831 fixes it for linear ring but it could be some other field type tomorrow, originating from core/plugins. I will close this one |
We ended up merging a fix a little closer to what's here in #12834. Task description will not fail when it cannot be serialized, instead the description will contain the serialization error. |
This was a well isolated one, and I enjoyed figuring out and debating the best way to fix it! Thanks @shwetathareja @rishabhmaurya @andrross @reta and anyone I forgot to mention. |
… a trace log
Description
[Describe what this change achieves]
Related Issues
Resolves #11688
Check List
- [ ] Commit changes are listed out in CHANGELOG.md file (See: Changelog)- [ ] Public documentation issue/PR createdBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.