-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run link checker GitHub action on schedule. #1221
Conversation
Most PRs do not add/update links, however sites go down often. This makes sure that we catch any broken links in the repository and fix it but also do not block PRs because of some unrelated broken link. Signed-off-by: Rabi Panda <adnapibar@gmail.com>
✅ DCO Check Passed f0a8acf |
✅ Gradle Wrapper Validation success f0a8acf |
✅ Gradle Precommit success f0a8acf |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we are not running link checker on PR and push, how are we planning to track if there are any broken links? Would it be easier if we added some report at the end of the run which can easily show if there are any broken links? May be something like: https://github.com/lycheeverse/lychee-action#usage
When builds fail maintainers get GitHub notifications, IMHO this is sufficient. |
start gradle check |
start gradle check |
Failing test not reproducible
|
start gradle check |
Could we open an issue to track this, seems like this this is flaky. |
The failure is not reproducible with the same random seed, so don't think the test is flaky, maybe some issue with the environment. We are working on periodically running randomized testing on the CI and capturing the failures in one consolidated place (maybe a meta issue). IMO, creating a separate issue for all such failures at this point is going to create a lot of noise. |
Absolutely that makes sense to me. |
Description
Most PRs do not add/update links, however sites go down often. This change makes sure that we catch any broken links in the repository and fix it, but at the same time we do not block PRs because of some unrelated broken link.
This PR updates the workflow to run everyday at midnight UTC.
Issues Resolved
N/A
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.
Signed-off-by: Rabi Panda adnapibar@gmail.com