Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run link checker GitHub action on schedule. #1221

Merged
merged 1 commit into from
Sep 8, 2021
Merged

Run link checker GitHub action on schedule. #1221

merged 1 commit into from
Sep 8, 2021

Conversation

adnapibar
Copy link
Contributor

@adnapibar adnapibar commented Sep 7, 2021

Description

Most PRs do not add/update links, however sites go down often. This change makes sure that we catch any broken links in the repository and fix it, but at the same time we do not block PRs because of some unrelated broken link.

This PR updates the workflow to run everyday at midnight UTC.

Issues Resolved

N/A

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Rabi Panda adnapibar@gmail.com

Most PRs do not add/update links, however sites go down often. This makes sure that we catch any broken links in the repository and fix it but also do not block PRs because of some unrelated broken link.

Signed-off-by: Rabi Panda <adnapibar@gmail.com>
@adnapibar adnapibar added the CI CI related label Sep 7, 2021
@opensearch-ci-bot
Copy link
Collaborator

✅   DCO Check Passed f0a8acf

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Wrapper Validation success f0a8acf

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Precommit success f0a8acf

Copy link
Collaborator

@VachaShah VachaShah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we are not running link checker on PR and push, how are we planning to track if there are any broken links? Would it be easier if we added some report at the end of the run which can easily show if there are any broken links? May be something like: https://github.com/lycheeverse/lychee-action#usage

@dblock
Copy link
Member

dblock commented Sep 8, 2021

Since we are not running link checker on PR and push, how are we planning to track if there are any broken links? Would it be easier if we added some report at the end of the run which can easily show if there are any broken links? May be something like: https://github.com/lycheeverse/lychee-action#usage

When builds fail maintainers get GitHub notifications, IMHO this is sufficient.

@adnapibar
Copy link
Contributor Author

start gradle check

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure f0a8acf
Log 502

Reports 502

@adnapibar
Copy link
Contributor Author

start gradle check

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure f0a8acf
Log 505

Reports 505

@adnapibar
Copy link
Contributor Author

Failing test not reproducible

REPRODUCE WITH: ./gradlew ':server:internalClusterTest' --tests "org.opensearch.cluster.ClusterHealthIT.testHealthOnMasterFailover" -Dtests.seed=47EB5C58644C9840 -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1" -Dtests.locale=nl-NL -Dtests.timezone=America/St_Thomas -Druntime.java=15
  2> java.util.concurrent.ExecutionException: MasterNotDiscoveredException[NodeDisconnectedException[[node_s1][127.0.0.1:40191][cluster:monitor/health] disconnected]]; nested: NodeDisconnectedException[[node_s1][127.0.0.1:40191][cluster:monitor/health] disconnected];
        at __randomizedtesting.SeedInfo.seed([47EB5C58644C9840:D904737567A684A6]:0)
        at org.opensearch.common.util.concurrent.BaseFuture$Sync.getValue(BaseFuture.java:286)
        at org.opensearch.common.util.concurrent.BaseFuture$Sync.get(BaseFuture.java:273)
        at org.opensearch.common.util.concurrent.BaseFuture.get(BaseFuture.java:100)
        at org.opensearch.cluster.ClusterHealthIT.testHealthOnMasterFailover(ClusterHealthIT.java:357)

@adnapibar
Copy link
Contributor Author

start gradle check

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success f0a8acf
Log 508

Reports 508

@adnapibar adnapibar merged commit 3870522 into opensearch-project:main Sep 8, 2021
@saratvemulapalli
Copy link
Member

Failing test not reproducible

REPRODUCE WITH: ./gradlew ':server:internalClusterTest' --tests "org.opensearch.cluster.ClusterHealthIT.testHealthOnMasterFailover" -Dtests.seed=47EB5C58644C9840 -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1" -Dtests.locale=nl-NL -Dtests.timezone=America/St_Thomas -Druntime.java=15
  2> java.util.concurrent.ExecutionException: MasterNotDiscoveredException[NodeDisconnectedException[[node_s1][127.0.0.1:40191][cluster:monitor/health] disconnected]]; nested: NodeDisconnectedException[[node_s1][127.0.0.1:40191][cluster:monitor/health] disconnected];
        at __randomizedtesting.SeedInfo.seed([47EB5C58644C9840:D904737567A684A6]:0)
        at org.opensearch.common.util.concurrent.BaseFuture$Sync.getValue(BaseFuture.java:286)
        at org.opensearch.common.util.concurrent.BaseFuture$Sync.get(BaseFuture.java:273)
        at org.opensearch.common.util.concurrent.BaseFuture.get(BaseFuture.java:100)
        at org.opensearch.cluster.ClusterHealthIT.testHealthOnMasterFailover(ClusterHealthIT.java:357)

Could we open an issue to track this, seems like this this is flaky.
This PR: #1230 (comment) is also seeing a similar problem.

@adnapibar
Copy link
Contributor Author

Could we open an issue to track this, seems like this this is flaky.
This PR: #1230 (comment) is also seeing a similar problem.

The failure is not reproducible with the same random seed, so don't think the test is flaky, maybe some issue with the environment. We are working on periodically running randomized testing on the CI and capturing the failures in one consolidated place (maybe a meta issue). IMO, creating a separate issue for all such failures at this point is going to create a lot of noise.

@saratvemulapalli
Copy link
Member

Could we open an issue to track this, seems like this this is flaky.
This PR: #1230 (comment) is also seeing a similar problem.

The failure is not reproducible with the same random seed, so don't think the test is flaky, maybe some issue with the environment. We are working on periodically running randomized testing on the CI and capturing the failures in one consolidated place (maybe a meta issue). IMO, creating a separate issue for all such failures at this point is going to create a lot of noise.

Absolutely that makes sense to me.

@adnapibar adnapibar deleted the linkchecker-cron branch December 26, 2021 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI CI related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants