-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the means to extract the contextual underlying channel from HttpChannel without excessive typecasting #11751
Conversation
…hannel without excessive typecasting Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
Compatibility status:Checks if related components are compatible with change 1a6940b Incompatible componentsSkipped componentsCompatible componentsCompatible components: [https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/performance-analyzer.git] |
❌ Gradle check result for dd95708: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #11751 +/- ##
============================================
+ Coverage 71.27% 71.36% +0.09%
- Complexity 59176 59273 +97
============================================
Files 4909 4911 +2
Lines 278429 278656 +227
Branches 40460 40525 +65
============================================
+ Hits 198443 198869 +426
+ Misses 63528 63268 -260
- Partials 16458 16519 +61 ☔ View full report in Codecov by Sentry. |
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-11751-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 808ed56bcbc6ed547f64895cd02283df07fb5c48
# Push it to GitHub
git push --set-upstream origin backport/backport-11751-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x Then, create a pull request where the |
…hannel without excessive typecasting (opensearch-project#11751) Signed-off-by: Andriy Redko <andriy.redko@aiven.io> (cherry picked from commit 808ed56)
…hannel without excessive typecasting (opensearch-project#11751) Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
…hannel without excessive typecasting (opensearch-project#11751) Signed-off-by: Andriy Redko <andriy.redko@aiven.io> Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Description
Follow up on #10562 since more type casting code has been added into the
security
plugin.Related Issues
Relates to opensearch-project/security#3911
Check List
New functionality has been documented.New functionality has javadoc addedPublic documentation issue/PR createdBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.