Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] release build with no-jdk still ship the jdk15 #3024

Closed
spk opened this issue Apr 21, 2022 · 1 comment · Fixed by #3039
Closed

[BUG] release build with no-jdk still ship the jdk15 #3024

spk opened this issue Apr 21, 2022 · 1 comment · Fixed by #3039
Labels
bug Something isn't working Build Libraries & Interfaces

Comments

@spk
Copy link
Contributor

spk commented Apr 21, 2022 •
edited
Loading

Describe the bug

Currently ./gradlew :distribution:packages:no-jdk-deb:assemble build still ship the jdk15 in the deb package and use it on runtime

Related with opensearch-project/opensearch-build#99

To Reproduce
Steps to reproduce the behavior:

  1. Build ./gradlew :distribution:packages:no-jdk-deb:assemble
  2. Check the resulting package in distribution/packages/deb/build/distributions
  3. Inside the data.tar.gz the /./usr/share/opensearch/jdk/bin/ is present where it should not

Expected behavior

/./usr/share/opensearch/jdk should not be present

Plugins

none

Screenshots
If applicable, add screenshots to help explain your problem.

Host/Environment (please complete the following information):

  • OS: Linux
  • Version [e.g. 22]

Additional context

I think the issue have been introduced in 83e87f7#diff-f56331345059500af66c2e736bf18b5ee62d763d1d43af57a95a7709da1894ddR344 the second argument should have been kept (its currently true but it should be false for no-jdk build since first arg is jdk now)

On ES 7.10 https://github.com/elastic/elasticsearch/blob/7.10/distribution/packages/build.gradle#L371
@spk spk added bug Something isn't working untriaged labels Apr 21, 2022
@dblock
Copy link
Member

dblock commented Apr 21, 2022

@spk Would appreciate a fix! Also note opensearch-project/opensearch-build#99, which needs more work

@spk spk mentioned this issue Apr 22, 2022
Merged
5 tasks
spk added a commit to spk/OpenSearch that referenced this issue Apr 28, 2022
@spk
Build: do not ship jdk when no-jdk option set
17cf2a5 
When using package distribution

```
./gradlew :distribution:packages:no-jdk-deb:assemble
```

When `true` this include jdk switch the boolean to the correct value

fix opensearch-project#3024

Signed-off-by: Laurent Arnoud <laurent.arnoud@platform.sh>
dblock pushed a commit that referenced this issue Apr 29, 2022
@spk
Build: do not ship jdk when no-jdk option set (#3039)
8a19ccc 
When using package distribution

```
./gradlew :distribution:packages:no-jdk-deb:assemble
```

When `true` this include jdk switch the boolean to the correct value

fix #3024

Signed-off-by: Laurent Arnoud <laurent.arnoud@platform.sh>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working Build Libraries & Interfaces
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Build: do not ship jdk when no-jdk option set spk/OpenSearch
3 participants
@spk @dblock @Poojita-Raj