Removes explicit approach

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>
opensearch-project · Feb 5, 2024 · e1849a2 · e1849a2
1 parent 38bc0eb
commit e1849a2
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 11 deletions.
diff --git a/...s/telemetry-otel/src/main/java/org/opensearch/telemetry/metrics/OTelMetricsTelemetry.java b/...s/telemetry-otel/src/main/java/org/opensearch/telemetry/metrics/OTelMetricsTelemetry.java
@@ -10,7 +10,6 @@
 
 import org.opensearch.common.concurrent.RefCountedReleasable;
 import org.opensearch.telemetry.OTelTelemetryPlugin;
-import org.opensearch.telemetry.tracing.OTelResourceProvider;
 
 import java.io.Closeable;
 import java.io.IOException;
@@ -82,12 +81,8 @@ public Counter createUpDownCounter(String name, String description, String unit)
      */
     @Override
     public Histogram createHistogram(String name, String description, String unit) {
-        String internalMetricName = name + OTelResourceProvider.DYNAMIC_HISTOGRAM_METRIC_NAME_SUFFIX;
         DoubleHistogram doubleHistogram = AccessController.doPrivileged(
-            (PrivilegedAction<DoubleHistogram>) () -> otelMeter.histogramBuilder(internalMetricName)
-                .setUnit(unit)
-                .setDescription(description)
-                .build()
+            (PrivilegedAction<DoubleHistogram>) () -> otelMeter.histogramBuilder(name).setUnit(unit).setDescription(description).build()
         );
         return new OTelHistogram(doubleHistogram);
     }

diff --git a/...s/telemetry-otel/src/main/java/org/opensearch/telemetry/tracing/OTelResourceProvider.java b/...s/telemetry-otel/src/main/java/org/opensearch/telemetry/tracing/OTelResourceProvider.java
@@ -44,10 +44,6 @@
  * This class encapsulates all OpenTelemetry related resources
  */
 public final class OTelResourceProvider {
-    /**
-     * SUFFIX to differentiate dynamic and explicit bucket histograms.
-     */
-    public static final String DYNAMIC_HISTOGRAM_METRIC_NAME_SUFFIX = "-dynamic";
 
     private OTelResourceProvider() {}
 
@@ -102,7 +98,7 @@ private static SdkMeterProvider createSdkMetricProvider(Settings settings, Resou
                     .build()
             )
             .registerView(
-                InstrumentSelector.builder().setName("*" + DYNAMIC_HISTOGRAM_METRIC_NAME_SUFFIX).setType(InstrumentType.HISTOGRAM).build(),
+                InstrumentSelector.builder().setType(InstrumentType.HISTOGRAM).build(),
                 View.builder().setAggregation(Base2ExponentialHistogramAggregation.getDefault()).build()
             )
             .build();