Skip to content

Commit

Permalink
Addresses review comments
Browse files Browse the repository at this point in the history
Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>
  • Loading branch information
Gagan Juneja committed Feb 5, 2024
1 parent 3bb1322 commit a0b5034
Showing 1 changed file with 3 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -70,10 +70,9 @@ public Counter createUpDownCounter(String name, String description, String unit)
}

/**
* Creates the Otel Histogram. It created the default version. In {@link org.opensearch.telemetry.tracing.OTelResourceProvider}
* we can configure the bucketing strategy through view. It appends the OTelResourceProvider.DYNAMIC_HISTOGRAM_METRIC_NAME_SUFFIX
* to the metric name. It's needed to differentiate the {@link Histogram} metrics with explictt bucket or dynamic
* buckets. This suffix can be removed from the metric name in the collector.
* Creates the Otel Histogram. In {@link org.opensearch.telemetry.tracing.OTelResourceProvider}
* we can configure the bucketing/aggregation strategy through view. Default startegy configured
* is the {@link io.opentelemetry.sdk.metrics.internal.view.Base2ExponentialHistogramAggregation}.
* @param name name of the histogram.
* @param description any description about the metric.
* @param unit unit of the metric.
Expand Down

0 comments on commit a0b5034

Please sign in to comment.