Update Integ tests for Search WRR to include tests post removing WRR

Signed-off-by: Anshu Agarwal <anshukag@amazon.com>

CHANGELOG.md

@@ -51,7 +51,6 @@ Inspired from [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
 - Add DecommissionService and helper to execute awareness attribute decommissioning ([#4084](https://github.com/opensearch-project/OpenSearch/pull/4084))
 - Delete api for weighted shard routing([#4400](https://github.com/opensearch-project/OpenSearch/pull/4400/))
 
-
 ### Deprecated
 
 ### Removed

client/rest-high-level/src/test/java/org/opensearch/client/RestHighLevelClientTests.java

@@ -892,6 +892,7 @@ public void testApiNamingConventions() throws Exception {
             "cluster.put_weighted_routing",
             "cluster.get_weighted_routing",
             "cluster.delete_weighted_routing", };
+
         List<String> booleanReturnMethods = Arrays.asList("security.enable_user", "security.disable_user", "security.change_password");
         Set<String> deprecatedMethods = new HashSet<>();
         deprecatedMethods.add("indices.force_merge");

server/src/main/java/org/opensearch/action/ActionModule.java

@@ -571,10 +571,10 @@ public <Request extends ActionRequest, Response extends ActionResponse> void reg
         actions.register(CloneSnapshotAction.INSTANCE, TransportCloneSnapshotAction.class);
         actions.register(RestoreSnapshotAction.INSTANCE, TransportRestoreSnapshotAction.class);
         actions.register(SnapshotsStatusAction.INSTANCE, TransportSnapshotsStatusAction.class);
+
         actions.register(ClusterAddWeightedRoutingAction.INSTANCE, TransportAddWeightedRoutingAction.class);
         actions.register(ClusterGetWeightedRoutingAction.INSTANCE, TransportGetWeightedRoutingAction.class);
         actions.register(ClusterDeleteWeightedRoutingAction.INSTANCE, TransportDeleteWeightedRoutingAction.class);
-
         actions.register(IndicesStatsAction.INSTANCE, TransportIndicesStatsAction.class);
         actions.register(IndicesSegmentsAction.INSTANCE, TransportIndicesSegmentsAction.class);
         actions.register(IndicesShardStoresAction.INSTANCE, TransportIndicesShardStoresAction.class);

server/src/main/java/org/opensearch/action/admin/cluster/shards/routing/weighted/get/ClusterGetWeightedRoutingResponse.java

@@ -35,7 +35,7 @@ public class ClusterGetWeightedRoutingResponse extends ActionResponse implements
     private String localNodeWeight;
     private static final String NODE_WEIGHT = "node_weight";
 
-    public Object getLocalNodeWeight() {
+    public String getLocalNodeWeight() {
         return localNodeWeight;
     }
 

server/src/main/java/org/opensearch/action/admin/cluster/shards/routing/weighted/put/ClusterPutWeightedRoutingRequest.java

@@ -128,12 +128,14 @@ public ActionRequestValidationException validate() {
             validationException = addValidationError("Weights are missing", validationException);
         }
         int countValueWithZeroWeights = 0;
+        double weight;
         try {
-            for (Double value : weightedRouting.weights().values()) {
+            for (Object value : weightedRouting.weights().values()) {
                 if (value == null) {
                     validationException = addValidationError(("Weight is null"), validationException);
-                } else if (value == 0) {
-                    countValueWithZeroWeights++;
+                } else {
+                    weight = Double.parseDouble(value.toString());
+                    countValueWithZeroWeights = (weight == 0) ? countValueWithZeroWeights + 1 : countValueWithZeroWeights;
                 }
             }
         } catch (NumberFormatException e) {