Refactor util method

Signed-off-by: Aman Khare <amkhar@amazon.com>
opensearch-project · May 9, 2023 · 41c475e · 41c475e
1 parent 78db6b0
commit 41c475e
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/server/src/main/java/org/opensearch/cluster/coordination/JoinHelper.java b/server/src/main/java/org/opensearch/cluster/coordination/JoinHelper.java
@@ -283,7 +283,7 @@ private void handleValidateJoinRequest(
         ClusterState incomingState;
         try {
             if (in.readBoolean()) {
-                incomingState = CompressionHelper.deserializeFullClusterState(in, transportService);
+                incomingState = CompressionHelper.deserializeFullClusterState(in, transportService.getLocalNode());
                 runJoinValidators(currentStateSupplier, incomingState, joinValidators);
             } else {
                 logger.error("validate new node join request requires full cluster state");

diff --git a/server/src/main/java/org/opensearch/cluster/coordination/PublicationTransportHandler.java b/server/src/main/java/org/opensearch/cluster/coordination/PublicationTransportHandler.java
@@ -166,7 +166,7 @@ private PublishWithJoinResponse handleIncomingPublishRequest(BytesTransportReque
         ClusterState incomingState;
         try {
             if (in.readBoolean()) {
-                incomingState = CompressionHelper.deserializeFullClusterState(in, transportService);
+                incomingState = CompressionHelper.deserializeFullClusterState(in, transportService.getLocalNode());
                 fullClusterStateReceivedCount.incrementAndGet();
                 logger.debug("received full cluster state version [{}] with size [{}]", incomingState.version(), request.bytes().length());
                 final PublishWithJoinResponse response = acceptState(incomingState);

diff --git a/server/src/main/java/org/opensearch/common/compress/CompressionHelper.java b/server/src/main/java/org/opensearch/common/compress/CompressionHelper.java
@@ -75,10 +75,10 @@ public static StreamInput decompressClusterState(BytesTransportRequest request,
         return in;
     }
 
-    public static ClusterState deserializeFullClusterState(StreamInput in, TransportService transportService) throws IOException {
+    public static ClusterState deserializeFullClusterState(StreamInput in, DiscoveryNode localNode) throws IOException {
         final ClusterState incomingState;
         try (StreamInput input = in) {
-            incomingState = ClusterState.readFrom(input, transportService.getLocalNode());
+            incomingState = ClusterState.readFrom(input, localNode);
         } catch (Exception e) {
             logger.warn("unexpected error while deserializing an incoming cluster state", e);
             throw e;