-
Notifications
You must be signed in to change notification settings - Fork 936
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Discover] chore: Improve scrolling experience #9298
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Joey Liu <jiyili@amazon.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9298 +/- ##
==========================================
- Coverage 61.71% 61.70% -0.02%
==========================================
Files 3816 3816
Lines 91822 91829 +7
Branches 14542 14543 +1
==========================================
- Hits 56672 56666 -6
- Misses 31495 31507 +12
- Partials 3655 3656 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
No sure if there is a perfect solution for the bottom border, since adding it will also "visually breaking" row height when scrolling. |
@Maosaic here's a couple examples i found in some of the widely used tables:
I can find a couple more examples but i think the standard is either to have the border or a shadow EDIT: I found one that is like yours though: |
src/plugins/discover/public/application/components/default_discover_table/_doc_table.scss
Outdated
Show resolved
Hide resolved
Signed-off-by: Joey Liu <jiyili@amazon.com>
Description
Improve scrolling experience on Discover page:
Issues Resolved
Screenshot
Screen.Recording.2025-01-27.at.11.25.51.AM.mp4
Testing the changes
Changelog
Check List
yarn test:jest
yarn test:jest_integration