[Discover 2.0 Testing] Create View List of Saved Queries Test (Test-Id 124: View list of Saved query) #9166

ArgusLi · 2025-01-09T18:17:48Z

Description

Adds a Cypress test suite for Saved Queries Test Scope.

Issues Resolved

Closes #8975, #8977, #8978, #8979, #8980

Screenshot

newUICompressed.mp4

oldUICompressed.mp4

Testing the changes

With OSD running, run yarn run cypress open. In E2E specs, you will see 2 new test specs saved_queries.spec.js and saved_queries_old_ui.spec.js. Run saved_queries.spec.js if data.savedQueriesNewUI.enabled: true in the OSD config, else run saved_queries_old_ui.spec.js.

Changelog

test: Add cypress integration test for the old and new UI view saved queries.

Signed-off-by: Argus Li <contactme@chunkeili.com>

...rch-dashboards/opensearch-dashboards/apps/query_enhancements/field_display_filtering.spec.js

...re-opensearch-dashboards/opensearch-dashboards/apps/query_enhancements/saved_queries.spec.js

...search-dashboards/opensearch-dashboards/apps/query_enhancements/saved_queries_old_ui.spec.js

...re-opensearch-dashboards/opensearch-dashboards/apps/query_enhancements/saved_queries.spec.js

...e-opensearch-dashboards/opensearch-dashboards/apps/query_enhancements/utils/saved_queries.js

cypress/utils/apps/data_explorer/commands.js

cypress/utils/apps/query_enhancements/commands.js

Signed-off-by: Argus Li <contactme@chunkeili.com>

codecov · 2025-01-10T21:02:08Z

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 61.01%. Comparing base (e450f4d) to head (6297366).
Report is 26 commits behind head on main.

Files with missing lines	Patch %	Lines
...lugins/data/public/ui/saved_query_form/helpers.tsx	0.00%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #9166   +/-   ##
=======================================
  Coverage   61.01%   61.01%           
=======================================
  Files        3813     3813           
  Lines       91401    91401           
  Branches    14443    14443           
=======================================
  Hits        55770    55770           
  Misses      32068    32068           
  Partials     3563     3563

Flag	Coverage Δ
Linux_1	`29.08% <ø> (ø)`
Linux_2	`56.45% <ø> (ø)`
Linux_3	`38.02% <0.00%> (-0.01%)`	⬇️
Linux_4	`29.03% <ø> (ø)`
Windows_1	`29.09% <ø> (ø)`
Windows_2	`56.40% <ø> (ø)`
Windows_3	`38.03% <0.00%> (ø)`
Windows_4	`29.03% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

cypress/utils/apps/query_enhancements/commands.js

Signed-off-by: Argus Li <contactme@chunkeili.com>

...e-opensearch-dashboards/opensearch-dashboards/apps/query_enhancements/utils/saved_queries.js

Signed-off-by: Argus Li <contactme@chunkeili.com>

cypress/utils/apps/data_explorer/commands.js

… old ui and new ui commands Signed-off-by: Argus Li <contactme@chunkeili.com>

Signed-off-by: Argus Li <contactme@chunkeili.com>

ananzh · 2025-01-16T19:58:03Z

ciGroup 10 failure is a known issue and @angle943 is working on it

…d 124: View list of Saved query) (opensearch-project#9166) * add spec for old ui Signed-off-by: Argus Li <contactme@chunkeili.com> * Add comment about cleaning up saved queries Signed-off-by: Argus Li <contactme@chunkeili.com> * Add data-test-subj for save query new ui Signed-off-by: Argus Li <contactme@chunkeili.com> * Add data-test-subj for save query button for new ui Signed-off-by: Argus Li <contactme@chunkeili.com> * Add data-test-subj for open query button in query management popover Signed-off-by: Argus Li <contactme@chunkeili.com> * Add new ui spec to test list saved queries Signed-off-by: Argus Li <contactme@chunkeili.com> * Fix DataSource url Signed-off-by: Argus Li <contactme@chunkeili.com> * Changeset file for PR opensearch-project#9166 created/updated * Address Justin's comments. Signed-off-by: Argus Li <contactme@chunkeili.com> * Remove final force. Signed-off-by: Argus Li <contactme@chunkeili.com> * Fix final force. Signed-off-by: Argus Li <contactme@chunkeili.com> * Move utils to Suchit's suggested location, fix comments Signed-off-by: Argus Li <contactme@chunkeili.com> * Rename specs, change cypress workflow to use new save query ui, merge old ui and new ui commands Signed-off-by: Argus Li <contactme@chunkeili.com> * fix import Signed-off-by: Argus Li <contactme@chunkeili.com> --------- Signed-off-by: Argus Li <contactme@chunkeili.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>

…ing backports (#9261) * [Discover] Makes caching dataset options optional (#8799) * [Discover] Makes caching dataset options optional. * Adds unit test * Changeset file for PR #8799 created/updated * Update test Signed-off-by: Kawika Avilla <kavilla414@gmail.com> --------- Signed-off-by: Kawika Avilla <kavilla414@gmail.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: Kawika Avilla <kavilla414@gmail.com> * Upgrade Cypress to v12 (#8995) * Update Cypress to v12 (#8926) * Update cypress to v12 Signed-off-by: Daniel Rowe <rowdane@amazon.com> * Add required e2e.js Signed-off-by: Daniel Rowe <rowdane@amazon.com> * Changeset file for PR #8926 created/updated * Update license header Signed-off-by: Daniel Rowe <51932404+d-rowe@users.noreply.github.com> * Update license in e2e.js Signed-off-by: Daniel Rowe <51932404+d-rowe@users.noreply.github.com> --------- Signed-off-by: Daniel Rowe <rowdane@amazon.com> Signed-off-by: Daniel Rowe <51932404+d-rowe@users.noreply.github.com> Co-authored-by: Daniel Rowe <rowdane@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> * fix: support imports without extensions in cypress webpack build (#8993) * fix: support imports without extensions in cypress webpack build Signed-off-by: Daniel Rowe <rowdane@amazon.com> * Changeset file for PR #8993 created/updated * use typescript config Signed-off-by: Daniel Rowe <51932404+d-rowe@users.noreply.github.com> * fix lint Signed-off-by: Daniel Rowe <51932404+d-rowe@users.noreply.github.com> * disable new test isolation feature This isolation was causing regressions Signed-off-by: Daniel Rowe <51932404+d-rowe@users.noreply.github.com> --------- Signed-off-by: Daniel Rowe <rowdane@amazon.com> Signed-off-by: Daniel Rowe <51932404+d-rowe@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> --------- Signed-off-by: Daniel Rowe <rowdane@amazon.com> Signed-off-by: Daniel Rowe <51932404+d-rowe@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> * [Discover Test] TestID-69: Filtering. Add data-test-subj tags. (#9027) * Update Cypress to v12 (#8926) * Update cypress to v12 Signed-off-by: Daniel Rowe <rowdane@amazon.com> * Add required e2e.js Signed-off-by: Daniel Rowe <rowdane@amazon.com> * Changeset file for PR #8926 created/updated * Update license header Signed-off-by: Daniel Rowe <51932404+d-rowe@users.noreply.github.com> * Update license in e2e.js Signed-off-by: Daniel Rowe <51932404+d-rowe@users.noreply.github.com> --------- Signed-off-by: Daniel Rowe <rowdane@amazon.com> Signed-off-by: Daniel Rowe <51932404+d-rowe@users.noreply.github.com> Co-authored-by: Daniel Rowe <rowdane@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> * fix: support imports without extensions in cypress webpack build (#8993) * fix: support imports without extensions in cypress webpack build Signed-off-by: Daniel Rowe <rowdane@amazon.com> * Changeset file for PR #8993 created/updated * use typescript config Signed-off-by: Daniel Rowe <51932404+d-rowe@users.noreply.github.com> * fix lint Signed-off-by: Daniel Rowe <51932404+d-rowe@users.noreply.github.com> * disable new test isolation feature This isolation was causing regressions Signed-off-by: Daniel Rowe <51932404+d-rowe@users.noreply.github.com> --------- Signed-off-by: Daniel Rowe <rowdane@amazon.com> Signed-off-by: Daniel Rowe <51932404+d-rowe@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> * Add data-test-subj tags. Signed-off-by: Argus Li <contactme@chunkeili.com> --------- Signed-off-by: Daniel Rowe <rowdane@amazon.com> Signed-off-by: Daniel Rowe <51932404+d-rowe@users.noreply.github.com> Signed-off-by: Argus Li <contactme@chunkeili.com> Co-authored-by: Daniel Rowe <51932404+d-rowe@users.noreply.github.com> Co-authored-by: Daniel Rowe <rowdane@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> * Migrate query enhancement tests from functional repo to main (#9048) * migrate query enhacenement tests Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * ignore lint in data files Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * remove yarn lock changes Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * add changelog Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> --------- Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * Add missing data-test-subj tags for discover plugin (#9049) * Add data-test-subj for discover Signed-off-by: Anan Zhuang <ananzh@amazon.com> * fix comment Signed-off-by: Anan Zhuang <ananzh@amazon.com> --------- Signed-off-by: Anan Zhuang <ananzh@amazon.com> * Add missing data-test-subj tags for data plugin (#9051) * Add missing data-test-subj tags for data plugin * Update Snapshots * Fix as per the comments --------- Signed-off-by: Suchit Sahoo <suchsah@amazon.com> Co-authored-by: Anan Zhuang <ananzh@amazon.com> * Follow up on #9048 by updating data and utilities (#9060) * Follow up on #9048 by updating data and utilities Feature branch PRs: #9038 #9006 Signed-off-by: Anan <ananzh@amazon.com> * fix comment Signed-off-by: Anan <ananzh@amazon.com> * update path and add utility from suchit commit Signed-off-by: Anan <ananzh@amazon.com> * update the path to run sample test Signed-off-by: Anan <ananzh@amazon.com> * fix PR comments Signed-off-by: Anan <ananzh@amazon.com> * skip tests before enable workspace Signed-off-by: Anan <ananzh@amazon.com> --------- Signed-off-by: Anan <ananzh@amazon.com> * refactor some query-enhancement utility functions, add some missing typings (#9074) * refactor some query-enhancement utility functions, add some missing typings Signed-off-by: Justin Kim <jungkm@amazon.com> * Changeset file for PR #9074 created/updated --------- Signed-off-by: Justin Kim <jungkm@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> * add queryEditorLanguageOptions data-test-subj on language_selector.tsx (#9029) Signed-off-by: Federico Silva <federico.silva.-nd@disney.com> Co-authored-by: Federico Silva <federico.silva.-nd@disney.com> * Re-enable dataset_selector.spec.js and queries.spec.js under workspace (#9082) * Re-enable dataset_selector.spec.js and queries.spec.js under workspace Signed-off-by: Anan <ananzh@amazon.com> * fix comment Signed-off-by: Anan <ananzh@amazon.com> * add verifyHitCount for PPL Signed-off-by: Anan <ananzh@amazon.com> * Changeset file for PR #9082 created/updated --------- Signed-off-by: Anan <ananzh@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> * Make createWorkspaceIndexPatterns to handle no default cluster and clean up (#9129) * Make createWorkspaceIndexPatterns to handle no default cluster and clean up Signed-off-by: Anan <ananzh@amazon.com> * Changeset file for PR #9129 created/updated --------- Signed-off-by: Anan <ananzh@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> * add data-test-subj (#9135) Signed-off-by: Federico Silva <federico.silva.dev@gmail.com> * [Discover] Adding Cypress Tests for S3 Datasets (#9113) * [Discover 2.0 Testing] Create Filtering Test (TestId-69: Filtering) (#9119) * Add test for filtering functionality for discover, which enables query enhancement * Make test more robust: Add logic to use date picker start and end buttons if set to absolute times. Check the table length directly instead of number of hits to avoid bug where not all results load. --------- Signed-off-by: Argus Li <contactme@chunkeili.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> * Add tests for saved search creation and loading for query enhancement (#9112) * Add tests for saved search creation and loading for query enhancement * click on a random element before typing on query editor to bypass the popover that appears * address pr comments - refactor to create saved search as an api call * address pr comments - specifically navigate to discover page before setting datasource Signed-off-by: Justin Kim <jungkm@amazon.com> --------- Signed-off-by: Justin Kim <jungkm@amazon.com> Signed-off-by: Anan Zhuang <ananzh@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: Anan Zhuang <ananzh@amazon.com> * fix: 0 rendered in discover when there are no results (#9153) * fix: 0 rendered in discover when there are no results Signed-off-by: Daniel Rowe <rowdane@amazon.com> * Changeset file for PR #9153 created/updated --------- Signed-off-by: Daniel Rowe <rowdane@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> * [Cypress][Fix] Update saved search utilities (#9151) * update saved search * minor refactor4 on setDatePickerDatesAndSearchIfRelevant Signed-off-by: Justin Kim <jungkm@amazon.com> --------- Signed-off-by: Justin Kim <jungkm@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> * chore: use relative paths in cypress (#9079) * chore: use relative paths in cypress when we move to running tests in parallel we won't be able to use a single hardcoded basepath as these can differ by tasks Signed-off-by: Daniel Rowe <rowdane@amazon.com> * Changeset file for PR #9079 created/updated --------- Signed-off-by: Daniel Rowe <rowdane@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> * [Discover 2.0 Testing] Create View List of Saved Queries Test (Test-Id 124: View list of Saved query) (#9166) * add spec for old ui Signed-off-by: Argus Li <contactme@chunkeili.com> * Add comment about cleaning up saved queries Signed-off-by: Argus Li <contactme@chunkeili.com> * Add data-test-subj for save query new ui Signed-off-by: Argus Li <contactme@chunkeili.com> * Add data-test-subj for save query button for new ui Signed-off-by: Argus Li <contactme@chunkeili.com> * Add data-test-subj for open query button in query management popover Signed-off-by: Argus Li <contactme@chunkeili.com> * Add new ui spec to test list saved queries Signed-off-by: Argus Li <contactme@chunkeili.com> * Fix DataSource url Signed-off-by: Argus Li <contactme@chunkeili.com> * Changeset file for PR #9166 created/updated * Address Justin's comments. Signed-off-by: Argus Li <contactme@chunkeili.com> * Remove final force. Signed-off-by: Argus Li <contactme@chunkeili.com> * Fix final force. Signed-off-by: Argus Li <contactme@chunkeili.com> * Move utils to Suchit's suggested location, fix comments Signed-off-by: Argus Li <contactme@chunkeili.com> * Rename specs, change cypress workflow to use new save query ui, merge old ui and new ui commands Signed-off-by: Argus Li <contactme@chunkeili.com> * fix import Signed-off-by: Argus Li <contactme@chunkeili.com> --------- Signed-off-by: Argus Li <contactme@chunkeili.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> * change casing to folder structures to be compliant with our rules (#9197) Signed-off-by: Justin Kim <jungkm@amazon.com> * [Fix] Saved Search Integ Test Update: update saving a new saved search test spec (#9200) * wait for the page to be loaded before loading a saved search * when loading a saved search and saving it as a new saved search, use a different name Signed-off-by: Justin Kim <jungkm@amazon.com> --------- Signed-off-by: Justin Kim <jungkm@amazon.com> * refactor query enhancement tests (#9208) Signed-off-by: Justin Kim <jungkm@amazon.com> * chore: change casing of data-logs to be compliant with our git hook rules (#9220) Signed-off-by: Justin Kim <jungkm@amazon.com> * chore: remove unused/redundant functions from field_display_filtering utils (#9219) Signed-off-by: Justin Kim <jungkm@amazon.com> * Create cypress command namespacing util (#9150) * update cy.createInitialWorkspaceWithDataSource -> cy.osd.createInitialWorkspaceWithDataSource (#9262) Signed-off-by: Justin Kim <jungkm@amazon.com> --------- Signed-off-by: Kawika Avilla <kavilla414@gmail.com> Signed-off-by: Daniel Rowe <rowdane@amazon.com> Signed-off-by: Daniel Rowe <51932404+d-rowe@users.noreply.github.com> Signed-off-by: Argus Li <contactme@chunkeili.com> Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> Signed-off-by: Anan Zhuang <ananzh@amazon.com> Signed-off-by: Suchit Sahoo <suchsah@amazon.com> Signed-off-by: Anan <ananzh@amazon.com> Signed-off-by: Justin Kim <jungkm@amazon.com> Signed-off-by: Federico Silva <federico.silva.-nd@disney.com> Signed-off-by: Federico Silva <federico.silva.dev@gmail.com> Co-authored-by: Ashwin P Chandran <ashwinpc@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: Kawika Avilla <kavilla414@gmail.com> Co-authored-by: Daniel Rowe <51932404+d-rowe@users.noreply.github.com> Co-authored-by: Argus Li <43020525+ArgusLi@users.noreply.github.com> Co-authored-by: Daniel Rowe <rowdane@amazon.com> Co-authored-by: Qingyang(Abby) Hu <abigailhu2000@gmail.com> Co-authored-by: Suchit Sahoo <38322563+LDrago27@users.noreply.github.com> Co-authored-by: Justin Kim <jungkm@amazon.com> Co-authored-by: Federico Silva <federico.silva@improving.com> Co-authored-by: Federico Silva <federico.silva.-nd@disney.com> Co-authored-by: Federico Silva <federico.silva.dev@gmail.com> Co-authored-by: Sean Li <lnse@amazon.com> Co-authored-by: d rowe <51932404+d-buckner@users.noreply.github.com>

@angle943

* add spec for old ui Signed-off-by: Argus Li <contactme@chunkeili.com> * Add comment about cleaning up saved queries Signed-off-by: Argus Li <contactme@chunkeili.com> * Add data-test-subj for save query new ui Signed-off-by: Argus Li <contactme@chunkeili.com> * Add data-test-subj for save query button for new ui Signed-off-by: Argus Li <contactme@chunkeili.com> * Add data-test-subj for open query button in query management popover Signed-off-by: Argus Li <contactme@chunkeili.com> * Add new ui spec to test list saved queries Signed-off-by: Argus Li <contactme@chunkeili.com> * Fix DataSource url Signed-off-by: Argus Li <contactme@chunkeili.com> * Changeset file for PR #9166 created/updated * Address Justin's comments. Signed-off-by: Argus Li <contactme@chunkeili.com> * Remove final force. Signed-off-by: Argus Li <contactme@chunkeili.com> * Fix final force. Signed-off-by: Argus Li <contactme@chunkeili.com> * Move utils to Suchit's suggested location, fix comments Signed-off-by: Argus Li <contactme@chunkeili.com> * Rename specs, change cypress workflow to use new save query ui, merge old ui and new ui commands Signed-off-by: Argus Li <contactme@chunkeili.com> * fix import Signed-off-by: Argus Li <contactme@chunkeili.com> * Load query Signed-off-by: Argus Li <contactme@chunkeili.com> * Complete load query popover and flyout Signed-off-by: Argus Li <contactme@chunkeili.com> * Modularize view and load query popover and flyout Signed-off-by: Argus Li <contactme@chunkeili.com> * Complete valid Saved Queries shown across Visualize Pages Signed-off-by: Argus Li <contactme@chunkeili.com> * Complete Popover delete saved query Signed-off-by: Argus Li <contactme@chunkeili.com> * Add data-test-subj for flyoutbody and delete button. Signed-off-by: Argus Li <contactme@chunkeili.com> * Complete flyout delete saved query Signed-off-by: Argus Li <contactme@chunkeili.com> * Add data-test-subj for saveAsNewQueryCheckbox Signed-off-by: Argus Li <contactme@chunkeili.com> * Complete Flyout Update Saved Query Signed-off-by: Argus Li <contactme@chunkeili.com> * Complete Flyout Save as New Saved Query Signed-off-by: Argus Li <contactme@chunkeili.com> * Complete Popout Save as New Saved Query Signed-off-by: Argus Li <contactme@chunkeili.com> * Changeset file for PR #9229 created/updated * Fix merge Signed-off-by: Argus Li <contactme@chunkeili.com> * Move data-test-subj changes to another PR. Signed-off-by: Argus Li <contactme@chunkeili.com> * Remove savedQueriesNewUI Signed-off-by: Argus Li <contactme@chunkeili.com> * Address all comments. Signed-off-by: Argus Li <contactme@chunkeili.com> * Fix cypress command namespacing. Signed-off-by: Argus Li <contactme@chunkeili.com> * Rename saved queries spec. Signed-off-by: Argus Li <contactme@chunkeili.com> * Remove references to flyout Signed-off-by: Argus Li <contactme@chunkeili.com> * Refactor tests to work with beforeEach and afterEach Signed-off-by: Argus Li <contactme@chunkeili.com> * Add force to click when loading saved query. This removes delay when waiting for toast to disperse. Signed-off-by: Argus Li <contactme@chunkeili.com> * Fix test issue. Thank you @angle943 for finding a solution. Issue was caused by Cypress being too fast for the date picker to appear. Signed-off-by: Argus Li <contactme@chunkeili.com> --------- Signed-off-by: Argus Li <contactme@chunkeili.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: Anan Zhuang <ananzh@amazon.com>

@angle943

* add spec for old ui Signed-off-by: Argus Li <contactme@chunkeili.com> * Add comment about cleaning up saved queries Signed-off-by: Argus Li <contactme@chunkeili.com> * Add data-test-subj for save query new ui Signed-off-by: Argus Li <contactme@chunkeili.com> * Add data-test-subj for save query button for new ui Signed-off-by: Argus Li <contactme@chunkeili.com> * Add data-test-subj for open query button in query management popover Signed-off-by: Argus Li <contactme@chunkeili.com> * Add new ui spec to test list saved queries Signed-off-by: Argus Li <contactme@chunkeili.com> * Fix DataSource url Signed-off-by: Argus Li <contactme@chunkeili.com> * Changeset file for PR #9166 created/updated * Address Justin's comments. Signed-off-by: Argus Li <contactme@chunkeili.com> * Remove final force. Signed-off-by: Argus Li <contactme@chunkeili.com> * Fix final force. Signed-off-by: Argus Li <contactme@chunkeili.com> * Move utils to Suchit's suggested location, fix comments Signed-off-by: Argus Li <contactme@chunkeili.com> * Rename specs, change cypress workflow to use new save query ui, merge old ui and new ui commands Signed-off-by: Argus Li <contactme@chunkeili.com> * fix import Signed-off-by: Argus Li <contactme@chunkeili.com> * Load query Signed-off-by: Argus Li <contactme@chunkeili.com> * Complete load query popover and flyout Signed-off-by: Argus Li <contactme@chunkeili.com> * Modularize view and load query popover and flyout Signed-off-by: Argus Li <contactme@chunkeili.com> * Complete valid Saved Queries shown across Visualize Pages Signed-off-by: Argus Li <contactme@chunkeili.com> * Complete Popover delete saved query Signed-off-by: Argus Li <contactme@chunkeili.com> * Add data-test-subj for flyoutbody and delete button. Signed-off-by: Argus Li <contactme@chunkeili.com> * Complete flyout delete saved query Signed-off-by: Argus Li <contactme@chunkeili.com> * Add data-test-subj for saveAsNewQueryCheckbox Signed-off-by: Argus Li <contactme@chunkeili.com> * Complete Flyout Update Saved Query Signed-off-by: Argus Li <contactme@chunkeili.com> * Complete Flyout Save as New Saved Query Signed-off-by: Argus Li <contactme@chunkeili.com> * Complete Popout Save as New Saved Query Signed-off-by: Argus Li <contactme@chunkeili.com> * Changeset file for PR #9229 created/updated * Fix merge Signed-off-by: Argus Li <contactme@chunkeili.com> * Move data-test-subj changes to another PR. Signed-off-by: Argus Li <contactme@chunkeili.com> * Remove savedQueriesNewUI Signed-off-by: Argus Li <contactme@chunkeili.com> * Address all comments. Signed-off-by: Argus Li <contactme@chunkeili.com> * Fix cypress command namespacing. Signed-off-by: Argus Li <contactme@chunkeili.com> * Rename saved queries spec. Signed-off-by: Argus Li <contactme@chunkeili.com> * Remove references to flyout Signed-off-by: Argus Li <contactme@chunkeili.com> * Refactor tests to work with beforeEach and afterEach Signed-off-by: Argus Li <contactme@chunkeili.com> * Add force to click when loading saved query. This removes delay when waiting for toast to disperse. Signed-off-by: Argus Li <contactme@chunkeili.com> * Fix test issue. Thank you @angle943 for finding a solution. Issue was caused by Cypress being too fast for the date picker to appear. Signed-off-by: Argus Li <contactme@chunkeili.com> --------- Signed-off-by: Argus Li <contactme@chunkeili.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: Anan Zhuang <ananzh@amazon.com> (cherry picked from commit 969114f) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

@angle943

* add spec for old ui * Add comment about cleaning up saved queries * Add data-test-subj for save query new ui * Add data-test-subj for save query button for new ui * Add data-test-subj for open query button in query management popover * Add new ui spec to test list saved queries * Fix DataSource url * Changeset file for PR #9166 created/updated * Address Justin's comments. * Remove final force. * Fix final force. * Move utils to Suchit's suggested location, fix comments * Rename specs, change cypress workflow to use new save query ui, merge old ui and new ui commands * fix import * Load query * Complete load query popover and flyout * Modularize view and load query popover and flyout * Complete valid Saved Queries shown across Visualize Pages * Complete Popover delete saved query * Add data-test-subj for flyoutbody and delete button. * Complete flyout delete saved query * Add data-test-subj for saveAsNewQueryCheckbox * Complete Flyout Update Saved Query * Complete Flyout Save as New Saved Query * Complete Popout Save as New Saved Query * Changeset file for PR #9229 created/updated * Fix merge * Move data-test-subj changes to another PR. * Remove savedQueriesNewUI * Address all comments. * Fix cypress command namespacing. * Rename saved queries spec. * Remove references to flyout * Refactor tests to work with beforeEach and afterEach * Add force to click when loading saved query. This removes delay when waiting for toast to disperse. * Fix test issue. Thank you @angle943 for finding a solution. Issue was caused by Cypress being too fast for the date picker to appear. --------- (cherry picked from commit 969114f) Signed-off-by: Argus Li <contactme@chunkeili.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: Anan Zhuang <ananzh@amazon.com>

@angle943

…ct#9229) * add spec for old ui Signed-off-by: Argus Li <contactme@chunkeili.com> * Add comment about cleaning up saved queries Signed-off-by: Argus Li <contactme@chunkeili.com> * Add data-test-subj for save query new ui Signed-off-by: Argus Li <contactme@chunkeili.com> * Add data-test-subj for save query button for new ui Signed-off-by: Argus Li <contactme@chunkeili.com> * Add data-test-subj for open query button in query management popover Signed-off-by: Argus Li <contactme@chunkeili.com> * Add new ui spec to test list saved queries Signed-off-by: Argus Li <contactme@chunkeili.com> * Fix DataSource url Signed-off-by: Argus Li <contactme@chunkeili.com> * Changeset file for PR opensearch-project#9166 created/updated * Address Justin's comments. Signed-off-by: Argus Li <contactme@chunkeili.com> * Remove final force. Signed-off-by: Argus Li <contactme@chunkeili.com> * Fix final force. Signed-off-by: Argus Li <contactme@chunkeili.com> * Move utils to Suchit's suggested location, fix comments Signed-off-by: Argus Li <contactme@chunkeili.com> * Rename specs, change cypress workflow to use new save query ui, merge old ui and new ui commands Signed-off-by: Argus Li <contactme@chunkeili.com> * fix import Signed-off-by: Argus Li <contactme@chunkeili.com> * Load query Signed-off-by: Argus Li <contactme@chunkeili.com> * Complete load query popover and flyout Signed-off-by: Argus Li <contactme@chunkeili.com> * Modularize view and load query popover and flyout Signed-off-by: Argus Li <contactme@chunkeili.com> * Complete valid Saved Queries shown across Visualize Pages Signed-off-by: Argus Li <contactme@chunkeili.com> * Complete Popover delete saved query Signed-off-by: Argus Li <contactme@chunkeili.com> * Add data-test-subj for flyoutbody and delete button. Signed-off-by: Argus Li <contactme@chunkeili.com> * Complete flyout delete saved query Signed-off-by: Argus Li <contactme@chunkeili.com> * Add data-test-subj for saveAsNewQueryCheckbox Signed-off-by: Argus Li <contactme@chunkeili.com> * Complete Flyout Update Saved Query Signed-off-by: Argus Li <contactme@chunkeili.com> * Complete Flyout Save as New Saved Query Signed-off-by: Argus Li <contactme@chunkeili.com> * Complete Popout Save as New Saved Query Signed-off-by: Argus Li <contactme@chunkeili.com> * Changeset file for PR opensearch-project#9229 created/updated * Fix merge Signed-off-by: Argus Li <contactme@chunkeili.com> * Move data-test-subj changes to another PR. Signed-off-by: Argus Li <contactme@chunkeili.com> * Remove savedQueriesNewUI Signed-off-by: Argus Li <contactme@chunkeili.com> * Address all comments. Signed-off-by: Argus Li <contactme@chunkeili.com> * Fix cypress command namespacing. Signed-off-by: Argus Li <contactme@chunkeili.com> * Rename saved queries spec. Signed-off-by: Argus Li <contactme@chunkeili.com> * Remove references to flyout Signed-off-by: Argus Li <contactme@chunkeili.com> * Refactor tests to work with beforeEach and afterEach Signed-off-by: Argus Li <contactme@chunkeili.com> * Add force to click when loading saved query. This removes delay when waiting for toast to disperse. Signed-off-by: Argus Li <contactme@chunkeili.com> * Fix test issue. Thank you @angle943 for finding a solution. Issue was caused by Cypress being too fast for the date picker to appear. Signed-off-by: Argus Li <contactme@chunkeili.com> --------- Signed-off-by: Argus Li <contactme@chunkeili.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: Anan Zhuang <ananzh@amazon.com> Signed-off-by: Ubuntu <ubuntu@ip-172-31-47-220.us-west-2.compute.internal>

ArgusLi added 7 commits January 8, 2025 21:09

add spec for old ui

02bb7d4

Signed-off-by: Argus Li <contactme@chunkeili.com>

Add comment about cleaning up saved queries

af1352d

Signed-off-by: Argus Li <contactme@chunkeili.com>

Add data-test-subj for save query new ui

d6a713b

Signed-off-by: Argus Li <contactme@chunkeili.com>

Add data-test-subj for save query button for new ui

d6e0785

Signed-off-by: Argus Li <contactme@chunkeili.com>

Add data-test-subj for open query button in query management popover

a15bba2

Signed-off-by: Argus Li <contactme@chunkeili.com>

Add new ui spec to test list saved queries

47fe9a7

Signed-off-by: Argus Li <contactme@chunkeili.com>

Fix DataSource url

49a9352

Signed-off-by: Argus Li <contactme@chunkeili.com>

ArgusLi changed the title ~~[Discover 2.0 Testing] Create View Saved Queries Test (Test-Id 124: List Saved Queries)~~ [Discover 2.0 Testing] Create View List of Saved Queries Test (Test-Id 124: View list of Saved query) Jan 9, 2025

angle943 reviewed Jan 10, 2025

View reviewed changes

...rch-dashboards/opensearch-dashboards/apps/query_enhancements/field_display_filtering.spec.js Show resolved Hide resolved

angle943 requested changes Jan 10, 2025

View reviewed changes

Address Justin's comments.

edb8f9f

Signed-off-by: Argus Li <contactme@chunkeili.com>

angle943 reviewed Jan 10, 2025

View reviewed changes

cypress/utils/apps/query_enhancements/commands.js Outdated Show resolved Hide resolved

Remove final force.

4ae05a4

Signed-off-by: Argus Li <contactme@chunkeili.com>

LDrago27 reviewed Jan 10, 2025

View reviewed changes

...e-opensearch-dashboards/opensearch-dashboards/apps/query_enhancements/utils/saved_queries.js Outdated Show resolved Hide resolved

ArgusLi added 2 commits January 10, 2025 19:52

Fix final force.

b411dd0

Signed-off-by: Argus Li <contactme@chunkeili.com>

Move utils to Suchit's suggested location, fix comments

eeb0c63

Signed-off-by: Argus Li <contactme@chunkeili.com>

LDrago27 reviewed Jan 13, 2025

View reviewed changes

cypress/utils/apps/data_explorer/commands.js Outdated Show resolved Hide resolved

ArgusLi added 3 commits January 13, 2025 12:09

Rename specs, change cypress workflow to use new save query ui, merge…

3c2b2ec

… old ui and new ui commands Signed-off-by: Argus Li <contactme@chunkeili.com>

Merge main

59de88e

Signed-off-by: Argus Li <contactme@chunkeili.com>

fix import

6297366

Signed-off-by: Argus Li <contactme@chunkeili.com>

ananzh added the discover_2.0-test Issues that are specific to the Discover 2.0 testing initiative label Jan 16, 2025

ananzh approved these changes Jan 16, 2025

View reviewed changes

LDrago27 approved these changes Jan 16, 2025

View reviewed changes

LDrago27 merged commit 33f7ba6 into opensearch-project:main Jan 16, 2025
69 of 71 checks passed

angle943 mentioned this pull request Jan 18, 2025

Backport/backport lots of prs for discover 2.0 #9218

Closed

7 tasks

ananzh mentioned this pull request Jan 23, 2025

[2.x Manual Backport] Backport cypress related work to 2.x and 2 missing backports #9261

Merged

7 tasks

ananzh added the v2.19.0 label Jan 23, 2025

ananzh mentioned this pull request Feb 17, 2025

[GitHub Request] Add @angle943 as the maintainer for the OpenSearch-Dashboards as a outside collaborator opensearch-project/.github#287

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Discover 2.0 Testing] Create View List of Saved Queries Test (Test-Id 124: View list of Saved query) #9166

[Discover 2.0 Testing] Create View List of Saved Queries Test (Test-Id 124: View list of Saved query) #9166

ArgusLi commented Jan 9, 2025 •

edited

Loading

codecov bot commented Jan 10, 2025 •

edited

Loading

ananzh commented Jan 16, 2025

[Discover 2.0 Testing] Create View List of Saved Queries Test (Test-Id 124: View list of Saved query) #9166

[Discover 2.0 Testing] Create View List of Saved Queries Test (Test-Id 124: View list of Saved query) #9166

Conversation

ArgusLi commented Jan 9, 2025 • edited Loading

Description

Issues Resolved

Screenshot

Testing the changes

Changelog

codecov bot commented Jan 10, 2025 • edited Loading

Codecov Report

ananzh commented Jan 16, 2025

ArgusLi commented Jan 9, 2025 •

edited

Loading

codecov bot commented Jan 10, 2025 •

edited

Loading