[Backport 2.x] [Workspace] Add workspaceAvailability field into application #6628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* [Workspace] Jump to non-workspace url when clicking home icon (#316) * temp: save Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: complete the feature Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: remove useless code Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * fix: bootstrap error Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * fix: bootstrap error Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * fix: page not found error Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * fix: anchor href Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update toNavLink to comply with workspace Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: change to workspaceless Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: change to workspaceless Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: change to workspaceless Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: register list and create page as workspaceless Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: optimize code Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update to WorkspaceVisibility Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: add unit test Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: optimize the jump logic Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * fix: unit test Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: make app inaccessible if workspaceAccessibility is No Signed-off-by: SuZhou-Joe <suzhou@amazon.com> --------- Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * refactor: using WorkspaceAvailability Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: change test name Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update wording Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update test Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: add unit test Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: remove CHANGELOG change Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * Changeset file for PR #6427 created/updated * Apply suggestions from code review Co-authored-by: Yulong Ruan <ruanyu1@gmail.com> Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * Update src/plugins/workspace/public/utils.test.ts Co-authored-by: Miki <amoo_miki@yahoo.com> Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * Lint src/plugins/workspace/public/utils.test.ts Signed-off-by: Miki <amoo_miki@yahoo.com> * Lint src/plugins/workspace/public/utils.test.ts Signed-off-by: Miki <amoo_miki@yahoo.com> * Lint src/plugins/workspace/public/utils.test.ts Signed-off-by: Miki <amoo_miki@yahoo.com> * fix: lint error Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * fix: unit test Signed-off-by: SuZhou-Joe <suzhou@amazon.com> --------- Signed-off-by: SuZhou-Joe <suzhou@amazon.com> Signed-off-by: Miki <amoo_miki@yahoo.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: Yulong Ruan <ruanyu1@gmail.com> Co-authored-by: Miki <amoo_miki@yahoo.com> (cherry picked from commit 104ee42) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
SuZhou-Joe
approved these changes
Apr 24, 2024
ruanyl
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 104ee42 from #6427.